From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3CFA7CD1280 for ; Wed, 27 Mar 2024 15:23:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kAvtCBq7FnzsJpxaasNC/NEBsPpyeIqmt2wgHaAZyrw=; b=WXHrIDFFsH8Q5I KjXRcmTweLeCOsNhlhWDH6qzVw95noBakBusMzWV/LyYvv95lUjn04v2XAcldM/RiHO+AB81ImQhN zrdkD3heoWHTJ17bJnAau2ItXq38/mn3W9qMG66gPSZc8JiIm1KfevfjJeqc+GEesLTLoVC84uqmu 8Hdu3EqVy8i0TK8Ig0saoHNpCt044FNgAwnyRr2aubcfVR6H8JHhSrEMrqANeSCDIUfgIkvhyupP7 uvlDZwnlxbhs/FHKUgWwYx0Q85KvH9qAyzjKCtXQIJn40wAx6PTtpTkICB5+VUDrqvCyHjsn7ABHl Figh72ILTH7J8lFK3AKw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpV84-00000009lMb-0LuT; Wed, 27 Mar 2024 15:23:52 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpV7x-00000009lFD-0d8R for linux-riscv@lists.infradead.org; Wed, 27 Mar 2024 15:23:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711553024; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/g69WjpU0rXeMHNQq0wHJ20ikWbVhFRACidICzEeTCE=; b=bkvBedbze8RVNVsEW+6xD5cM6TwuRhHYlCAAPcieiEM5mVWDPZ/MUSSoZ8et5+FudChwbr ll8o6EhgzahcYrgnrDilfqGB8eYJn6ogSYlPOLu6QF06a32wzXjE5AWzt5YD7LGKMXIRWl rFOHvUuSH01eEIpR8piDboLY6uhQGGs= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-652-OJjPV9kzOn6hy-Jb7_BvCg-1; Wed, 27 Mar 2024 11:23:42 -0400 X-MC-Unique: OJjPV9kzOn6hy-Jb7_BvCg-1 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-696a5972507so4145696d6.0 for ; Wed, 27 Mar 2024 08:23:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711553022; x=1712157822; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/g69WjpU0rXeMHNQq0wHJ20ikWbVhFRACidICzEeTCE=; b=XoPsAGOyFdynO37rJnzJ9MVfKDtROa6nfLPKpz5hX+X4aTxxvIid++yBYZnWUt5cZo PhO18h/VxP1l25nP28Vmsa2DA58P+RjQ6hKeh+rRtGKWxRd0Z7KFkcODP6YZpnWLb02v ELG3tTbU2NIEOohiGMuh0J0ZIa8yy8jS4RVk4sDByrdxuRrvAn+7Jin8s90d3hGAE0uh Nrq/sh/+0a5bA040G6KxL19nN0rVcCpNP08WpCQJDLOi2vL0OHX8OwLFCYjBTAj0zJOp 36PTqqKpwZ2Dc5te33q/9+4kJ3E+1CJVvHJ2H9sS3uXBqzO7kVuLM3f/qct9YM0ZcIm6 pTGA== X-Forwarded-Encrypted: i=1; AJvYcCWjej2mqdeeU9HZ1A6gVDmaVBFZMxqiZ8GOWC9kLzjs4ghKhxge5G9xpyBeVFC9BkBHLpHTrlp2y1LxMpF38sdvqpTSn67I696MfCSzIQjj X-Gm-Message-State: AOJu0YzzEDD2MUOZa9R4tUV9+GwHYcCf2fsn8WxDLHG7jgKH/keF5DNS anV8TpYQzKb9FQyPDvVLKrDfHdLRHAISrHDgpwWzwHarYpNSWhgxUdK6Ohu8XWRb+KYuYqTn081 rE68Pm+PtqNB+4+p+UqU3tOeUrozVYMpQtVnCp8izADbl1FPUgm5AE9/3oWO/Xerv9g== X-Received: by 2002:a05:6214:3187:b0:691:456f:415a with SMTP id lb7-20020a056214318700b00691456f415amr14772454qvb.4.1711553022242; Wed, 27 Mar 2024 08:23:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFwFABTpt0oYC5XP41rgqaavJwjTuxekGLogedD16Vy17R/DxfwS2XqF10qrZ+lSq8ZmFvRzQ== X-Received: by 2002:a05:6214:3187:b0:691:456f:415a with SMTP id lb7-20020a056214318700b00691456f415amr14772425qvb.4.1711553021719; Wed, 27 Mar 2024 08:23:41 -0700 (PDT) Received: from x1n.redhat.com ([99.254.121.117]) by smtp.gmail.com with ESMTPSA id hu4-20020a056214234400b00690dd47a41csm6412639qvb.86.2024.03.27.08.23.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 08:23:40 -0700 (PDT) From: peterx@redhat.com To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Yang Shi , "Kirill A . Shutemov" , Mike Kravetz , John Hubbard , Michael Ellerman , peterx@redhat.com, Andrew Jones , Muchun Song , linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, Christophe Leroy , Andrew Morton , Christoph Hellwig , Lorenzo Stoakes , Matthew Wilcox , Rik van Riel , linux-arm-kernel@lists.infradead.org, Andrea Arcangeli , David Hildenbrand , "Aneesh Kumar K . V" , Vlastimil Babka , James Houghton , Jason Gunthorpe , Mike Rapoport , Axel Rasmussen Subject: [PATCH v4 03/13] mm: Make HPAGE_PXD_* macros even if !THP Date: Wed, 27 Mar 2024 11:23:22 -0400 Message-ID: <20240327152332.950956-4-peterx@redhat.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240327152332.950956-1-peterx@redhat.com> References: <20240327152332.950956-1-peterx@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240327_082345_374127_74AC2258 X-CRM114-Status: GOOD ( 11.85 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org From: Peter Xu These macros can be helpful when we plan to merge hugetlb code into generic code. Move them out and define them as long as PGTABLE_HAS_HUGE_LEAVES is selected, because there are systems that only define HUGETLB_PAGE not THP. One note here is HPAGE_PMD_SHIFT must be defined even if PMD_SHIFT is not defined (e.g. !CONFIG_MMU case); it (or in other forms, like HPAGE_PMD_NR) is already used in lots of common codes without ifdef guards. Use the old trick to let complations work. Here we only need to differenciate HPAGE_PXD_SHIFT definitions. All the rest macros will be defined based on it. When at it, move HPAGE_PMD_NR / HPAGE_PMD_ORDER over together. Signed-off-by: Peter Xu --- include/linux/huge_mm.h | 29 +++++++++++++++-------------- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h index 7576025db55d..d3bb25c39482 100644 --- a/include/linux/huge_mm.h +++ b/include/linux/huge_mm.h @@ -64,9 +64,6 @@ ssize_t single_hugepage_flag_show(struct kobject *kobj, enum transparent_hugepage_flag flag); extern struct kobj_attribute shmem_enabled_attr; -#define HPAGE_PMD_ORDER (HPAGE_PMD_SHIFT-PAGE_SHIFT) -#define HPAGE_PMD_NR (1< X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 924D1C54E67 for ; Wed, 27 Mar 2024 15:26:37 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=bkvBedbz; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=bkvBedbz; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4V4VrX1t4tz3vfq for ; Thu, 28 Mar 2024 02:26:36 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=bkvBedbz; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=bkvBedbz; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=170.10.133.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=peterx@redhat.com; receiver=lists.ozlabs.org) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4V4VnG73W1z3vY9 for ; Thu, 28 Mar 2024 02:23:46 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711553024; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/g69WjpU0rXeMHNQq0wHJ20ikWbVhFRACidICzEeTCE=; b=bkvBedbze8RVNVsEW+6xD5cM6TwuRhHYlCAAPcieiEM5mVWDPZ/MUSSoZ8et5+FudChwbr ll8o6EhgzahcYrgnrDilfqGB8eYJn6ogSYlPOLu6QF06a32wzXjE5AWzt5YD7LGKMXIRWl rFOHvUuSH01eEIpR8piDboLY6uhQGGs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711553024; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/g69WjpU0rXeMHNQq0wHJ20ikWbVhFRACidICzEeTCE=; b=bkvBedbze8RVNVsEW+6xD5cM6TwuRhHYlCAAPcieiEM5mVWDPZ/MUSSoZ8et5+FudChwbr ll8o6EhgzahcYrgnrDilfqGB8eYJn6ogSYlPOLu6QF06a32wzXjE5AWzt5YD7LGKMXIRWl rFOHvUuSH01eEIpR8piDboLY6uhQGGs= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-652-LdS0BP3CPlKnOyCRTFZY1A-1; Wed, 27 Mar 2024 11:23:42 -0400 X-MC-Unique: LdS0BP3CPlKnOyCRTFZY1A-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-696a5972507so4145666d6.0 for ; Wed, 27 Mar 2024 08:23:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711553022; x=1712157822; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/g69WjpU0rXeMHNQq0wHJ20ikWbVhFRACidICzEeTCE=; b=q4CqMsRUObdXVh0aOHFBYF7g0MP71Lt5Oofw9WVrgl4JrYm+kSuD8D8d74byL2WUSp P7pz1qQWLbtnf8TD31bix/MsW3ZjE1T/E6JXe19qG427oG6aXfT61BcsEBdw4dYWcs7R S/Xj1LWOzZnKGVbGTUfASHFUD97VcBWGCwjFiHMa0Rka92zX/ub5VTo0sho4HBX3L7E/ k8bwByWVXA3rUxJBWqNa18cZOZsL+jYw6C7nm7n3byu63MNyotdV8XOAIjw5ZfCK8DR5 Loz3idwzMX364Lk0J4/scST1IL71cIeFgUTjUTB8/VBPBEKvHzjRlkcK99gGPs0ZU6N2 Jpww== X-Forwarded-Encrypted: i=1; AJvYcCWOt8Peyhx2VJrGau4YTi5ZlIdM8U93CnDTNMERyQPo2iuZzNqDq7Lgemw+pUUqQU3SwKs7+6SdLibwaOsopptCFgPGmzoofY8gfFcqSQ== X-Gm-Message-State: AOJu0YxxMl+l6bONOr/g7EENxc2KyyCRvsw+ogUSQGznlRwlSpox/kTd 4ZIUgY77uAEElL0p5euXlxfOLWVsmPVX4zCtH5/QoRy8hnKbBZpQjo6ru1xIvm+EdGr7rdQKDAE Qo/LnM7uuZBa29/B81VI61f9Ew7EtJ7RUnAp3Dmnxf2xsLpXynu1rjfPP2a1L5xE= X-Received: by 2002:a05:6214:3187:b0:691:456f:415a with SMTP id lb7-20020a056214318700b00691456f415amr14772453qvb.4.1711553022242; Wed, 27 Mar 2024 08:23:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFwFABTpt0oYC5XP41rgqaavJwjTuxekGLogedD16Vy17R/DxfwS2XqF10qrZ+lSq8ZmFvRzQ== X-Received: by 2002:a05:6214:3187:b0:691:456f:415a with SMTP id lb7-20020a056214318700b00691456f415amr14772425qvb.4.1711553021719; Wed, 27 Mar 2024 08:23:41 -0700 (PDT) Received: from x1n.redhat.com ([99.254.121.117]) by smtp.gmail.com with ESMTPSA id hu4-20020a056214234400b00690dd47a41csm6412639qvb.86.2024.03.27.08.23.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 08:23:40 -0700 (PDT) From: peterx@redhat.com To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 03/13] mm: Make HPAGE_PXD_* macros even if !THP Date: Wed, 27 Mar 2024 11:23:22 -0400 Message-ID: <20240327152332.950956-4-peterx@redhat.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240327152332.950956-1-peterx@redhat.com> References: <20240327152332.950956-1-peterx@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: James Houghton , David Hildenbrand , Yang Shi , peterx@redhat.com, Andrew Jones , linux-riscv@lists.infradead.org, Andrea Arcangeli , Christoph Hellwig , Matthew Wilcox , "Aneesh Kumar K . V" , linux-arm-kernel@lists.infradead.org, Jason Gunthorpe , Axel Rasmussen , Rik van Riel , John Hubbard , "Kirill A . Shutemov" , Vlastimil Babka , Lorenzo Stoakes , Muchun Song , Andrew Morton , linuxppc-dev@lists.ozlabs.org, Mike Rapoport , Mike Kravetz Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: Peter Xu These macros can be helpful when we plan to merge hugetlb code into generic code. Move them out and define them as long as PGTABLE_HAS_HUGE_LEAVES is selected, because there are systems that only define HUGETLB_PAGE not THP. One note here is HPAGE_PMD_SHIFT must be defined even if PMD_SHIFT is not defined (e.g. !CONFIG_MMU case); it (or in other forms, like HPAGE_PMD_NR) is already used in lots of common codes without ifdef guards. Use the old trick to let complations work. Here we only need to differenciate HPAGE_PXD_SHIFT definitions. All the rest macros will be defined based on it. When at it, move HPAGE_PMD_NR / HPAGE_PMD_ORDER over together. Signed-off-by: Peter Xu --- include/linux/huge_mm.h | 29 +++++++++++++++-------------- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h index 7576025db55d..d3bb25c39482 100644 --- a/include/linux/huge_mm.h +++ b/include/linux/huge_mm.h @@ -64,9 +64,6 @@ ssize_t single_hugepage_flag_show(struct kobject *kobj, enum transparent_hugepage_flag flag); extern struct kobj_attribute shmem_enabled_attr; -#define HPAGE_PMD_ORDER (HPAGE_PMD_SHIFT-PAGE_SHIFT) -#define HPAGE_PMD_NR (1< X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E48FC47DD9 for ; Wed, 27 Mar 2024 15:24:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lWEa0JGrJBECUVNGaif9hj3DTt/MsZ002/mh/JptCws=; b=gCYDp7dg5IlySa b+N++TkjezItbokj9KlnJDZkEuo9L6zjPjQ7l6NgcAYIFOeAtnNUUwnkrDm++fN+QajoscIU2Rzhn 52luAf9a1JoSJFAMoAUvcKua1SzY2+XVNEzsrUMaOhscyR93XsB1uBgVfJUGOaGUxHHDOkRsnOGoi 37T9Km5/sY5ivLyTxNx3uhPr7KpO4XiGl1lA1+HVkUV7gNdsdl9QqaTg6PtH4WUolFxmtVZbhP1dn PAUH7v4+tmcd0mHmHEW1hpBtIVjJROt3TeJzbkIdWM9jnHDFBb3j2iwPm/FEzNuQ187344H80sTWO GO911oMraGQl7FoxPURQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpV81-00000009lKt-4C4O; Wed, 27 Mar 2024 15:23:50 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpV7w-00000009lEy-48Ux for linux-arm-kernel@lists.infradead.org; Wed, 27 Mar 2024 15:23:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711553024; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/g69WjpU0rXeMHNQq0wHJ20ikWbVhFRACidICzEeTCE=; b=bkvBedbze8RVNVsEW+6xD5cM6TwuRhHYlCAAPcieiEM5mVWDPZ/MUSSoZ8et5+FudChwbr ll8o6EhgzahcYrgnrDilfqGB8eYJn6ogSYlPOLu6QF06a32wzXjE5AWzt5YD7LGKMXIRWl rFOHvUuSH01eEIpR8piDboLY6uhQGGs= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-342-srlX3xH-OLuKyHUGH2Z5hg-1; Wed, 27 Mar 2024 11:23:42 -0400 X-MC-Unique: srlX3xH-OLuKyHUGH2Z5hg-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-69672754479so14006156d6.1 for ; Wed, 27 Mar 2024 08:23:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711553022; x=1712157822; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/g69WjpU0rXeMHNQq0wHJ20ikWbVhFRACidICzEeTCE=; b=kLIBXBYsx8UGyMOKqRUmk8xVl+KtibHrtCg72amoqdDXdueqGEirsJOprxCp8pA24t 0I7BDy9Mo238ZhpsVhsrNkxzsccd/cIbz8YBZz7LOj13xdcYgSZ7hYJZRl7ydZzLr8EA ZX1uxQn2Fs4vEl7QFubZaBTdNYF1rraeZ54fTJaYvJAwzhLZTxOkK3tRAw9P6hmx9Pmi CYh31lDgvfkUOTttvCiNXMXiDaOVixsPsaMSOeVpv5sCgosOUYuyZl1GeFUyjYP38Hne FwpeLDvNdCMYB2OKzK6ozZ8JJKILsA7vh3cY8Zk3eZX4QbPkHRHfTJQySfyR9PxhFJ4Y /1qg== X-Forwarded-Encrypted: i=1; AJvYcCVc1qGr/IHOBqnSFRXanU8bZOmQDVtWFU8rMGNpiU6fyMs9n6QwPkTXxNbUeVTiRJlcSLMlsB3iSesvfBTXF1aYmWYWxkC6aEzklNriAOURpbK/Ny0= X-Gm-Message-State: AOJu0Ywi3cQDT0KySszsxETXOdIlOGDU61owbRDBjmmN9+yi0w/fKSVF 4PneN2R4to6kxaC5sr+/XMtsUHLsGS9k7Ss9HK5anmJeyH0cs95Zq1E9iN7W2ufxTtEKfXZ9wjX XOksQq9Fgf1FubywaCc0oyg1FqrATVLfLoh+5QlF6r8jRVTHIbpRmxVkaWZxUa+KcvmTDlnUm X-Received: by 2002:a05:6214:3187:b0:691:456f:415a with SMTP id lb7-20020a056214318700b00691456f415amr14772476qvb.4.1711553022260; Wed, 27 Mar 2024 08:23:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFwFABTpt0oYC5XP41rgqaavJwjTuxekGLogedD16Vy17R/DxfwS2XqF10qrZ+lSq8ZmFvRzQ== X-Received: by 2002:a05:6214:3187:b0:691:456f:415a with SMTP id lb7-20020a056214318700b00691456f415amr14772425qvb.4.1711553021719; Wed, 27 Mar 2024 08:23:41 -0700 (PDT) Received: from x1n.redhat.com ([99.254.121.117]) by smtp.gmail.com with ESMTPSA id hu4-20020a056214234400b00690dd47a41csm6412639qvb.86.2024.03.27.08.23.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 08:23:40 -0700 (PDT) From: peterx@redhat.com To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Yang Shi , "Kirill A . Shutemov" , Mike Kravetz , John Hubbard , Michael Ellerman , peterx@redhat.com, Andrew Jones , Muchun Song , linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, Christophe Leroy , Andrew Morton , Christoph Hellwig , Lorenzo Stoakes , Matthew Wilcox , Rik van Riel , linux-arm-kernel@lists.infradead.org, Andrea Arcangeli , David Hildenbrand , "Aneesh Kumar K . V" , Vlastimil Babka , James Houghton , Jason Gunthorpe , Mike Rapoport , Axel Rasmussen Subject: [PATCH v4 03/13] mm: Make HPAGE_PXD_* macros even if !THP Date: Wed, 27 Mar 2024 11:23:22 -0400 Message-ID: <20240327152332.950956-4-peterx@redhat.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240327152332.950956-1-peterx@redhat.com> References: <20240327152332.950956-1-peterx@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240327_082345_255461_8319C2C4 X-CRM114-Status: GOOD ( 13.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Peter Xu These macros can be helpful when we plan to merge hugetlb code into generic code. Move them out and define them as long as PGTABLE_HAS_HUGE_LEAVES is selected, because there are systems that only define HUGETLB_PAGE not THP. One note here is HPAGE_PMD_SHIFT must be defined even if PMD_SHIFT is not defined (e.g. !CONFIG_MMU case); it (or in other forms, like HPAGE_PMD_NR) is already used in lots of common codes without ifdef guards. Use the old trick to let complations work. Here we only need to differenciate HPAGE_PXD_SHIFT definitions. All the rest macros will be defined based on it. When at it, move HPAGE_PMD_NR / HPAGE_PMD_ORDER over together. Signed-off-by: Peter Xu --- include/linux/huge_mm.h | 29 +++++++++++++++-------------- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h index 7576025db55d..d3bb25c39482 100644 --- a/include/linux/huge_mm.h +++ b/include/linux/huge_mm.h @@ -64,9 +64,6 @@ ssize_t single_hugepage_flag_show(struct kobject *kobj, enum transparent_hugepage_flag flag); extern struct kobj_attribute shmem_enabled_attr; -#define HPAGE_PMD_ORDER (HPAGE_PMD_SHIFT-PAGE_SHIFT) -#define HPAGE_PMD_NR (1< X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01195C54E67 for ; Wed, 27 Mar 2024 15:23:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 49BF56B0093; Wed, 27 Mar 2024 11:23:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 44BA36B0098; Wed, 27 Mar 2024 11:23:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 202256B0096; Wed, 27 Mar 2024 11:23:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 034A06B0092 for ; Wed, 27 Mar 2024 11:23:47 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C9AFC16072A for ; Wed, 27 Mar 2024 15:23:47 +0000 (UTC) X-FDA: 81943188894.06.1F89E5F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 9A1884002D for ; Wed, 27 Mar 2024 15:23:45 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bkvBedbz; spf=pass (imf12.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711553025; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/g69WjpU0rXeMHNQq0wHJ20ikWbVhFRACidICzEeTCE=; b=rfWmkqWKxeABA8KgS9UD5ugHuVX6tvxkwlx83TiZ0K9FNn0odSLmHsx065QdVsU8dgUTli U4RIa0qw7PAZ7Mn4n8LYxaDdAN7hnprGmSuY0SFcjNrB9Bu81gv6fdgCnwKz1r+RJ1Ogrl LGqVltmsBSe1Ni+Lx7ZOrxo1htfEBM0= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bkvBedbz; spf=pass (imf12.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711553025; a=rsa-sha256; cv=none; b=Q3xyewurb6JH85FMlyRgjccgb/027JHaKhIesdbH4b4b6rFSqp5J8xSXLFp9WOimm3c2Ls 7cf6eYQBAiIxJlhWnxeRNjYTTG5HWjdPJzfq8nHhXy/TeKdaSiZx9H8uAx3Chq1nA+dAp/ 7iO3XnibFuG06ImTQa50QhuaIbWTFVk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711553024; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/g69WjpU0rXeMHNQq0wHJ20ikWbVhFRACidICzEeTCE=; b=bkvBedbze8RVNVsEW+6xD5cM6TwuRhHYlCAAPcieiEM5mVWDPZ/MUSSoZ8et5+FudChwbr ll8o6EhgzahcYrgnrDilfqGB8eYJn6ogSYlPOLu6QF06a32wzXjE5AWzt5YD7LGKMXIRWl rFOHvUuSH01eEIpR8piDboLY6uhQGGs= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-381-SGdhaBABMwCtlOLzqu5r0A-1; Wed, 27 Mar 2024 11:23:43 -0400 X-MC-Unique: SGdhaBABMwCtlOLzqu5r0A-1 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-69672754479so14006336d6.1 for ; Wed, 27 Mar 2024 08:23:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711553022; x=1712157822; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/g69WjpU0rXeMHNQq0wHJ20ikWbVhFRACidICzEeTCE=; b=RgJqATNSVBqwLXej0+bUvKa90YmvWkI4vO45aB4iAM8ke9yuraAhNtJ/yBxhlHY2fZ 2vtlP1EPXUyw/E3sCKXKdOlxYi1EhVSnbTtGtj7iBAdtwXbZ0mHaprPFRqUNoKU/K3Py NLK+qHZMF4JQHFj1liPjLfWQxellqv0Ly7yIlBDpqZz9X+cgHZoIGRmoyU3TrAMlaMIo 7wIZ4I5cEF2ls42nItxw1yZjnqorDCTTKVYRPCAW5RkB4o6VpmIK88H3iVEhxAUlvTz4 mYejHbuFsktG9Thsepqx4AxJrvxqK/bNByCmKH9tAXLZ8I7fckgrUfXW3SIEVbgJ8M53 8sEg== X-Gm-Message-State: AOJu0Yw1AoUXZaqods7tzTL4bXji9lO1IzOFzQnKoAv78zCNWSzIIkAD 8VuJxkesXQNbLGWv/HwJB2E8UeciXDazBD8P0giFruDG4h25UQzFKu+ndadPKY4WcL5QbCRkyo5 OVayR8Z7c+rw7vN5IYWHMt801V/P+24BOPmhUospgNymlEU1TXT1unnSvcJ21eMBOkYcAwMVJgC TnTTfqC2oITY2jyVneXW5odpDet6oOhg== X-Received: by 2002:a05:6214:3187:b0:691:456f:415a with SMTP id lb7-20020a056214318700b00691456f415amr14772484qvb.4.1711553022332; Wed, 27 Mar 2024 08:23:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFwFABTpt0oYC5XP41rgqaavJwjTuxekGLogedD16Vy17R/DxfwS2XqF10qrZ+lSq8ZmFvRzQ== X-Received: by 2002:a05:6214:3187:b0:691:456f:415a with SMTP id lb7-20020a056214318700b00691456f415amr14772425qvb.4.1711553021719; Wed, 27 Mar 2024 08:23:41 -0700 (PDT) Received: from x1n.redhat.com ([99.254.121.117]) by smtp.gmail.com with ESMTPSA id hu4-20020a056214234400b00690dd47a41csm6412639qvb.86.2024.03.27.08.23.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 08:23:40 -0700 (PDT) From: peterx@redhat.com To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Yang Shi , "Kirill A . Shutemov" , Mike Kravetz , John Hubbard , Michael Ellerman , peterx@redhat.com, Andrew Jones , Muchun Song , linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, Christophe Leroy , Andrew Morton , Christoph Hellwig , Lorenzo Stoakes , Matthew Wilcox , Rik van Riel , linux-arm-kernel@lists.infradead.org, Andrea Arcangeli , David Hildenbrand , "Aneesh Kumar K . V" , Vlastimil Babka , James Houghton , Jason Gunthorpe , Mike Rapoport , Axel Rasmussen Subject: [PATCH v4 03/13] mm: Make HPAGE_PXD_* macros even if !THP Date: Wed, 27 Mar 2024 11:23:22 -0400 Message-ID: <20240327152332.950956-4-peterx@redhat.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240327152332.950956-1-peterx@redhat.com> References: <20240327152332.950956-1-peterx@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Rspamd-Queue-Id: 9A1884002D X-Rspam-User: X-Stat-Signature: ubgfzgpee6du359hezjtxxny5edjuk5d X-Rspamd-Server: rspam01 X-HE-Tag: 1711553025-904328 X-HE-Meta: U2FsdGVkX1+9dOn8v//FQ+Ma/kI5i32J+jYpVBLnjV/KgOl9nNi0y5TX6Rf2nxzP4rxbTsyTV7YV5JJkAPjwbKb72btN3HFB4JXuw7tZAGSRDB5sROE+RCSicS8Y9NwE3Bctqs3kTvBMNooo8jf8ALzMMDa8u12NXZfSM4ByBsnLfJowhSN6uqLbC8DBgKvHD2hOJdxGBsJEJ156mWQq6en139CGSZhmTFlnvNjH+bBNS7TupXExjixpF/xSg++FyRrY4PLMgmesqOLSVp3wwzu0TISENh/jSkiZ6tOOM6Cb26XqzkYh93/Ep2tDw44GX7lPxuucRBN5E2P9DxjhTuCt3Rmo7ZRZHLImfHe1NENc8160bN8VhRWIebIFdVkY3x65r09F0ZDzoboi8eK8P2mLAlHvSs2eaP8mwjh5U/9Ft7Har/PXyIDfI6QWTc+yhqIJXxdrkvGoia7aOfj5UIIyheksCxqiUO7bazTvcMiU80O5w8F59QW08t2qYpH2MIX3K9I92bc3fGtD/5Z5XWqxAA3XDMT/s0Fwmv00555knpsS4ReM0JXWGr5HrCf9rPXv1RVn416FYDcE1lU4g51ZnrZrwa2wWiAd9yv7dZKvBPlIz3QnP3FHEiImrE+WE6lIdj32tBviDy4EEWKrsxiRaqmM4iDX5RVisTn8Lor1+qXGBNECmw/X+UCjgl5qkVbzYt/Z0Jvk71m40dRwRvaQ3TOHdUMk89p1hvb8a0zsSUvZmUdWBhi2CFVD3mBilAAC2AK+QmHAjJzlPiNrw6co0EE/b6mPdmYsovpDh4npjF/W02OI1+7+qkN5UXKiE5cBuQr0Xf/5toN07WBDVW3tZ+cR+pVYRvRrE27eCnNp6b5NIlb+CHa/P4eur9JTRgbRaFusUXMLBKsRmMTCESfK5E4J8I+iygV6+7qxT2C5Wkh11apLpA+7E0N6us80pebnBMcsV2YCtKzmeez aP/LgJ+T OnL2elAyYe4R/SS0981b3oZUsCnUUZt9nWs0Z2o2am5qP1v4DroxVvSSlzLiPeASUB8FjC5Tyth9+jnymY4ZKsoZFNVW0JFAngo7hNh/rMWEZuEF0J+J+6/7nbJ8rSvY+4xtDbI5vYq0O4jUfzWhJYaVhdUIPvMUZznrOhsJrP/xxZwyb6CbPKBlopD5vmd7LwwZv0bk48vHHeonYzAF22fdbXdl5beEqZyQ0TxB06BYRaPL0d79zkdnx5dYkhYGa7DhQYRZa4kmwieViCicB0jwLIWhhSELeTmEXBeyjK94kcnYFciVOFA71gqBWEs5sZQaLmEL/1R8xuD9Vicz8zd9mnWXVtmrUypdAmkX0m/7FglX5xuLiAQgWnNHI4lUKQeSMAF6O/CWsQe2Rxm29cokEaN6bA6Uz7NVGhPqphtuxuZmkmVJx58XHMIySLoKilNNdTi1tRLJ2EMmhExxkbT5fzr3y93QFGLya X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Peter Xu These macros can be helpful when we plan to merge hugetlb code into generic code. Move them out and define them as long as PGTABLE_HAS_HUGE_LEAVES is selected, because there are systems that only define HUGETLB_PAGE not THP. One note here is HPAGE_PMD_SHIFT must be defined even if PMD_SHIFT is not defined (e.g. !CONFIG_MMU case); it (or in other forms, like HPAGE_PMD_NR) is already used in lots of common codes without ifdef guards. Use the old trick to let complations work. Here we only need to differenciate HPAGE_PXD_SHIFT definitions. All the rest macros will be defined based on it. When at it, move HPAGE_PMD_NR / HPAGE_PMD_ORDER over together. Signed-off-by: Peter Xu --- include/linux/huge_mm.h | 29 +++++++++++++++-------------- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h index 7576025db55d..d3bb25c39482 100644 --- a/include/linux/huge_mm.h +++ b/include/linux/huge_mm.h @@ -64,9 +64,6 @@ ssize_t single_hugepage_flag_show(struct kobject *kobj, enum transparent_hugepage_flag flag); extern struct kobj_attribute shmem_enabled_attr; -#define HPAGE_PMD_ORDER (HPAGE_PMD_SHIFT-PAGE_SHIFT) -#define HPAGE_PMD_NR (1<