From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 806E412F5A2; Wed, 27 Mar 2024 16:51:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.193 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711558299; cv=none; b=cUhoFSGz99CY8g0Aw8Oqn6C9H7CEdRIKeUZEL7CqQN/SLfx+DOt0Xj8uJskZvVjz090MpeOgaip0yWiKFNc9wzCF6109UN3IFrHxi9Mxtrb9o+lggt+jFxSGnOkwbTPk5kng7IDmu055qja8/LU//aSmwSjtaibwfoWt8I7JpXs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711558299; c=relaxed/simple; bh=LM8sbbiZKaeBPMakgJ3MutVIXuYeOb/HCEs0DQyWv2s=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=nZ2nGNmNo43CkXIDmLuAheSjYZsFmkdsiTQFgP060ixXj5gIOves2qUeGUltiKzQrvaUoYY79o9fJvZaISdIbRRiwH9NCnnRBNFtBwBRqMusFp/wrsHuJlxzxGFSAlzXSz1wh4MQcgeKu5qKaaDJhQhrLDQYNPCG7jvisM6iUlk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=OlCqOZhR; arc=none smtp.client-ip=217.70.183.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="OlCqOZhR" Received: by mail.gandi.net (Postfix) with ESMTPSA id 1B652240008; Wed, 27 Mar 2024 16:51:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1711558294; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8dkDsTM+CyF3T1RfUsZvTaGtiJGxz0u7kuWWxBLiq70=; b=OlCqOZhRUE+LEglVKAzyRaIJnfHwR7NpVwTLoTmHNcTFLc1l2Ze/9ictqKZcclr3fbO0nE JFO/Ll9eSZm0QJZUc7JFGocaYue1wLCziUiLa/3wRMVohIQ2NLg7RI87xwUd3YtaU+owPM Vll6eIkZQFjuJGT1soHhKBI2DemQ2JnZx3vT1lIb+F2cQ2AuT2ZTc9LDO+/YBI6d+FnvGW kDbQt4FW3pInjRk5kBdRExWdgGsNnLTQbx3ypV2enI06lf+G8BbHC05YFWikJ+bJHQBIA+ 7arwt6GAfJQ/f6JD3pTIs/h0gSnDzYG4vuEA8A/B3CVYNpBvSNN/iujE0U5JhA== Date: Wed, 27 Mar 2024 17:51:31 +0100 From: Miquel Raynal To: Christian Marangi Cc: Manivannan Sadhasivam , Richard Weinberger , Vignesh Raghavendra , Md Sadre Alam , Sricharan Ramabadhran , linux-mtd@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2 1/2] mtd: rawnand: qcom: Fix broken erase in misc_cmd_type in exec_op Message-ID: <20240327175131.3c0100c3@xps-13> In-Reply-To: <66044bea.050a0220.dee16.c250@mx.google.com> References: <20240325103053.24408-1-ansuelsmth@gmail.com> <20240326072512.GA8436@thinkpad> <66044bea.050a0220.dee16.c250@mx.google.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com Hi, ansuelsmth@gmail.com wrote on Wed, 27 Mar 2024 16:20:58 +0100: > On Tue, Mar 26, 2024 at 12:55:12PM +0530, Manivannan Sadhasivam wrote: > > On Mon, Mar 25, 2024 at 11:30:47AM +0100, Christian Marangi wrote: =20 > > > misc_cmd_type in exec_op have multiple problems. With commit a82990c8= a409 > > > ("mtd: rawnand: qcom: Add read/read_start ops in exec_op path") it was > > > reworked and generalized but actually broke the handling of the > > > ERASE_BLOCK command. > > >=20 > > > Additional logic was added to the erase command cycle without clear > > > explaination causing the erase command to be broken on testing it on > > > a ipq806x nandc. > > >=20 > > > Fix the erase command by reverting the additional logic and only addi= ng > > > the NAND_DEV0_CFG0 additional call (required for erase command). > > >=20 > > > Fixes: a82990c8a409 ("mtd: rawnand: qcom: Add read/read_start ops in = exec_op path") > > > Cc: stable@vger.kernel.org > > > Signed-off-by: Christian Marangi > > > --- > > > Changes v2: > > > - Split this and rework commit description and title > > >=20 > > > drivers/mtd/nand/raw/qcom_nandc.c | 5 ++--- > > > 1 file changed, 2 insertions(+), 3 deletions(-) > > >=20 > > > diff --git a/drivers/mtd/nand/raw/qcom_nandc.c b/drivers/mtd/nand/raw= /qcom_nandc.c > > > index b079605c84d3..19d76e345a49 100644 > > > --- a/drivers/mtd/nand/raw/qcom_nandc.c > > > +++ b/drivers/mtd/nand/raw/qcom_nandc.c > > > @@ -2830,9 +2830,8 @@ static int qcom_misc_cmd_type_exec(struct nand_= chip *chip, const struct nand_sub > > > nandc_set_reg(chip, NAND_EXEC_CMD, 1); > > > =20 > > > write_reg_dma(nandc, NAND_FLASH_CMD, instrs, NAND_BAM_NEXT_SGL); > > > - (q_op.cmd_reg =3D=3D OP_BLOCK_ERASE) ? write_reg_dma(nandc, NAND_DE= V0_CFG0, > > > - 2, NAND_BAM_NEXT_SGL) : read_reg_dma(nandc, > > > - NAND_FLASH_STATUS, 1, NAND_BAM_NEXT_SGL); > > > + if (q_op.cmd_reg =3D=3D OP_BLOCK_ERASE) > > > + write_reg_dma(nandc, NAND_DEV0_CFG0, 2, NAND_BAM_NEXT_SGL); =20 > >=20 > > So this only avoids the call to, 'read_reg_dma(nandc, NAND_FLASH_STATUS= , 1, > > NAND_BAM_NEXT_SGL)' if q_op.cmd_reg !=3D OP_BLOCK_ERASE. But for q_op.c= md_reg =3D=3D > > OP_BLOCK_ERASE, the result is the same. > >=20 > > I'm wondering how it results in fixing the OP_BLOCK_ERASE command. > >=20 > > Can you share the actual issue that you are seeing? Like error logs etc= ... > > =20 >=20 > Issue is that nandc goes to ADM timeout as soon as a BLOCK_ERASE is > called. BLOCK_ERASE operation match also another operation from MTD > read. (parser also maps to other stuff) >=20 > I will be away from the testing board for 7-10 days so I can't provide > logs currently. So, shall we wait for additional logs from Christian or shall I merge the two-patches series? I'm not sure what's the status anymore. Thanks, Miqu=C3=A8l From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A9BA8C54E67 for ; Wed, 27 Mar 2024 16:51:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=W9UWiVLMkkOeSXqqHV7BRhvYZPyX/izTNdV0D9VlL3w=; b=SnxJ3Yhykanx+u HpKZgm18nf1P2eKu18+IJrrwQM7zDzgwsXggeeSS7UF3KQ14E+8isqtQjjWQlK1SS8dmYbWtWbYY9 fjxbEjH+omTxOhu6kfVOL+KnUfCiGEg3e8ZSzzis0Z57byZ40mkD6LU6RLmum0aNzdXzGaJ3dCX8X e/f53AzmduJCoIEKUTpTTdAmTSRa4iyGleyMX/TELsu5aeOzV/4PkFna7pe5BNi6USLUybj9DTxTd MnvDeqcDH2MdKSsHv3JzffyVujO6fWwPb26liOYHHbqT+MMplr/E97ejw6C0iQ49pL3ojUuUgzwGO 7ahmkrjVdUrKhcp9bpJQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpWV4-0000000A9PC-2tWf; Wed, 27 Mar 2024 16:51:42 +0000 Received: from relay1-d.mail.gandi.net ([217.70.183.193]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpWV1-0000000A9Ni-0C25 for linux-mtd@lists.infradead.org; Wed, 27 Mar 2024 16:51:40 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 1B652240008; Wed, 27 Mar 2024 16:51:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1711558294; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8dkDsTM+CyF3T1RfUsZvTaGtiJGxz0u7kuWWxBLiq70=; b=OlCqOZhRUE+LEglVKAzyRaIJnfHwR7NpVwTLoTmHNcTFLc1l2Ze/9ictqKZcclr3fbO0nE JFO/Ll9eSZm0QJZUc7JFGocaYue1wLCziUiLa/3wRMVohIQ2NLg7RI87xwUd3YtaU+owPM Vll6eIkZQFjuJGT1soHhKBI2DemQ2JnZx3vT1lIb+F2cQ2AuT2ZTc9LDO+/YBI6d+FnvGW kDbQt4FW3pInjRk5kBdRExWdgGsNnLTQbx3ypV2enI06lf+G8BbHC05YFWikJ+bJHQBIA+ 7arwt6GAfJQ/f6JD3pTIs/h0gSnDzYG4vuEA8A/B3CVYNpBvSNN/iujE0U5JhA== Date: Wed, 27 Mar 2024 17:51:31 +0100 From: Miquel Raynal To: Christian Marangi Cc: Manivannan Sadhasivam , Richard Weinberger , Vignesh Raghavendra , Md Sadre Alam , Sricharan Ramabadhran , linux-mtd@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2 1/2] mtd: rawnand: qcom: Fix broken erase in misc_cmd_type in exec_op Message-ID: <20240327175131.3c0100c3@xps-13> In-Reply-To: <66044bea.050a0220.dee16.c250@mx.google.com> References: <20240325103053.24408-1-ansuelsmth@gmail.com> <20240326072512.GA8436@thinkpad> <66044bea.050a0220.dee16.c250@mx.google.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: miquel.raynal@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240327_095139_452964_B2E82688 X-CRM114-Status: GOOD ( 28.34 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGksCgphbnN1ZWxzbXRoQGdtYWlsLmNvbSB3cm90ZSBvbiBXZWQsIDI3IE1hciAyMDI0IDE2OjIw OjU4ICswMTAwOgoKPiBPbiBUdWUsIE1hciAyNiwgMjAyNCBhdCAxMjo1NToxMlBNICswNTMwLCBN YW5pdmFubmFuIFNhZGhhc2l2YW0gd3JvdGU6Cj4gPiBPbiBNb24sIE1hciAyNSwgMjAyNCBhdCAx MTozMDo0N0FNICswMTAwLCBDaHJpc3RpYW4gTWFyYW5naSB3cm90ZTogIAo+ID4gPiBtaXNjX2Nt ZF90eXBlIGluIGV4ZWNfb3AgaGF2ZSBtdWx0aXBsZSBwcm9ibGVtcy4gV2l0aCBjb21taXQgYTgy OTkwYzhhNDA5Cj4gPiA+ICgibXRkOiByYXduYW5kOiBxY29tOiBBZGQgcmVhZC9yZWFkX3N0YXJ0 IG9wcyBpbiBleGVjX29wIHBhdGgiKSBpdCB3YXMKPiA+ID4gcmV3b3JrZWQgYW5kIGdlbmVyYWxp emVkIGJ1dCBhY3R1YWxseSBicm9rZSB0aGUgaGFuZGxpbmcgb2YgdGhlCj4gPiA+IEVSQVNFX0JM T0NLIGNvbW1hbmQuCj4gPiA+IAo+ID4gPiBBZGRpdGlvbmFsIGxvZ2ljIHdhcyBhZGRlZCB0byB0 aGUgZXJhc2UgY29tbWFuZCBjeWNsZSB3aXRob3V0IGNsZWFyCj4gPiA+IGV4cGxhaW5hdGlvbiBj YXVzaW5nIHRoZSBlcmFzZSBjb21tYW5kIHRvIGJlIGJyb2tlbiBvbiB0ZXN0aW5nIGl0IG9uCj4g PiA+IGEgaXBxODA2eCBuYW5kYy4KPiA+ID4gCj4gPiA+IEZpeCB0aGUgZXJhc2UgY29tbWFuZCBi eSByZXZlcnRpbmcgdGhlIGFkZGl0aW9uYWwgbG9naWMgYW5kIG9ubHkgYWRkaW5nCj4gPiA+IHRo ZSBOQU5EX0RFVjBfQ0ZHMCBhZGRpdGlvbmFsIGNhbGwgKHJlcXVpcmVkIGZvciBlcmFzZSBjb21t YW5kKS4KPiA+ID4gCj4gPiA+IEZpeGVzOiBhODI5OTBjOGE0MDkgKCJtdGQ6IHJhd25hbmQ6IHFj b206IEFkZCByZWFkL3JlYWRfc3RhcnQgb3BzIGluIGV4ZWNfb3AgcGF0aCIpCj4gPiA+IENjOiBz dGFibGVAdmdlci5rZXJuZWwub3JnCj4gPiA+IFNpZ25lZC1vZmYtYnk6IENocmlzdGlhbiBNYXJh bmdpIDxhbnN1ZWxzbXRoQGdtYWlsLmNvbT4KPiA+ID4gLS0tCj4gPiA+IENoYW5nZXMgdjI6Cj4g PiA+IC0gU3BsaXQgdGhpcyBhbmQgcmV3b3JrIGNvbW1pdCBkZXNjcmlwdGlvbiBhbmQgdGl0bGUK PiA+ID4gCj4gPiA+ICBkcml2ZXJzL210ZC9uYW5kL3Jhdy9xY29tX25hbmRjLmMgfCA1ICsrLS0t Cj4gPiA+ICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQo+ ID4gPiAKPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbXRkL25hbmQvcmF3L3Fjb21fbmFuZGMu YyBiL2RyaXZlcnMvbXRkL25hbmQvcmF3L3Fjb21fbmFuZGMuYwo+ID4gPiBpbmRleCBiMDc5NjA1 Yzg0ZDMuLjE5ZDc2ZTM0NWE0OSAxMDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy9tdGQvbmFuZC9y YXcvcWNvbV9uYW5kYy5jCj4gPiA+ICsrKyBiL2RyaXZlcnMvbXRkL25hbmQvcmF3L3Fjb21fbmFu ZGMuYwo+ID4gPiBAQCAtMjgzMCw5ICsyODMwLDggQEAgc3RhdGljIGludCBxY29tX21pc2NfY21k X3R5cGVfZXhlYyhzdHJ1Y3QgbmFuZF9jaGlwICpjaGlwLCBjb25zdCBzdHJ1Y3QgbmFuZF9zdWIK PiA+ID4gIAluYW5kY19zZXRfcmVnKGNoaXAsIE5BTkRfRVhFQ19DTUQsIDEpOwo+ID4gPiAgCj4g PiA+ICAJd3JpdGVfcmVnX2RtYShuYW5kYywgTkFORF9GTEFTSF9DTUQsIGluc3RycywgTkFORF9C QU1fTkVYVF9TR0wpOwo+ID4gPiAtCShxX29wLmNtZF9yZWcgPT0gT1BfQkxPQ0tfRVJBU0UpID8g d3JpdGVfcmVnX2RtYShuYW5kYywgTkFORF9ERVYwX0NGRzAsCj4gPiA+IC0JMiwgTkFORF9CQU1f TkVYVF9TR0wpIDogcmVhZF9yZWdfZG1hKG5hbmRjLAo+ID4gPiAtCU5BTkRfRkxBU0hfU1RBVFVT LCAxLCBOQU5EX0JBTV9ORVhUX1NHTCk7Cj4gPiA+ICsJaWYgKHFfb3AuY21kX3JlZyA9PSBPUF9C TE9DS19FUkFTRSkKPiA+ID4gKwkJd3JpdGVfcmVnX2RtYShuYW5kYywgTkFORF9ERVYwX0NGRzAs IDIsIE5BTkRfQkFNX05FWFRfU0dMKTsgIAo+ID4gCj4gPiBTbyB0aGlzIG9ubHkgYXZvaWRzIHRo ZSBjYWxsIHRvLCAncmVhZF9yZWdfZG1hKG5hbmRjLCBOQU5EX0ZMQVNIX1NUQVRVUywgMSwKPiA+ IE5BTkRfQkFNX05FWFRfU0dMKScgaWYgcV9vcC5jbWRfcmVnICE9IE9QX0JMT0NLX0VSQVNFLiBC dXQgZm9yIHFfb3AuY21kX3JlZyA9PQo+ID4gT1BfQkxPQ0tfRVJBU0UsIHRoZSByZXN1bHQgaXMg dGhlIHNhbWUuCj4gPiAKPiA+IEknbSB3b25kZXJpbmcgaG93IGl0IHJlc3VsdHMgaW4gZml4aW5n IHRoZSBPUF9CTE9DS19FUkFTRSBjb21tYW5kLgo+ID4gCj4gPiBDYW4geW91IHNoYXJlIHRoZSBh Y3R1YWwgaXNzdWUgdGhhdCB5b3UgYXJlIHNlZWluZz8gTGlrZSBlcnJvciBsb2dzIGV0Yy4uLgo+ ID4gIAo+IAo+IElzc3VlIGlzIHRoYXQgbmFuZGMgZ29lcyB0byBBRE0gdGltZW91dCBhcyBzb29u IGFzIGEgQkxPQ0tfRVJBU0UgaXMKPiBjYWxsZWQuIEJMT0NLX0VSQVNFIG9wZXJhdGlvbiBtYXRj aCBhbHNvIGFub3RoZXIgb3BlcmF0aW9uIGZyb20gTVRECj4gcmVhZC4gKHBhcnNlciBhbHNvIG1h cHMgdG8gb3RoZXIgc3R1ZmYpCj4gCj4gSSB3aWxsIGJlIGF3YXkgZnJvbSB0aGUgdGVzdGluZyBi b2FyZCBmb3IgNy0xMCBkYXlzIHNvIEkgY2FuJ3QgcHJvdmlkZQo+IGxvZ3MgY3VycmVudGx5LgoK U28sIHNoYWxsIHdlIHdhaXQgZm9yIGFkZGl0aW9uYWwgbG9ncyBmcm9tIENocmlzdGlhbiBvciBz aGFsbCBJIG1lcmdlCnRoZSB0d28tcGF0Y2hlcyBzZXJpZXM/IEknbSBub3Qgc3VyZSB3aGF0J3Mg dGhlIHN0YXR1cyBhbnltb3JlLgoKVGhhbmtzLApNaXF1w6hsCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXggTVREIGRpc2N1c3Npb24g bWFpbGluZyBsaXN0Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtbXRkLwo=