From: Christian Brauner <brauner@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Dave Chinner <david@fromorbit.com>,
linux-fsdevel@vger.kernel.org, Jan Kara <jack@suse.cz>,
Jens Axboe <axboe@kernel.dk>,
Alexander Viro <viro@zeniv.linux.org.uk>,
io-uring@vger.kernel.org
Subject: Re: [PATCH] [RFC]: fs: claw back a few FMODE_* bits
Date: Thu, 28 Mar 2024 10:41:08 +0100 [thread overview]
Message-ID: <20240328-maserung-markant-287d66ba25cd@brauner> (raw)
In-Reply-To: <20240328081323.GB19225@lst.de>
On Thu, Mar 28, 2024 at 09:13:23AM +0100, Christoph Hellwig wrote:
> On Thu, Mar 28, 2024 at 09:06:43AM +0100, Christian Brauner wrote:
> > > Why do we need to set any of these for directory operations now that
> > > we have a clear choice? i.e. we can't mmap directories, and the rest
> > > of these flags are for read() and write() operations which we also
> > > can't do on directories...
> >
> > Yeah, I know but since your current implementation raises them for both
> > I just did it 1:1:
>
> Yes, sticking to the 1:1 for this patch is probably a good idea.
> But we should also fix this in a trivial follow on patch. I can
> write it and add it to your series.
Ok.
next prev parent reply other threads:[~2024-03-28 9:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 16:45 [PATCH] [RFC]: fs: claw back a few FMODE_* bits Christian Brauner
2024-03-27 17:19 ` Jens Axboe
2024-03-28 9:40 ` Christian Brauner
2024-03-28 1:18 ` Dave Chinner
2024-03-28 5:36 ` Christoph Hellwig
2024-03-28 8:06 ` Christian Brauner
2024-03-28 8:13 ` Christoph Hellwig
2024-03-28 9:41 ` Christian Brauner [this message]
2024-04-01 23:16 ` Dave Chinner
2024-03-28 5:35 ` Christoph Hellwig
2024-03-28 9:29 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240328-maserung-markant-287d66ba25cd@brauner \
--to=brauner@kernel.org \
--cc=axboe@kernel.dk \
--cc=david@fromorbit.com \
--cc=hch@lst.de \
--cc=io-uring@vger.kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.