From: Jakub Kicinski <kuba@kernel.org>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Donald Hunter <donald.hunter@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
Jacob Keller <jacob.e.keller@intel.com>,
Stanislav Fomichev <sdf@google.com>
Subject: Re: [PATCH net-next 1/2] ynl: rename array-nest to indexed-array
Date: Thu, 28 Mar 2024 09:02:20 -0700 [thread overview]
Message-ID: <20240328090220.458c98c2@kernel.org> (raw)
In-Reply-To: <ZgUhS8_Yno2dAyie@Laptop-X1>
On Thu, 28 Mar 2024 15:50:35 +0800 Hangbin Liu wrote:
> I agree we need raise exception when only support nest sub-type. But
> what about after adding other sub-types in patch 2/2. e.g.
>
> if attr_spec["sub-type"] == 'nest':
> decoded = self._decode_array_nest(attr, attr_spec)
> else:
> decoded = self._decode_index_array(attr, attr_spec)
>
> Should we remove the exception in patch 2?
Looking a bit closer you should probably have:
- elif attr_spec["type"] == 'array-nest':
- decoded = self._decode_array_nest(attr, attr_spec)
+ elif attr_spec["type"] == 'indexed-array':
+ decoded = self._decode_array_attr(attr, attr_spec)
elif attr_spec["type"] == 'bitfield32':
and do the sub-type handling inside (now renamed) _decode_array_attr()
Throw the exception there appropriately.
next prev parent reply other threads:[~2024-03-28 16:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 6:37 [PATCH net-next 0/2] ynl: rename array-nest to indexed-array Hangbin Liu
2024-03-26 6:37 ` [PATCH net-next 1/2] " Hangbin Liu
2024-03-27 3:46 ` Jakub Kicinski
2024-03-28 7:50 ` Hangbin Liu
2024-03-28 16:02 ` Jakub Kicinski [this message]
2024-03-26 6:37 ` [PATCH net-next 2/2] ynl: support un-nest sub-type for indexed-array Hangbin Liu
2024-03-28 7:41 ` Hangbin Liu
2024-03-28 16:04 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240328090220.458c98c2@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=jacob.e.keller@intel.com \
--cc=jiri@resnulli.us \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.