From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 40F3ACD11DD for ; Thu, 28 Mar 2024 17:25:14 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 113C1820FE; Thu, 28 Mar 2024 17:25:14 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id W0d_kO-7uEgA; Thu, 28 Mar 2024 17:25:13 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 7DF8882116 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1711646713; bh=b1MdRNy7bJKu1/MfJfDx8gNFI5ej1bZyAb5EjT3paNc=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=fqClcEob44mkL3rjgfGhguQs3WbzAr7Tm5qv3GRRXq2JLc1NCoZGMZkGGXhVeeK1X JmVcqDt63HoE+pUChrBpDSMB4SjVY/bOvdxuzbnIMQ46D6yDn0D79f5mASbT3uGCYv UGaRC6BGv40JkLIQfjiWf5sLAsAfcDl/3xkmgxOnbKblJpb0TZn1mYROEddxpOfNCD QMvD8igfOclGYTS3DUICgwqBBnlAX6GxVG+bOtzL4x7iqbLPxCY2krPJbcYGbLKLvy jj6asur4D8gTkomWrwIkyqCZbKN07s9jj00bI3lGW4Okqi0+StF4yewrBCHEI4sOQx I6Cj5wa2NBVvg== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 7DF8882116; Thu, 28 Mar 2024 17:25:13 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 486291BF2F2 for ; Thu, 28 Mar 2024 17:25:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 40E1F401B1 for ; Thu, 28 Mar 2024 17:25:12 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id QKpR211PBdMp for ; Thu, 28 Mar 2024 17:25:11 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org A63FD400C1 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org A63FD400C1 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by smtp2.osuosl.org (Postfix) with ESMTPS id A63FD400C1 for ; Thu, 28 Mar 2024 17:25:11 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D95BE617AE; Thu, 28 Mar 2024 17:25:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2763CC433C7; Thu, 28 Mar 2024 17:25:07 +0000 (UTC) Date: Thu, 28 Mar 2024 17:25:06 +0000 From: Simon Horman To: Ivan Vecera Message-ID: <20240328172506.GG651713@kernel.org> References: <20240327075733.8967-1-ivecera@redhat.com> <20240327075733.8967-8-ivecera@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240327075733.8967-8-ivecera@redhat.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711646710; bh=4a9MWViGRcqAECnsnUOxO078l7HkHOclyczdE+L8b8c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dUiQfBepPA1AMjGJxnXohBg6QiEDNBLJomxDyDgNcW8B75CzH+ezeW+gLtvY7+sU5 WC+RBJi5svnnsSTLvvxT2tjIkYskvRxRshDvWoFdgupCMwkckm+8uvBQzEhjDbhEDQ C2MovaXiTeODaQ0OX4QcbzcddvGpeUuEZHVOxlwF07scSjRLBHlNcpY/86iy6f2Rb2 OIPXLQBTobxv3TL2ViatQmUxGmwKTREhHjtQG8RIhNkxPyKxtFrOKzKKJRSDXzUBi6 0jIq3vnZC9uHb2DQxA3n0PmM4+f7/ASim9otgNOC+j2uDHRHcgZzPcKKPb+cHD0yaJ CMUiC3Wf0tU/A== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=none dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=dUiQfBep Subject: Re: [Intel-wired-lan] [PATCH iwl-next v2 7/7] i40e: Add and use helper to reconfigure TC for given VSI X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, aleksandr.loktionov@intel.com, edumazet@google.com, intel-wired-lan@lists.osuosl.org, kuba@kernel.org, anthony.l.nguyen@intel.com, pabeni@redhat.com, davem@davemloft.net Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Wed, Mar 27, 2024 at 08:57:33AM +0100, Ivan Vecera wrote: > Add helper i40e_vsi_reconfig_tc(vsi) that configures TC > for given VSI using previously stored TC bitmap. > > Effectively replaces open-coded patterns: > > enabled_tc = vsi->tc_config.enabled_tc; > vsi->tc_config.enabled_tc = 0; > i40e_vsi_config_tc(vsi, enabled_tc); > > Reviewed-by: Michal Schmidt > Signed-off-by: Ivan Vecera Reviewed-by: Simon Horman From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3EE07EF07; Thu, 28 Mar 2024 17:25:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711646711; cv=none; b=onUkPxevWyWcAaUCOBf2oRv7WvqKbI7vp4WP+RkCpjIJVk5bMShvP1wwLYMW/Uofc3Ga2OqbWNxU666owLIIyIezWJsASd+h8s/3QuKs475mJ9GJ73yHtZHuIo95XEQlrCia2O4v2436/+K5AkHgfP6ucRW3HHR6Rh0r2spiw1M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711646711; c=relaxed/simple; bh=4a9MWViGRcqAECnsnUOxO078l7HkHOclyczdE+L8b8c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aOQuU5g+68M8nBulHfFEIfmKuVeCGBRMBbF2S6SsviFsWWCi3MUjz/3LV6TDjfJGhC499gG7rfxviSDQHyuoRi/U1+RxMJRB2g9GCEv9kV+UsghHHlDj2OqIziWKNsDw8kqk7x9BXwuJsaQ3Y1xEjqOKISH5ciBcOjj8jS2bDoU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dUiQfBep; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dUiQfBep" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2763CC433C7; Thu, 28 Mar 2024 17:25:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711646710; bh=4a9MWViGRcqAECnsnUOxO078l7HkHOclyczdE+L8b8c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dUiQfBepPA1AMjGJxnXohBg6QiEDNBLJomxDyDgNcW8B75CzH+ezeW+gLtvY7+sU5 WC+RBJi5svnnsSTLvvxT2tjIkYskvRxRshDvWoFdgupCMwkckm+8uvBQzEhjDbhEDQ C2MovaXiTeODaQ0OX4QcbzcddvGpeUuEZHVOxlwF07scSjRLBHlNcpY/86iy6f2Rb2 OIPXLQBTobxv3TL2ViatQmUxGmwKTREhHjtQG8RIhNkxPyKxtFrOKzKKJRSDXzUBi6 0jIq3vnZC9uHb2DQxA3n0PmM4+f7/ASim9otgNOC+j2uDHRHcgZzPcKKPb+cHD0yaJ CMUiC3Wf0tU/A== Date: Thu, 28 Mar 2024 17:25:06 +0000 From: Simon Horman To: Ivan Vecera Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, mschmidt@redhat.com, aleksandr.loktionov@intel.com, jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Subject: Re: [PATCH iwl-next v2 7/7] i40e: Add and use helper to reconfigure TC for given VSI Message-ID: <20240328172506.GG651713@kernel.org> References: <20240327075733.8967-1-ivecera@redhat.com> <20240327075733.8967-8-ivecera@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240327075733.8967-8-ivecera@redhat.com> On Wed, Mar 27, 2024 at 08:57:33AM +0100, Ivan Vecera wrote: > Add helper i40e_vsi_reconfig_tc(vsi) that configures TC > for given VSI using previously stored TC bitmap. > > Effectively replaces open-coded patterns: > > enabled_tc = vsi->tc_config.enabled_tc; > vsi->tc_config.enabled_tc = 0; > i40e_vsi_config_tc(vsi, enabled_tc); > > Reviewed-by: Michal Schmidt > Signed-off-by: Ivan Vecera Reviewed-by: Simon Horman