All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Brost <matthew.brost@intel.com>
To: <intel-xe@lists.freedesktop.org>
Cc: <thomas.hellstrom@linux.intel.com>,
	rodrigo.vivi@intel.com, lucas.demarchi@intel.com,
	Matthew Brost <matthew.brost@intel.com>
Subject: [PATCH 0/3] Rework work queue usage
Date: Thu, 28 Mar 2024 11:21:44 -0700	[thread overview]
Message-ID: <20240328182147.4169656-1-matthew.brost@intel.com> (raw)

Avoid sleeping or grabbing locks in work queues shared with the system.
Recent changes to work queues [1] have exposed deadlocks [2] in Xe.

I believe only patch #1 is required to unblock CI in 6.9rc1 [2] but
likely all patches should be included in stable kernels.

Matt

[1] https://lore.kernel.org/lkml/Ze7Jz9cQcUMtCqfk@slm.duckdns.org/
[2] https://intel-gfx-ci.01.org/tree/intel-xe/xe-984-093d82c02921344d8d400989af156aaf79b9d961/bat-adlp-7/igt_runner0.txt

Matthew Brost (3):
  drm/xe: Use ordered wq for preempt fence waiting
  drm/xe: Use device, gt ordered work queues for resource cleanup
  drm/xe: Use ordered WQ for TLB invalidation fences

 drivers/gpu/drm/xe/xe_device.c        | 7 ++++++-
 drivers/gpu/drm/xe/xe_device_types.h  | 8 +++++++-
 drivers/gpu/drm/xe/xe_execlist.c      | 2 +-
 drivers/gpu/drm/xe/xe_gt_types.h      | 5 ++++-
 drivers/gpu/drm/xe/xe_guc_submit.c    | 2 +-
 drivers/gpu/drm/xe/xe_preempt_fence.c | 2 +-
 drivers/gpu/drm/xe/xe_pt.c            | 2 +-
 drivers/gpu/drm/xe/xe_vm.c            | 4 ++--
 8 files changed, 23 insertions(+), 9 deletions(-)

-- 
2.34.1


             reply	other threads:[~2024-03-28 18:21 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-28 18:21 Matthew Brost [this message]
2024-03-28 18:21 ` [PATCH 1/3] drm/xe: Use ordered wq for preempt fence waiting Matthew Brost
2024-03-28 18:56   ` Matt Roper
2024-03-28 19:00     ` Matthew Brost
2024-04-01 19:37       ` Matthew Brost
2024-03-28 18:21 ` [PATCH 2/3] drm/xe: Use device, gt ordered work queues for resource cleanup Matthew Brost
2024-03-28 18:21 ` [PATCH 3/3] drm/xe: Use ordered WQ for TLB invalidation fences Matthew Brost
2024-03-28 19:02 ` [PATCH 0/3] Rework work queue usage Lucas De Marchi
2024-03-28 19:13   ` htejun
2024-03-28 19:30     ` Matthew Brost
2024-03-28 19:40       ` Tejun Heo
2024-03-29 16:52         ` Matthew Brost
2024-03-29  1:59 ` ✓ CI.Patch_applied: success for " Patchwork
2024-03-29  2:00 ` ✓ CI.checkpatch: " Patchwork
2024-03-29  2:00 ` ✓ CI.KUnit: " Patchwork
2024-03-29  2:12 ` ✓ CI.Build: " Patchwork
2024-03-29  2:15 ` ✓ CI.Hooks: " Patchwork
2024-03-29  2:16 ` ✓ CI.checksparse: " Patchwork
2024-03-29  2:53 ` ✗ CI.BAT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240328182147.4169656-1-matthew.brost@intel.com \
    --to=matthew.brost@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=thomas.hellstrom@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.