From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41D3217A909; Fri, 29 Mar 2024 12:41:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711716066; cv=none; b=q6rQKvNsBjOOpiE3nnoNts44Cnxk5j1nf/umxa1PV4eaHVq1JJZ8oV5ygtfWnotHo5UJ+dXBfjR7cH0bHnUwunO3UsrAaDb8OBI2fRkfqCUICcdcN1HftQz1M9nKwYvEEp4EIGS8JOf8x8ys9SOKNbElnhvD+jGA9shIzrseEEY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711716066; c=relaxed/simple; bh=r4/4GXGTk++z1W7+MaTn3Izp/E4xpOEvXWgaDBkkPY0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=H4fT+RHPxSYLacqdqc0QwIuPUYXGkcD35HMo06U2wJYeJfPGIgNxaLhL/1B8qlR3k3B1b+k5ZW316+LtmHbYK5vDOpQf6ZKbuiKD73v8/3g/SUayANThD/1kuSHoNltQz7BbEqyTntPofG6vH5j8noJbjg8Aoh6SKFjnHO8nv3w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=baLQioz5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="baLQioz5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A360AC433C7; Fri, 29 Mar 2024 12:41:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711716066; bh=r4/4GXGTk++z1W7+MaTn3Izp/E4xpOEvXWgaDBkkPY0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=baLQioz50XIsKuHdo+rpqttrJPekLBK3y7njFGIM9EeM04Q6M3WhI69erfyAF+gDX Inv58JKl5Jlu/Eu4dA09v/zBxqE3K7CI8qlRzucZLyzHM01sjWfQq87oigoBOEhkq4 Bf+ewqbWznthQ1a8KrqfTzSeI1wjSeV0a8LUSydScxYKnzThR3OugrGxNTIf0S+wyk iYLM9ISlZkm+H8IwNnO436fRCodP7nfcIE8sF8Yhr85EtvaSQL4jJwJ524isePhzM4 xQVKefDLuyWuZMSagwHMI1gHD25BE9yQ1KGFQiYjqHvlNgYXV+F38delwiPyC4eIDf 9bekIRWMy6UZg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Adam Ford , Jacky Bai , Sandor Yu , Ulf Hansson , Sasha Levin , shawnguo@kernel.org, heiko@sntech.de, marex@denx.de, u.kleine-koenig@pengutronix.de, linux-pm@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 6.8 35/98] pmdomain: imx8mp-blk-ctrl: imx8mp_blk: Add fdcc clock to hdmimix domain Date: Fri, 29 Mar 2024 08:37:06 -0400 Message-ID: <20240329123919.3087149-35-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240329123919.3087149-1-sashal@kernel.org> References: <20240329123919.3087149-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.8.2 Content-Transfer-Encoding: 8bit From: Adam Ford [ Upstream commit 697624ee8ad557ab5417f985d2c804241a7ad30d ] According to i.MX8MP RM and HDMI ADD, the fdcc clock is part of hdmi rx verification IP that should not enable for HDMI TX. But actually if the clock is disabled before HDMI/LCDIF probe, LCDIF will not get pixel clock from HDMI PHY and print the error logs: [CRTC:39:crtc-2] vblank wait timed out WARNING: CPU: 2 PID: 9 at drivers/gpu/drm/drm_atomic_helper.c:1634 drm_atomic_helper_wait_for_vblanks.part.0+0x23c/0x260 Add fdcc clock to LCDIF and HDMI TX power domains to fix the issue. Signed-off-by: Adam Ford Reviewed-by: Jacky Bai Signed-off-by: Sandor Yu Link: https://lore.kernel.org/r/20240203165307.7806-5-aford173@gmail.com Signed-off-by: Ulf Hansson Signed-off-by: Sasha Levin --- drivers/pmdomain/imx/imx8mp-blk-ctrl.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/pmdomain/imx/imx8mp-blk-ctrl.c b/drivers/pmdomain/imx/imx8mp-blk-ctrl.c index e3203eb6a0229..a56f7f92d0915 100644 --- a/drivers/pmdomain/imx/imx8mp-blk-ctrl.c +++ b/drivers/pmdomain/imx/imx8mp-blk-ctrl.c @@ -55,7 +55,7 @@ struct imx8mp_blk_ctrl_domain_data { const char *gpc_name; }; -#define DOMAIN_MAX_CLKS 2 +#define DOMAIN_MAX_CLKS 3 #define DOMAIN_MAX_PATHS 3 struct imx8mp_blk_ctrl_domain { @@ -457,8 +457,8 @@ static const struct imx8mp_blk_ctrl_domain_data imx8mp_hdmi_domain_data[] = { }, [IMX8MP_HDMIBLK_PD_LCDIF] = { .name = "hdmiblk-lcdif", - .clk_names = (const char *[]){ "axi", "apb" }, - .num_clks = 2, + .clk_names = (const char *[]){ "axi", "apb", "fdcc" }, + .num_clks = 3, .gpc_name = "lcdif", .path_names = (const char *[]){"lcdif-hdmi"}, .num_paths = 1, @@ -483,8 +483,8 @@ static const struct imx8mp_blk_ctrl_domain_data imx8mp_hdmi_domain_data[] = { }, [IMX8MP_HDMIBLK_PD_HDMI_TX] = { .name = "hdmiblk-hdmi-tx", - .clk_names = (const char *[]){ "apb", "ref_266m" }, - .num_clks = 2, + .clk_names = (const char *[]){ "apb", "ref_266m", "fdcc" }, + .num_clks = 3, .gpc_name = "hdmi-tx", }, [IMX8MP_HDMIBLK_PD_HDMI_TX_PHY] = { -- 2.43.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E8B51C6FD1F for ; Fri, 29 Mar 2024 12:44:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=affKkaweDWJpkVgGRoXDWkHJoouCm6pIT50gmuh6XD4=; b=cO2xQ+tFkpOtLY R/RU0wR/FpfwBDu0T9A7fISYL1APVDtg7SoF0FGNoFIILR2NJJRpE8nRsGEeDWM4SAo5dpUItUu4K 6yEXGaUXXFRuY4WEmSItFzZcAntusbyHFZvFsWuaq0O0onqBUmWt76XdlxErCDOp2y/zwPK6BImln AGA5jtonDhrfbNO3kbo/9cQU1bTcPyHUIXC+DLTmEF8cNBHK4rBXHle/kx48EqRKuKlXrPT1gdygU 057/DV6WBYTwHSg45ugcLyA6GI5qka3Ybv7+RsIh+FUHnKCkZdKjwzYYsoL7yXB/JyjlFQ7Mwr74y xpdjzu82VjgWDOJLXhhg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rqBZw-00000000R2f-3dnA; Fri, 29 Mar 2024 12:43:59 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rqBXn-00000000QUv-1YZX for linux-arm-kernel@bombadil.infradead.org; Fri, 29 Mar 2024 12:41:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version :References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=Rwjf51TzglVBkP4h3Ownr/JNkniDXgJE9hH/kdsN6F4=; b=nIeWeO6BNjKPf3Q33iNZdZwSuR CXun0Nr9GayctK1GHdwmzlOcEMe+nAaKU366ajU7ot9IT7E8MW3fst9RCHKfSeqN+tNSjN1vLR5WX v9KPv+7rKdr4nHCL6W/LbCq1713EAF3RzYn2FiTq645+T+1DP55y+3TPy3NmvV8/mDRmsa4E7ZeB1 jQEY4m3ru6c/p1e3lEa8bAO0kGu4sLf144C6XflsOzU7oBSYgdI2PrsD7jGVpNDtZFDk9ACck+SJC JDgqYLfhi6LWsYQXTUSWDYhA2AsylmdtXBGUpOYWYmblr5bPgfI1GCutu4/L2o/z+QMhWDDlwAWGJ BLzSWlOg==; Received: from sin.source.kernel.org ([145.40.73.55]) by desiato.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rqBXi-00000001YvE-2MkV for linux-arm-kernel@lists.infradead.org; Fri, 29 Mar 2024 12:41:13 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id D3C99CE2F33; Fri, 29 Mar 2024 12:41:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A360AC433C7; Fri, 29 Mar 2024 12:41:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711716066; bh=r4/4GXGTk++z1W7+MaTn3Izp/E4xpOEvXWgaDBkkPY0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=baLQioz50XIsKuHdo+rpqttrJPekLBK3y7njFGIM9EeM04Q6M3WhI69erfyAF+gDX Inv58JKl5Jlu/Eu4dA09v/zBxqE3K7CI8qlRzucZLyzHM01sjWfQq87oigoBOEhkq4 Bf+ewqbWznthQ1a8KrqfTzSeI1wjSeV0a8LUSydScxYKnzThR3OugrGxNTIf0S+wyk iYLM9ISlZkm+H8IwNnO436fRCodP7nfcIE8sF8Yhr85EtvaSQL4jJwJ524isePhzM4 xQVKefDLuyWuZMSagwHMI1gHD25BE9yQ1KGFQiYjqHvlNgYXV+F38delwiPyC4eIDf 9bekIRWMy6UZg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Adam Ford , Jacky Bai , Sandor Yu , Ulf Hansson , Sasha Levin , shawnguo@kernel.org, heiko@sntech.de, marex@denx.de, u.kleine-koenig@pengutronix.de, linux-pm@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 6.8 35/98] pmdomain: imx8mp-blk-ctrl: imx8mp_blk: Add fdcc clock to hdmimix domain Date: Fri, 29 Mar 2024 08:37:06 -0400 Message-ID: <20240329123919.3087149-35-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240329123919.3087149-1-sashal@kernel.org> References: <20240329123919.3087149-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.8.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240329_124111_405314_79874E64 X-CRM114-Status: GOOD ( 14.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Adam Ford [ Upstream commit 697624ee8ad557ab5417f985d2c804241a7ad30d ] According to i.MX8MP RM and HDMI ADD, the fdcc clock is part of hdmi rx verification IP that should not enable for HDMI TX. But actually if the clock is disabled before HDMI/LCDIF probe, LCDIF will not get pixel clock from HDMI PHY and print the error logs: [CRTC:39:crtc-2] vblank wait timed out WARNING: CPU: 2 PID: 9 at drivers/gpu/drm/drm_atomic_helper.c:1634 drm_atomic_helper_wait_for_vblanks.part.0+0x23c/0x260 Add fdcc clock to LCDIF and HDMI TX power domains to fix the issue. Signed-off-by: Adam Ford Reviewed-by: Jacky Bai Signed-off-by: Sandor Yu Link: https://lore.kernel.org/r/20240203165307.7806-5-aford173@gmail.com Signed-off-by: Ulf Hansson Signed-off-by: Sasha Levin --- drivers/pmdomain/imx/imx8mp-blk-ctrl.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/pmdomain/imx/imx8mp-blk-ctrl.c b/drivers/pmdomain/imx/imx8mp-blk-ctrl.c index e3203eb6a0229..a56f7f92d0915 100644 --- a/drivers/pmdomain/imx/imx8mp-blk-ctrl.c +++ b/drivers/pmdomain/imx/imx8mp-blk-ctrl.c @@ -55,7 +55,7 @@ struct imx8mp_blk_ctrl_domain_data { const char *gpc_name; }; -#define DOMAIN_MAX_CLKS 2 +#define DOMAIN_MAX_CLKS 3 #define DOMAIN_MAX_PATHS 3 struct imx8mp_blk_ctrl_domain { @@ -457,8 +457,8 @@ static const struct imx8mp_blk_ctrl_domain_data imx8mp_hdmi_domain_data[] = { }, [IMX8MP_HDMIBLK_PD_LCDIF] = { .name = "hdmiblk-lcdif", - .clk_names = (const char *[]){ "axi", "apb" }, - .num_clks = 2, + .clk_names = (const char *[]){ "axi", "apb", "fdcc" }, + .num_clks = 3, .gpc_name = "lcdif", .path_names = (const char *[]){"lcdif-hdmi"}, .num_paths = 1, @@ -483,8 +483,8 @@ static const struct imx8mp_blk_ctrl_domain_data imx8mp_hdmi_domain_data[] = { }, [IMX8MP_HDMIBLK_PD_HDMI_TX] = { .name = "hdmiblk-hdmi-tx", - .clk_names = (const char *[]){ "apb", "ref_266m" }, - .num_clks = 2, + .clk_names = (const char *[]){ "apb", "ref_266m", "fdcc" }, + .num_clks = 3, .gpc_name = "hdmi-tx", }, [IMX8MP_HDMIBLK_PD_HDMI_TX_PHY] = { -- 2.43.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel