All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@linux.intel.com>
To: intel-gfx <intel-gfx@lists.freedesktop.org>
Cc: Chris Wilson <chris.p.wilson@linux.intel.com>,
	Nirmoy Das <nirmoy.das@intel.com>,
	Lionel Landwerlin <lionel.g.landwerlin@intel.com>,
	Andi Shyti <andi.shyti@linux.intel.com>,
	Andi Shyti <andi.shyti@kernel.org>
Subject: [PATCH v2 1/2] drm/i915/gem: Increment vma offset when mapping fb objects
Date: Fri, 29 Mar 2024 17:39:58 +0100	[thread overview]
Message-ID: <20240329163959.791865-2-andi.shyti@linux.intel.com> (raw)
In-Reply-To: <20240329163959.791865-1-andi.shyti@linux.intel.com>

Until now the "vm_pgoff" was not used and there has been no need
to set its offset.

But now, because we want to support partial mappings with a given
offset, we need it to be set.

Suggested-by: Chris Wilson <chris.p.wilson@linux.intel.com>
Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
---
 drivers/gpu/drm/i915/gem/i915_gem_mman.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/i915/gem/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
index a2195e28b625..ce10dd259812 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_mman.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
@@ -1084,6 +1084,8 @@ int i915_gem_fb_mmap(struct drm_i915_gem_object *obj, struct vm_area_struct *vma
 		mmo = mmap_offset_attach(obj, mmap_type, NULL);
 		if (IS_ERR(mmo))
 			return PTR_ERR(mmo);
+
+		vma->vm_pgoff += drm_vma_node_start(&mmo->vma_node);
 	}
 
 	/*
-- 
2.43.0


  reply	other threads:[~2024-03-29 16:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-29 16:39 [PATCH v2 0/2] Add support for partial mapping Andi Shyti
2024-03-29 16:39 ` Andi Shyti [this message]
2024-03-29 16:39 ` [PATCH v2 2/2] drm/i915/gem: Calculate object page offset for partial memory mapping Andi Shyti
2024-04-11 14:18   ` Nirmoy Das
2024-04-11 14:26     ` Andi Shyti
2024-03-29 18:15 ` ✗ Fi.CI.CHECKPATCH: warning for Add support for partial mapping Patchwork
2024-03-29 18:28 ` ✓ Fi.CI.BAT: success " Patchwork
2024-03-30 20:11 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-04-09 15:12 ` ✗ Fi.CI.CHECKPATCH: warning for Add support for partial mapping (rev2) Patchwork
2024-04-09 15:23 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-04-11 15:24 ` ✗ Fi.CI.CHECKPATCH: warning for Add support for partial mapping (rev3) Patchwork
2024-04-11 15:31 ` ✓ Fi.CI.BAT: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240329163959.791865-2-andi.shyti@linux.intel.com \
    --to=andi.shyti@linux.intel.com \
    --cc=andi.shyti@kernel.org \
    --cc=chris.p.wilson@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=lionel.g.landwerlin@intel.com \
    --cc=nirmoy.das@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.