All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: Sasha Levin <sashal@kernel.org>,
	stable@vger.kernel.org, Rik van Riel <riel@surriel.com>,
	Mel Gorman <mgorman@techsingularity.net>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: FAILED: Patch "bounds: support non-power-of-two CONFIG_NR_CPUS" failed to apply to 5.4-stable tree
Date: Fri, 29 Mar 2024 18:05:20 +0100	[thread overview]
Message-ID: <2024032959-ladies-circling-3a5e@gregkh> (raw)
In-Reply-To: <2024032935-antsy-imitation-1453@gregkh>

On Fri, Mar 29, 2024 at 02:34:43PM +0100, Greg KH wrote:
> On Wed, Mar 27, 2024 at 02:10:10PM +0000, Matthew Wilcox wrote:
> > On Wed, Mar 27, 2024 at 08:21:25AM -0400, Sasha Levin wrote:
> > > The patch below does not apply to the 5.4-stable tree.
> > > If someone wants it applied there, or to any other stable or longterm
> > > tree, then please email the backport, including the original git commit
> > > id to <stable@vger.kernel.org>.
> > 
> > Looks like you just need a little more fuzz on the patch.
> > 
> > diff --git a/kernel/bounds.c b/kernel/bounds.c
> > index 9795d75b09b2..a94e3769347e 100644
> > --- a/kernel/bounds.c
> > +++ b/kernel/bounds.c
> > @@ -19,7 +19,7 @@ int main(void)
> >  	DEFINE(NR_PAGEFLAGS, __NR_PAGEFLAGS);
> >  	DEFINE(MAX_NR_ZONES, __MAX_NR_ZONES);
> >  #ifdef CONFIG_SMP
> > -	DEFINE(NR_CPUS_BITS, ilog2(CONFIG_NR_CPUS));
> > +	DEFINE(NR_CPUS_BITS, bits_per(CONFIG_NR_CPUS));
> >  #endif
> >  	DEFINE(SPINLOCK_SIZE, sizeof(spinlock_t));
> >  	/* End of constants */
> 
> Now fuzzed, thanks.

But it breaks the build on 4.19.y, so I'll go drop it from there.  If
you want it added there, please provide a working fix.

thanks,

greg k-h

  reply	other threads:[~2024-03-29 17:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-27 12:21 FAILED: Patch "bounds: support non-power-of-two CONFIG_NR_CPUS" failed to apply to 5.4-stable tree Sasha Levin
2024-03-27 14:10 ` Matthew Wilcox
2024-03-29 13:34   ` Greg KH
2024-03-29 17:05     ` Greg KH [this message]
2024-04-02  5:33       ` Matthew Wilcox
2024-04-05  6:36         ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024032959-ladies-circling-3a5e@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@techsingularity.net \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=riel@surriel.com \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.