From: <gregkh@linuxfoundation.org>
To: akpm@linux-foundation.org,dan.j.williams@intel.com,gregkh@linuxfoundation.org,linux-mm@kvack.org,liushixin2@huawei.com,n-horiguchi@ah.jp.nec.com,sashal@kernel.org,willy@infradead.org
Cc: <stable-commits@vger.kernel.org>
Subject: Patch "mm/memory-failure: fix an incorrect use of tail pages" has been added to the 4.19-stable tree
Date: Sat, 30 Mar 2024 10:20:06 +0100 [thread overview]
Message-ID: <2024033006-retreat-unknown-b871@gregkh> (raw)
In-Reply-To: <20240307125150.2849068-1-liushixin2@huawei.com>
This is a note to let you know that I've just added the patch titled
mm/memory-failure: fix an incorrect use of tail pages
to the 4.19-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
mm-memory-failure-fix-an-incorrect-use-of-tail-pages.patch
and it can be found in the queue-4.19 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.
From liushixin2@huawei.com Sat Mar 30 10:11:48 2024
From: Liu Shixin <liushixin2@huawei.com>
Date: Thu, 7 Mar 2024 20:51:50 +0800
Subject: mm/memory-failure: fix an incorrect use of tail pages
To: Matthew Wilcox <willy@infradead.org>, Andrew Morton <akpm@linux-foundation.org>, Sasha Levin <sashal@kernel.org>, Dan Williams <dan.j.williams@intel.com>, Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>, <stable@vger.kernel.org>, Liu Shixin <liushixin2@huawei.com>
Message-ID: <20240307125150.2849068-1-liushixin2@huawei.com>
From: Liu Shixin <liushixin2@huawei.com>
When backport commit c79c5a0a00a9 to 4.19-stable, there is a mistake change.
The head page instead of tail page should be passed to try_to_unmap(),
otherwise unmap will failed as follows.
Memory failure: 0x121c10: failed to unmap page (mapcount=1)
Memory failure: 0x121c10: recovery action for unmapping failed page: Ignored
Fixes: c6f50413f2aa ("mm/memory-failure: check the mapcount of the precise page")
Signed-off-by: Liu Shixin <liushixin2@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
mm/memory-failure.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/mm/memory-failure.c
+++ b/mm/memory-failure.c
@@ -1033,7 +1033,7 @@ static bool hwpoison_user_mappings(struc
if (kill)
collect_procs(hpage, &tokill, flags & MF_ACTION_REQUIRED);
- unmap_success = try_to_unmap(p, ttu);
+ unmap_success = try_to_unmap(hpage, ttu);
if (!unmap_success)
pr_err("Memory failure: %#lx: failed to unmap page (mapcount=%d)\n",
pfn, page_mapcount(p));
Patches currently in stable-queue which might be from liushixin2@huawei.com are
queue-4.19/mm-memory-failure-fix-an-incorrect-use-of-tail-pages.patch
prev parent reply other threads:[~2024-03-30 9:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 12:51 [PATCH stable-4.19] mm/memory-failure: fix an incorrect use of tail pages Liu Shixin
2024-03-30 9:20 ` gregkh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024033006-retreat-unknown-b871@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=linux-mm@kvack.org \
--cc=liushixin2@huawei.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=sashal@kernel.org \
--cc=stable-commits@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.