From: Nicholas Piggin <npiggin@gmail.com>
To: qemu-devel@nongnu.org
Cc: "Nicholas Piggin" <npiggin@gmail.com>,
qemu-ppc@nongnu.org, "Harsh Prateek Bora" <harshpb@linux.ibm.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PULL 1/8] spapr: nested: use bitwise NOT operator for flags check
Date: Sun, 31 Mar 2024 17:33:38 +1000 [thread overview]
Message-ID: <20240331073349.88324-2-npiggin@gmail.com> (raw)
In-Reply-To: <20240331073349.88324-1-npiggin@gmail.com>
From: Harsh Prateek Bora <harshpb@linux.ibm.com>
Check for flag bit in H_GUEST_GETSET_STATE_FLAG_GUEST_WIDE need to use
bitwise NOT operator to ensure no other flag bits are set.
Resolves: Coverity CID 1540008
Resolves: Coverity CID 1540009
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off by: Harsh Prateek Bora <harshpb@linux.ibm.com>
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
hw/ppc/spapr_nested.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ppc/spapr_nested.c b/hw/ppc/spapr_nested.c
index 936659b4c0..c02785756c 100644
--- a/hw/ppc/spapr_nested.c
+++ b/hw/ppc/spapr_nested.c
@@ -1511,7 +1511,7 @@ static target_ulong h_guest_getset_state(PowerPCCPU *cpu,
if (flags & H_GUEST_GETSET_STATE_FLAG_GUEST_WIDE) {
gsr.flags |= GUEST_STATE_REQUEST_GUEST_WIDE;
}
- if (flags & !H_GUEST_GETSET_STATE_FLAG_GUEST_WIDE) {
+ if (flags & ~H_GUEST_GETSET_STATE_FLAG_GUEST_WIDE) {
return H_PARAMETER; /* flag not supported yet */
}
--
2.43.0
next prev parent reply other threads:[~2024-03-31 7:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-31 7:33 [PULL 0/8] ppc-for-9.0-3 queue Nicholas Piggin
2024-03-31 7:33 ` Nicholas Piggin [this message]
2024-03-31 7:33 ` [PULL 2/8] hw/ppc/spapr: Include missing 'sysemu/tcg.h' header Nicholas Piggin
2024-03-31 7:33 ` [PULL 3/8] target/ppc/mmu-radix64: Use correct string format in walk_tree() Nicholas Piggin
2024-03-31 7:33 ` [PULL 4/8] target/ppc: Restore [H]DEXCR to 64-bits Nicholas Piggin
2024-03-31 7:33 ` [PULL 5/8] target/ppc: Fix GDB register indexing on secondary CPUs Nicholas Piggin
2024-03-31 7:33 ` [PULL 6/8] target/ppc: Do not clear MSR[ME] on MCE interrupts to supervisor Nicholas Piggin
2024-03-31 7:33 ` [PULL 7/8] tests/avocado: Fix ppc_hv_tests.py xorriso dependency guard Nicholas Piggin
2024-03-31 7:33 ` [PULL 8/8] tests/avocado: ppc_hv_tests.py set alpine time before setup-alpine Nicholas Piggin
2024-04-01 12:09 ` [PULL 0/8] ppc-for-9.0-3 queue Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240331073349.88324-2-npiggin@gmail.com \
--to=npiggin@gmail.com \
--cc=harshpb@linux.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.