All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: [openeuler:openEuler-1.0-LTS 15530/22010] drivers/iommu/dmar.c:750 dmar_acpi_bus_add_dev() error: uninitialized symbol 'ret'.
Date: Sun, 31 Mar 2024 17:29:41 +0800	[thread overview]
Message-ID: <202403311708.wZJ05bN5-lkp@intel.com> (raw)

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: kernel@openeuler.org
TO: Cheng Jian <cj.chengjian@huawei.com>

tree:   https://gitee.com/openeuler/kernel.git openEuler-1.0-LTS
head:   6726609c5990ede3a9fdb318d1dc759d03678a1a
commit: 0f7d0c8b66a415734cbd2c8a7afc586c4a1d61cc [15530/22010] iommu/vt-d:Add support for detecting ACPI device in RMRR
:::::: branch date: 26 hours ago
:::::: commit date: 3 years ago
config: x86_64-randconfig-161-20240329 (https://download.01.org/0day-ci/archive/20240331/202403311708.wZJ05bN5-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202403311708.wZJ05bN5-lkp@intel.com/

smatch warnings:
drivers/iommu/dmar.c:750 dmar_acpi_bus_add_dev() error: uninitialized symbol 'ret'.

vim +/ret +750 drivers/iommu/dmar.c

0f7d0c8b66a415 LeoLiu-oc       2021-04-07  732  
0f7d0c8b66a415 LeoLiu-oc       2021-04-07  733  static int dmar_acpi_bus_add_dev(u8 device_number, struct acpi_device *adev)
0f7d0c8b66a415 LeoLiu-oc       2021-04-07  734  {
0f7d0c8b66a415 LeoLiu-oc       2021-04-07  735  	struct dmar_drhd_unit *dmaru;
0f7d0c8b66a415 LeoLiu-oc       2021-04-07  736  	struct acpi_dmar_hardware_unit *drhd;
0f7d0c8b66a415 LeoLiu-oc       2021-04-07  737  	int ret;
0f7d0c8b66a415 LeoLiu-oc       2021-04-07  738  
0f7d0c8b66a415 LeoLiu-oc       2021-04-07  739  	for_each_drhd_unit(dmaru) {
0f7d0c8b66a415 LeoLiu-oc       2021-04-07  740  		drhd = container_of(dmaru->hdr,
0f7d0c8b66a415 LeoLiu-oc       2021-04-07  741  				    struct acpi_dmar_hardware_unit,
0f7d0c8b66a415 LeoLiu-oc       2021-04-07  742  				    header);
0f7d0c8b66a415 LeoLiu-oc       2021-04-07  743  
0f7d0c8b66a415 LeoLiu-oc       2021-04-07  744  		ret = dmar_acpi_insert_dev_scope(device_number, adev, (void *)(drhd+1),
0f7d0c8b66a415 LeoLiu-oc       2021-04-07  745  						((void *)drhd)+drhd->header.length,
0f7d0c8b66a415 LeoLiu-oc       2021-04-07  746  						dmaru->devices, dmaru->devices_cnt);
0f7d0c8b66a415 LeoLiu-oc       2021-04-07  747  		if (ret)
0f7d0c8b66a415 LeoLiu-oc       2021-04-07  748  			break;
0f7d0c8b66a415 LeoLiu-oc       2021-04-07  749  	}
0f7d0c8b66a415 LeoLiu-oc       2021-04-07 @750  	if (ret > 0)
0f7d0c8b66a415 LeoLiu-oc       2021-04-07  751  		ret = dmar_rmrr_add_acpi_dev(device_number, adev);
0f7d0c8b66a415 LeoLiu-oc       2021-04-07  752  	return ret;
ed40356b5fcf1c David Woodhouse 2014-03-07  753  }
ed40356b5fcf1c David Woodhouse 2014-03-07  754  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2024-03-31  9:30 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202403311708.wZJ05bN5-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=error27@gmail.com \
    --cc=oe-kbuild@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.