From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9EF705B217 for ; Sun, 31 Mar 2024 10:13:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711880007; cv=none; b=VdJ9VeAwvu1ANHMXOr5s7kB6qkASsuNKU1b4A2e+MLySKX8tDIr8EwtuSJfBrpWf0N/N1UOQRQiRZwEp+Ddjp2/oBgWu1OyRSMoV582+SQWNXID9GgV1Wol/TIhOUetxnfogJIE7SqAC6cFmyiyUlMk/Envh7ZhfBQmur0+uHk8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711880007; c=relaxed/simple; bh=qWZ8JUwQJXqVHeB49wXTXwp8DJg5NqlsjxOqXLQ55Uw=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=UTpGjS2i/LMQ0Exqv/tCayJy3kSG/U6I4/rKAsg6KdMDAG3Fk/JTPw6M30DlDVq/nuuw+q6keKjF+63mFu0eTz8c+/4WMyeFYjgHlUzczwiVc1Co1DTKDoAClDb9EZZ+Q+LJvHEyvL8icqvTZJWSU/DemGNs0eHl3yWwEcpK8qQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=IkJfVm2X; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="IkJfVm2X" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1711880004; x=1743416004; h=date:from:to:cc:subject:message-id:mime-version; bh=qWZ8JUwQJXqVHeB49wXTXwp8DJg5NqlsjxOqXLQ55Uw=; b=IkJfVm2XXsT0wyW/70CvGs9f/3kJyVGDcBQtsI5sRp/wv4LmG4vwKq3k jAzfB19WykU2uIYPgEqx8x9oCk4IdFoGPJ59w+iRcOdv1KKA94AtLT2aw g5SR0NRk+vVnYf6iDwpSWgmdDit0FRWky+wU+onlyLQ7SdJsJxoWICjiz aQmu5n6pg8ThK64C4ZmymdPOBhpF44jd8iAwLSqdaYNGd+0PXFaYUh+FX UIO4Ucch9Voa2c+egTcudeAfaRKZsFkKqkx4jpidO6squoLa0B5ZZs363 pUZxJjcsVGqTE8Ro08nzys0PuMPqSuwkGqfysK0mkESD5+v2OYNZ9Bu/w A==; X-CSE-ConnectionGUID: OC4VOfWTSWycjlEwaywBjA== X-CSE-MsgGUID: pZ7SB5mFQHm74EOD88yCzQ== X-IronPort-AV: E=McAfee;i="6600,9927,11029"; a="10841089" X-IronPort-AV: E=Sophos;i="6.07,169,1708416000"; d="scan'208";a="10841089" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2024 03:13:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,169,1708416000"; d="scan'208";a="21863379" Received: from lkp-server01.sh.intel.com (HELO 3d808bfd2502) ([10.239.97.150]) by fmviesa005.fm.intel.com with ESMTP; 31 Mar 2024 03:13:22 -0700 Received: from kbuild by 3d808bfd2502 with local (Exim 4.96) (envelope-from ) id 1rqsBk-000110-1C; Sun, 31 Mar 2024 10:13:20 +0000 Date: Sun, 31 Mar 2024 18:12:39 +0800 From: kernel test robot To: oe-kbuild@lists.linux.dev Cc: lkp@intel.com, Julia Lawall Subject: [linux-next:master 839/2532] drivers/gpu/drm/amd/display/dc/dpp/dcn10/dcn10_dpp_dscl.c:400:42-43: WARNING opportunity for min() Message-ID: <202403311823.yMksX4fY-lkp@intel.com> Precedence: bulk X-Mailing-List: oe-kbuild@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline BCC: lkp@intel.com CC: oe-kbuild-all@lists.linux.dev CC: Linux Memory Management List TO: Revalla Hari Krishna CC: Alex Deucher CC: Martin Leung tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: a6bd6c9333397f5a0e2667d4d82fef8c970108f2 commit: 88867807564e28409d8220419da7559364109a2a [839/2532] drm/amd/display: Refactor DPP into a component directory :::::: branch date: 3 days ago :::::: commit date: 11 days ago config: x86_64-randconfig-102-20240326 (https://download.01.org/0day-ci/archive/20240331/202403311823.yMksX4fY-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Julia Lawall | Closes: https://lore.kernel.org/r/202403311823.yMksX4fY-lkp@intel.com/ cocci warnings: (new ones prefixed by >>) >> drivers/gpu/drm/amd/display/dc/dpp/dcn10/dcn10_dpp_dscl.c:400:42-43: WARNING opportunity for min() drivers/gpu/drm/amd/display/dc/dpp/dcn10/dcn10_dpp_dscl.c:402:46-47: WARNING opportunity for min() -- >> drivers/gpu/drm/amd/display/dc/dpp/dcn20/dcn20_dpp.c:269:42-43: WARNING opportunity for min() drivers/gpu/drm/amd/display/dc/dpp/dcn20/dcn20_dpp.c:271:46-47: WARNING opportunity for min() -- >> drivers/gpu/drm/amd/display/dc/dpp/dcn32/dcn32_dpp.c:43:42-43: WARNING opportunity for min() drivers/gpu/drm/amd/display/dc/dpp/dcn32/dcn32_dpp.c:45:46-47: WARNING opportunity for min() vim +400 drivers/gpu/drm/amd/display/dc/dpp/dcn10/dcn10_dpp_dscl.c 5e9a81b2c46555 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Yue Hin Lau 2017-08-15 390 dd93752b648309 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Yue Hin Lau 2017-10-10 391 void dpp1_dscl_calc_lb_num_partitions( 5e9a81b2c46555 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Yue Hin Lau 2017-08-15 392 const struct scaler_data *scl_data, 5e9a81b2c46555 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Yue Hin Lau 2017-08-15 393 enum lb_memory_config lb_config, 5e9a81b2c46555 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Yue Hin Lau 2017-08-15 394 int *num_part_y, 5e9a81b2c46555 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Yue Hin Lau 2017-08-15 395 int *num_part_c) 5e9a81b2c46555 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Yue Hin Lau 2017-08-15 396 { 59979bf8be1784 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Murton Liu 2019-02-15 397 int lb_memory_size, lb_memory_size_c, lb_memory_size_a, num_partitions_a, 59979bf8be1784 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Murton Liu 2019-02-15 398 lb_bpc, memory_line_size_y, memory_line_size_c, memory_line_size_a; 59979bf8be1784 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Murton Liu 2019-02-15 399 5e9a81b2c46555 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Yue Hin Lau 2017-08-15 @400 int line_size = scl_data->viewport.width < scl_data->recout.width ? 5e9a81b2c46555 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Yue Hin Lau 2017-08-15 401 scl_data->viewport.width : scl_data->recout.width; 5e9a81b2c46555 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Yue Hin Lau 2017-08-15 402 int line_size_c = scl_data->viewport_c.width < scl_data->recout.width ? 5e9a81b2c46555 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Yue Hin Lau 2017-08-15 403 scl_data->viewport_c.width : scl_data->recout.width; 59979bf8be1784 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Murton Liu 2019-02-15 404 59979bf8be1784 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Murton Liu 2019-02-15 405 if (line_size == 0) 59979bf8be1784 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Murton Liu 2019-02-15 406 line_size = 1; 59979bf8be1784 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Murton Liu 2019-02-15 407 59979bf8be1784 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Murton Liu 2019-02-15 408 if (line_size_c == 0) 59979bf8be1784 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Murton Liu 2019-02-15 409 line_size_c = 1; 59979bf8be1784 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Murton Liu 2019-02-15 410 59979bf8be1784 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Murton Liu 2019-02-15 411 59979bf8be1784 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Murton Liu 2019-02-15 412 lb_bpc = dpp1_dscl_get_lb_depth_bpc(scl_data->lb_params.depth); 59979bf8be1784 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Murton Liu 2019-02-15 413 memory_line_size_y = (line_size * lb_bpc + 71) / 72; /* +71 to ceil */ 59979bf8be1784 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Murton Liu 2019-02-15 414 memory_line_size_c = (line_size_c * lb_bpc + 71) / 72; /* +71 to ceil */ 59979bf8be1784 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Murton Liu 2019-02-15 415 memory_line_size_a = (line_size + 5) / 6; /* +5 to ceil */ 5e9a81b2c46555 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Yue Hin Lau 2017-08-15 416 5e9a81b2c46555 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Yue Hin Lau 2017-08-15 417 if (lb_config == LB_MEMORY_CONFIG_1) { 5e9a81b2c46555 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Yue Hin Lau 2017-08-15 418 lb_memory_size = 816; 5e9a81b2c46555 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Yue Hin Lau 2017-08-15 419 lb_memory_size_c = 816; 5e9a81b2c46555 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Yue Hin Lau 2017-08-15 420 lb_memory_size_a = 984; 5e9a81b2c46555 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Yue Hin Lau 2017-08-15 421 } else if (lb_config == LB_MEMORY_CONFIG_2) { 5e9a81b2c46555 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Yue Hin Lau 2017-08-15 422 lb_memory_size = 1088; 5e9a81b2c46555 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Yue Hin Lau 2017-08-15 423 lb_memory_size_c = 1088; 5e9a81b2c46555 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Yue Hin Lau 2017-08-15 424 lb_memory_size_a = 1312; 5e9a81b2c46555 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Yue Hin Lau 2017-08-15 425 } else if (lb_config == LB_MEMORY_CONFIG_3) { 734a092b1fe407 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Eric Bernstein 2017-09-29 426 /* 420 mode: using 3rd mem from Y, Cr and Cb */ 5e9a81b2c46555 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Yue Hin Lau 2017-08-15 427 lb_memory_size = 816 + 1088 + 848 + 848 + 848; 5e9a81b2c46555 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Yue Hin Lau 2017-08-15 428 lb_memory_size_c = 816 + 1088; 5e9a81b2c46555 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Yue Hin Lau 2017-08-15 429 lb_memory_size_a = 984 + 1312 + 456; 5e9a81b2c46555 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Yue Hin Lau 2017-08-15 430 } else { 5e9a81b2c46555 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Yue Hin Lau 2017-08-15 431 lb_memory_size = 816 + 1088 + 848; 5e9a81b2c46555 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Yue Hin Lau 2017-08-15 432 lb_memory_size_c = 816 + 1088 + 848; 5e9a81b2c46555 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Yue Hin Lau 2017-08-15 433 lb_memory_size_a = 984 + 1312 + 456; 5e9a81b2c46555 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Yue Hin Lau 2017-08-15 434 } 5e9a81b2c46555 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Yue Hin Lau 2017-08-15 435 *num_part_y = lb_memory_size / memory_line_size_y; 5e9a81b2c46555 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Yue Hin Lau 2017-08-15 436 *num_part_c = lb_memory_size_c / memory_line_size_c; 5e9a81b2c46555 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Yue Hin Lau 2017-08-15 437 num_partitions_a = lb_memory_size_a / memory_line_size_a; 5e9a81b2c46555 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Yue Hin Lau 2017-08-15 438 5e9a81b2c46555 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Yue Hin Lau 2017-08-15 439 if (scl_data->lb_params.alpha_en 5e9a81b2c46555 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Yue Hin Lau 2017-08-15 440 && (num_partitions_a < *num_part_y)) 5e9a81b2c46555 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Yue Hin Lau 2017-08-15 441 *num_part_y = num_partitions_a; 5e9a81b2c46555 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Yue Hin Lau 2017-08-15 442 5e9a81b2c46555 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Yue Hin Lau 2017-08-15 443 if (*num_part_y > 64) 5e9a81b2c46555 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Yue Hin Lau 2017-08-15 444 *num_part_y = 64; 5e9a81b2c46555 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Yue Hin Lau 2017-08-15 445 if (*num_part_c > 64) 5e9a81b2c46555 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Yue Hin Lau 2017-08-15 446 *num_part_c = 64; 5e9a81b2c46555 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c Yue Hin Lau 2017-08-15 447 :::::: The code at line 400 was first introduced by commit :::::: 5e9a81b2c465557adbaeef7231834e3ab40e4102 drm/amd/display: separate scl functions out from dcn10_dpp :::::: TO: Yue Hin Lau :::::: CC: Alex Deucher -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki