From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7180FCD128A for ; Mon, 1 Apr 2024 16:06:53 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rrKAa-00051u-98; Mon, 01 Apr 2024 12:06:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rrKAZ-00051l-23 for qemu-devel@nongnu.org; Mon, 01 Apr 2024 12:05:59 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rrKAX-0001ZX-Mi for qemu-devel@nongnu.org; Mon, 01 Apr 2024 12:05:58 -0400 Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4V7bNH6t7Jz6K7JS; Tue, 2 Apr 2024 00:01:19 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id EB0981400D9; Tue, 2 Apr 2024 00:05:54 +0800 (CST) Received: from localhost (10.48.156.172) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 1 Apr 2024 17:05:54 +0100 Date: Mon, 1 Apr 2024 17:05:53 +0100 To: Philippe =?ISO-8859-1?Q?Mathieu-Daud=E9?= CC: , Richard Henderson , Eduardo Habkost , Stefano Stabellini , , Bernhard Beschow , Thomas Huth , Marcel Apfelbaum , "Michael S. Tsirkin" , "Paolo Bonzini" , Igor Mammedov , "Anthony Perard" , Ani Sinha Subject: Re: [RFC PATCH-for-9.1 08/29] hw/i386/pc: Move CXLState to PcPciMachineState Message-ID: <20240401170553.00000ba3@Huawei.com> In-Reply-To: <20240328155439.58719-9-philmd@linaro.org> References: <20240328155439.58719-1-philmd@linaro.org> <20240328155439.58719-9-philmd@linaro.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.48.156.172] X-ClientProxiedBy: lhrpeml100003.china.huawei.com (7.191.160.210) To lhrpeml500005.china.huawei.com (7.191.163.240) Received-SPF: pass client-ip=185.176.79.56; envelope-from=jonathan.cameron@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Jonathan Cameron From: Jonathan Cameron via Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, 28 Mar 2024 16:54:16 +0100 Philippe Mathieu-Daud=E9 wrote: > CXL depends on PCIe, which isn't available on non-PCI > machines such the ISA-only PC one. > Move CXLState to PcPciMachineState, and move the CXL > specific calls to pc_pci_machine_initfn() and > pc_pci_machine_done(). >=20 > Signed-off-by: Philippe Mathieu-Daud=E9 LGTM as a change on it's own - I've not reviewed the series in general though, hence just an ack as an rb feels too strong. Acked-by: Jonathan Cameron From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5E782CD128A for ; Mon, 1 Apr 2024 16:06:23 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.699926.1092397 (Exim 4.92) (envelope-from ) id 1rrKAZ-000445-PS; Mon, 01 Apr 2024 16:05:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 699926.1092397; Mon, 01 Apr 2024 16:05:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rrKAZ-00043y-My; Mon, 01 Apr 2024 16:05:59 +0000 Received: by outflank-mailman (input) for mailman id 699926; Mon, 01 Apr 2024 16:05:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rrKAY-00043s-Nc for xen-devel@lists.xenproject.org; Mon, 01 Apr 2024 16:05:58 +0000 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b8c8c5d4-f041-11ee-afe5-a90da7624cb6; Mon, 01 Apr 2024 18:05:57 +0200 (CEST) Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4V7bNH6t7Jz6K7JS; Tue, 2 Apr 2024 00:01:19 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id EB0981400D9; Tue, 2 Apr 2024 00:05:54 +0800 (CST) Received: from localhost (10.48.156.172) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 1 Apr 2024 17:05:54 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b8c8c5d4-f041-11ee-afe5-a90da7624cb6 Date: Mon, 1 Apr 2024 17:05:53 +0100 From: Jonathan Cameron To: Philippe =?ISO-8859-1?Q?Mathieu-Daud=E9?= CC: , Richard Henderson , Eduardo Habkost , Stefano Stabellini , , Bernhard Beschow , Thomas Huth , Marcel Apfelbaum , "Michael S. Tsirkin" , "Paolo Bonzini" , Igor Mammedov , "Anthony Perard" , Ani Sinha Subject: Re: [RFC PATCH-for-9.1 08/29] hw/i386/pc: Move CXLState to PcPciMachineState Message-ID: <20240401170553.00000ba3@Huawei.com> In-Reply-To: <20240328155439.58719-9-philmd@linaro.org> References: <20240328155439.58719-1-philmd@linaro.org> <20240328155439.58719-9-philmd@linaro.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.48.156.172] X-ClientProxiedBy: lhrpeml100003.china.huawei.com (7.191.160.210) To lhrpeml500005.china.huawei.com (7.191.163.240) On Thu, 28 Mar 2024 16:54:16 +0100 Philippe Mathieu-Daud=E9 wrote: > CXL depends on PCIe, which isn't available on non-PCI > machines such the ISA-only PC one. > Move CXLState to PcPciMachineState, and move the CXL > specific calls to pc_pci_machine_initfn() and > pc_pci_machine_done(). >=20 > Signed-off-by: Philippe Mathieu-Daud=E9 LGTM as a change on it's own - I've not reviewed the series in general though, hence just an ack as an rb feels too strong. Acked-by: Jonathan Cameron