From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52DFECD1284 for ; Tue, 2 Apr 2024 14:25:54 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id DDC834052F; Tue, 2 Apr 2024 14:25:53 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id dHKqQJehrtYl; Tue, 2 Apr 2024 14:25:53 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 0125A404F8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1712067953; bh=5R32dYH4+lOvrWDcci4EnK6nNfNzY0nULyXBIk+gZR8=; h=Date:From:To:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=UL8axrseFFDOQj4Y3kBOEZ0SuJNU3x3Xomd585xkRb7X8min++z0nRbm1E1BBoW9g Swf7oTMqOrohhfKf/T0SqT1XZtGRdedtUcbpwxfg+eeKKX7P92ptH9raBVo6r91OZV PNh4gmW1tbQ1GZFDz0bejNONCq9nnbaWbiCd7CsSufzyx5PkDrmbqsvIePsB5w+NCu u6YbglGU9KYt+Jf1PYA6nowBw4JKuaROW9YSd93PL5ms5CCUllCknbf6zsO2TRO72q wOA93YxUibc54cmMinIhbapuo8YGBhPWtbkz4MLuIBHE+Me5emFcP0gpDzpl/BRv63 Bc0iYiG7MxZsQ== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 0125A404F8; Tue, 2 Apr 2024 14:25:52 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id C50681BF389 for ; Tue, 2 Apr 2024 14:25:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id BDF9382046 for ; Tue, 2 Apr 2024 14:25:51 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id sRyTAQDkz15p for ; Tue, 2 Apr 2024 14:25:51 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=kuba@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org F12638203F DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org F12638203F Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by smtp1.osuosl.org (Postfix) with ESMTPS id F12638203F for ; Tue, 2 Apr 2024 14:25:50 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id B7CAF60B87; Tue, 2 Apr 2024 14:25:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D338FC433C7; Tue, 2 Apr 2024 14:25:48 +0000 (UTC) Date: Tue, 2 Apr 2024 07:25:47 -0700 From: Jakub Kicinski To: Wojciech Drewek Message-ID: <20240402072547.0ac0f186@kernel.org> In-Reply-To: References: <20240329092321.16843-1-wojciech.drewek@intel.com> <38d874e3-f25b-4af2-8c1c-946ab74c1925@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712067949; bh=cjKN5hbtCPmpzdSHcCawK2S+8/qL/Ksj9dPaudgrNeQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=e1kyeqs+mVApLka41jrcEPhGi2XtTDLVZijg91eIslOiToJyHw97oDPnlNvoYnJEs +nSlXeIdxGzF4u0nqszEIG5gT4HJHGU2CGWmhk4LYO/xKYy3KjuubPYH2k2niJiPUv UOScB+KvgpJ8TaCOFZ71eGFUCfoNUunWhQUW3JFi5opa8PO4Nmdm/nHr/x3aubDIKe d7+OHjGPp10F2XTIl3CPnOqW3TvbgR0bD1/4lBZQsq0DhqKvAvqRJswQUs25rYr8nR f2BUC39/qIAQfM3hQZx/vi9N6K9ks4b9rMKrPFrodZMZP6bd1N1q7PlT3mjDmyNSaY wga5TdOcOfSUw== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=none dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=e1kyeqs+ Subject: Re: [Intel-wired-lan] [PATCH net-next 0/3] ethtool: Max power support X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , idosch@nvidia.com, edumazet@google.com, marcin.szycik@linux.intel.com, anthony.l.nguyen@intel.com, netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, pabeni@redhat.com, przemyslaw.kitszel@intel.com Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, 2 Apr 2024 13:38:59 +0200 Wojciech Drewek wrote: > > Also, this is about the board, the SFP cage, not the actual SFP > > module? Maybe the word cage needs to be in these names? > > It's about cage. Thanks for bringing it to my attention because now I > see it might be misleading. I'm extending {set|show}-module command > but the changes are about max power in the cage. With that in mind > I agree that adding 'cage' to the names makes sense. Noob question, what happens if you plug a module with higher power needs into the cage? From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C234280BEE for ; Tue, 2 Apr 2024 14:25:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712067949; cv=none; b=hcxVdFljYaNATLwY4Vd0H1VE82BHguDlrDm7B1qIEQN2RnPptAbeWIY8WkxELn06nGLvlJeK/U2LQ4ETzCG2F4TYwbXnl3j13vUJO9u+4rwI2o//dTsDFmElUfZjACgEkRFBX7oONu0JpXnECIQQppsa0uCRTJCMp3QlwykhlsA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712067949; c=relaxed/simple; bh=cjKN5hbtCPmpzdSHcCawK2S+8/qL/Ksj9dPaudgrNeQ=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=g1hwDxIcgFhdPzg2eBU1lN0xzYf9F9LftCSDaNll7XZXctKMAq3BGVzSl++Rn1cEfiqqxKI6Tsi+V7mL8qMYbOwiJQrorDv7XeUX3oDcsLjYfLxdsWvrYTeqt/t+V9DoGvHxwPhfP5+fbZxxBRq7gbzqMi7fKoqD74i/MCnq414= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=e1kyeqs+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="e1kyeqs+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D338FC433C7; Tue, 2 Apr 2024 14:25:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712067949; bh=cjKN5hbtCPmpzdSHcCawK2S+8/qL/Ksj9dPaudgrNeQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=e1kyeqs+mVApLka41jrcEPhGi2XtTDLVZijg91eIslOiToJyHw97oDPnlNvoYnJEs +nSlXeIdxGzF4u0nqszEIG5gT4HJHGU2CGWmhk4LYO/xKYy3KjuubPYH2k2niJiPUv UOScB+KvgpJ8TaCOFZ71eGFUCfoNUunWhQUW3JFi5opa8PO4Nmdm/nHr/x3aubDIKe d7+OHjGPp10F2XTIl3CPnOqW3TvbgR0bD1/4lBZQsq0DhqKvAvqRJswQUs25rYr8nR f2BUC39/qIAQfM3hQZx/vi9N6K9ks4b9rMKrPFrodZMZP6bd1N1q7PlT3mjDmyNSaY wga5TdOcOfSUw== Date: Tue, 2 Apr 2024 07:25:47 -0700 From: Jakub Kicinski To: Wojciech Drewek Cc: Andrew Lunn , , , , , , , , Subject: Re: [Intel-wired-lan] [PATCH net-next 0/3] ethtool: Max power support Message-ID: <20240402072547.0ac0f186@kernel.org> In-Reply-To: References: <20240329092321.16843-1-wojciech.drewek@intel.com> <38d874e3-f25b-4af2-8c1c-946ab74c1925@lunn.ch> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 2 Apr 2024 13:38:59 +0200 Wojciech Drewek wrote: > > Also, this is about the board, the SFP cage, not the actual SFP > > module? Maybe the word cage needs to be in these names? > > It's about cage. Thanks for bringing it to my attention because now I > see it might be misleading. I'm extending {set|show}-module command > but the changes are about max power in the cage. With that in mind > I agree that adding 'cage' to the names makes sense. Noob question, what happens if you plug a module with higher power needs into the cage?