From: Christoph Hellwig <hch@lst.de>
To: linan666@huaweicloud.com
Cc: axboe@kernel.dk, hch@lst.de, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, yukuai3@huawei.com,
yi.zhang@huawei.com, houtao1@huawei.com, yangerkun@huawei.com
Subject: Re: [PATCH] block: fix overflow in blk_ioctl_discard()
Date: Tue, 2 Apr 2024 14:32:45 +0200 [thread overview]
Message-ID: <20240402123245.GA30793@lst.de> (raw)
In-Reply-To: <20240329012319.2034550-1-linan666@huaweicloud.com>
On Fri, Mar 29, 2024 at 09:23:19AM +0800, linan666@huaweicloud.com wrote:
> From: Li Nan <linan122@huawei.com>
>
> There is no check for overflow of 'start + len' in blk_ioctl_discard().
> Hung task occurs if submit an discard ioctl with the following param:
> start = 0x80000000000ff000, len = 0x8000000000fff000;
> Add the overflow validation now.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
Can you wire up a testcase in blktests for this condition?
next prev parent reply other threads:[~2024-04-02 12:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-29 1:23 [PATCH] block: fix overflow in blk_ioctl_discard() linan666
2024-04-02 12:32 ` Christoph Hellwig [this message]
2024-04-03 1:28 ` Li Nan
2024-04-02 13:43 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240402123245.GA30793@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=houtao1@huawei.com \
--cc=linan666@huaweicloud.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.