All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Werner Sembach <wse@tuxedocomputers.com>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
	Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
	Georg Gottleuber <ggo@tuxedocomputers.com>,
	linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme-pci: Add sleep quirk for Samsung 990 Evo
Date: Tue, 2 Apr 2024 15:16:58 +0200	[thread overview]
Message-ID: <20240402131658.GA31963@lst.de> (raw)
In-Reply-To: <20240328130923.61752-1-wse@tuxedocomputers.com>

On Thu, Mar 28, 2024 at 02:09:22PM +0100, Werner Sembach wrote:
> From: Georg Gottleuber <ggo@tuxedocomputers.com>
> 
> On some TUXEDO platforms, a Samsung 990 Evo NVMe leads to a high
> power consumption in s2idle sleep (2-3 watts).
> 
> This patch applies 'Force No Simple Suspend' quirk to achieve a
> sleep with a lower power consumption, typically around 0.5 watts.

Does this only apply to a specific SSD or all SSDs on this platform?
How do these platforms even get into the conditional?  Probably
through acpi_storage_d3 setting, which probably is set incorrectly
for the platform?  Any chance to just fix that?



  reply	other threads:[~2024-04-02 13:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-28 13:09 [PATCH] nvme-pci: Add sleep quirk for Samsung 990 Evo Werner Sembach
2024-04-02 13:16 ` Christoph Hellwig [this message]
2024-04-02 15:13   ` Georg Gottleuber
2024-04-02 16:08     ` Keith Busch
2024-04-03  9:24       ` Georg Gottleuber
2024-08-09  9:37         ` Werner Sembach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240402131658.GA31963@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=ggo@tuxedocomputers.com \
    --cc=kbusch@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    --cc=wse@tuxedocomputers.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.