From: Jakub Kicinski <kuba@kernel.org>
To: Marek Vasut <marex@denx.de>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Eric Dumazet" <edumazet@google.com>,
"Mark Brown" <broonie@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Ronald Wahl" <ronald.wahl@raritan.com>,
"Simon Horman" <horms@kernel.org>
Subject: Re: [PATCH 2/2] net: ks8851: Handle softirqs at the end of IRQ thread to fix hang
Date: Tue, 2 Apr 2024 15:01:11 -0700 [thread overview]
Message-ID: <20240402150111.170dc2cc@kernel.org> (raw)
In-Reply-To: <96ee283f-53cc-4317-8ac5-f08c4291a887@denx.de>
On Tue, 2 Apr 2024 19:38:26 +0200 Marek Vasut wrote:
> >> ks->netdev->stats.rx_packets++;
> >> ks->netdev->stats.rx_bytes += rxlen;
> >> @@ -325,11 +325,15 @@ static void ks8851_rx_pkts(struct ks8851_net *ks)
> >> */
> >> static irqreturn_t ks8851_irq(int irq, void *_ks)
> >> {
> >> + bool need_bh_off = !(hardirq_count() | softirq_count());
> >
> > I don't think IRQ / RT developers look approvingly at uses of such
> > low level macros in drivers.
>
> I _think_ the need_bh_off will be always true as Ratheesh suggested, so
> this can be dropped. I will test that before doing a V2.
Quite possibly, seems like a reasonable fix if we don't have to make it
conditional.
next prev parent reply other threads:[~2024-04-02 22:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-31 14:21 [PATCH 1/2] net: ks8851: Inline ks8851_rx_skb() Marek Vasut
2024-03-31 14:21 ` [PATCH 2/2] net: ks8851: Handle softirqs at the end of IRQ thread to fix hang Marek Vasut
2024-04-01 4:18 ` Ratheesh Kannoth
2024-04-01 10:41 ` Marek Vasut
2024-04-01 14:13 ` [EXTERNAL] " Ratheesh Kannoth
2024-04-02 17:29 ` Marek Vasut
2024-04-02 4:06 ` Jakub Kicinski
2024-04-02 17:38 ` Marek Vasut
2024-04-02 22:01 ` Jakub Kicinski [this message]
2024-04-29 11:46 ` Ronald Wahl
2024-04-29 13:23 ` Marek Vasut
2024-04-29 13:50 ` Ronald Wahl
2024-04-30 1:18 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240402150111.170dc2cc@kernel.org \
--to=kuba@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=davem@davemloft.net \
--cc=dmitry.torokhov@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=marex@denx.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ronald.wahl@raritan.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.