From: David Disseldorp <ddiss@suse.de>
To: 蔡晓斌 <caixiaobin0807@163.com>
Cc: fstests@vger.kernel.org
Subject: Re: about the format problem at generic/556, and supply a fix patch
Date: Tue, 2 Apr 2024 15:51:35 +1100 [thread overview]
Message-ID: <20240402155135.156ab20a@echidna> (raw)
In-Reply-To: <5c043f11.244a.18e9c783e59.Coremail.caixiaobin0807@163.com>
Hi,
On Tue, 2 Apr 2024 09:41:49 +0800 (CST), 蔡晓斌 wrote:
...
> From 40ff753ffb3dd4ab8789699dc45a83ece64a3626 Mon Sep 17 00:00:00 2001
> From: "cai.xiaobin" <cai.xiaobin@gd-linux.com>
> Date: Wed, 20 Mar 2024 11:13:29 +0800
> Subject: [PATCH] generic/556: reverse the order of comments to make the file
> look more like a script file
>
>
> ---
> tests/generic/556 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
> diff --git a/tests/generic/556 b/tests/generic/556
> index 404a3243..ccefbcc4 100755
> --- a/tests/generic/556
> +++ b/tests/generic/556
> @@ -1,5 +1,5 @@
> -# SPDX-License-Identifier: GPL-2.0+
> #!/bin/bash
> +# SPDX-License-Identifier: GPL-2.0+
> # FS QA Test No. 556
> #
> # Test the basic functionality of filesystems with case-insensitive
Looks fine to me, although I'd suggest a simpler patch description:
generic/556: move shebang to first line
Reviewed-by: David Disseldorp <ddiss@suse.de>
next prev parent reply other threads:[~2024-04-02 4:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 1:41 about the format problem at generic/556, and supply a fix patch 蔡晓斌
2024-04-02 4:51 ` David Disseldorp [this message]
2024-04-02 6:22 ` 蔡晓斌
2024-04-03 10:54 ` Zorro Lang
2024-04-07 2:10 ` 蔡晓斌
2024-04-13 19:49 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240402155135.156ab20a@echidna \
--to=ddiss@suse.de \
--cc=caixiaobin0807@163.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.