From: Mikhail Rudenko <mike.rudenko@gmail.com>
To: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Jacopo Mondi <jacopo@jmondi.org>,
Tommaso Merciai <tomm.merciai@gmail.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Mikhail Rudenko <mike.rudenko@gmail.com>
Subject: [PATCH v4 08/20] media: i2c: ov4689: Enable runtime PM before registering sub-device
Date: Tue, 2 Apr 2024 19:45:39 +0300 [thread overview]
Message-ID: <20240402164552.19171-9-mike.rudenko@gmail.com> (raw)
In-Reply-To: <20240402164552.19171-1-mike.rudenko@gmail.com>
As the sensor may be accessible right after its async sub-device is
registered, enable runtime PM before doing so.
Signed-off-by: Mikhail Rudenko <mike.rudenko@gmail.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
drivers/media/i2c/ov4689.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/media/i2c/ov4689.c b/drivers/media/i2c/ov4689.c
index 47feb6b5ede8..0e0e694510aa 100644
--- a/drivers/media/i2c/ov4689.c
+++ b/drivers/media/i2c/ov4689.c
@@ -875,19 +875,21 @@ static int ov4689_probe(struct i2c_client *client)
goto err_clean_entity;
}
+ pm_runtime_set_active(dev);
+ pm_runtime_enable(dev);
+ pm_runtime_idle(dev);
+
ret = v4l2_async_register_subdev_sensor(sd);
if (ret) {
dev_err(dev, "v4l2 async register subdev failed\n");
- goto err_clean_subdev;
+ goto err_clean_subdev_pm;
}
- pm_runtime_set_active(dev);
- pm_runtime_enable(dev);
- pm_runtime_idle(dev);
-
return 0;
-err_clean_subdev:
+err_clean_subdev_pm:
+ pm_runtime_disable(dev);
+ pm_runtime_set_suspended(dev);
v4l2_subdev_cleanup(sd);
err_clean_entity:
media_entity_cleanup(&sd->entity);
--
2.44.0
next prev parent reply other threads:[~2024-04-02 16:46 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 16:45 [PATCH v4 00/20] Omnivision OV4689 refactoring and improvements Mikhail Rudenko
2024-04-02 16:45 ` [PATCH v4 01/20] media: i2c: ov4689: Clean up and annotate the register table Mikhail Rudenko
2024-04-02 16:45 ` [PATCH v4 02/20] media: i2c: ov4689: Sort register definitions by address Mikhail Rudenko
2024-04-02 16:45 ` [PATCH v4 03/20] media: i2c: ov4689: Fix typo in a comment Mikhail Rudenko
2024-04-02 16:45 ` [PATCH v4 04/20] media: i2c: ov4689: CCI conversion Mikhail Rudenko
2024-04-02 16:45 ` [PATCH v4 05/20] media: i2c: ov4689: Remove i2c_client from ov4689 struct Mikhail Rudenko
2024-04-02 16:45 ` [PATCH v4 06/20] media: i2c: ov4689: Refactor ov4689_set_ctrl Mikhail Rudenko
2024-04-02 16:45 ` [PATCH v4 07/20] media: i2c: ov4689: Use sub-device active state Mikhail Rudenko
2024-04-02 16:45 ` Mikhail Rudenko [this message]
2024-04-02 16:45 ` [PATCH v4 09/20] media: i2c: ov4689: Use runtime PM autosuspend Mikhail Rudenko
2024-04-02 16:45 ` [PATCH v4 10/20] media: i2c: ov4689: Remove max_fps field from struct ov4689_mode Mikhail Rudenko
2024-04-02 16:45 ` [PATCH v4 11/20] media: i2c: ov4689: Make horizontal blanking configurable Mikhail Rudenko
2024-04-02 16:45 ` [PATCH v4 12/20] media: i2c: ov4689: Implement vflip/hflip controls Mikhail Rudenko
2024-04-02 16:45 ` [PATCH v4 13/20] media: i2c: ov4689: Implement digital gain control Mikhail Rudenko
2024-04-02 16:45 ` [PATCH v4 14/20] media: i2c: ov4689: Implement manual color balance controls Mikhail Rudenko
2024-04-02 16:45 ` [PATCH v4 15/20] media: i2c: ov4689: Move pixel array size out of struct ov4689_mode Mikhail Rudenko
2024-04-02 16:45 ` [PATCH v4 16/20] media: i2c: ov4689: Set timing registers programmatically Mikhail Rudenko
2024-04-02 16:45 ` [PATCH v4 17/20] media: i2c: ov4689: Configurable analogue crop Mikhail Rudenko
2024-04-15 6:08 ` Sakari Ailus
2024-04-15 20:22 ` Mikhail Rudenko
2024-04-16 6:47 ` Sakari Ailus
2024-04-16 22:51 ` Mikhail Rudenko
2024-04-02 16:45 ` [PATCH v4 18/20] media: i2c: ov4689: Eliminate struct ov4689_mode Mikhail Rudenko
2024-04-02 16:45 ` [PATCH v4 19/20] media: i2c: ov4689: Refactor ov4689_s_stream Mikhail Rudenko
2024-04-02 16:45 ` [PATCH v4 20/20] media: i2c: ov4689: Implement 2x2 binning Mikhail Rudenko
2024-04-15 6:07 ` Sakari Ailus
2024-04-15 20:05 ` Mikhail Rudenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240402164552.19171-9-mike.rudenko@gmail.com \
--to=mike.rudenko@gmail.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dave.stevenson@raspberrypi.com \
--cc=jacopo@jmondi.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tomm.merciai@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.