From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Heiko Stuebner <heiko@sntech.de>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] ASoC: codecs: rk3308: add dependency on OF
Date: Tue, 2 Apr 2024 17:17:45 +0200 [thread overview]
Message-ID: <20240402171745.2cae620a@booty> (raw)
In-Reply-To: <ec02a779-0917-456e-9bad-c5b12528206e@sirena.org.uk>
Hello Mark,
On Tue, 2 Apr 2024 14:04:19 +0100
Mark Brown <broonie@kernel.org> wrote:
> On Fri, Mar 29, 2024 at 09:44:47PM +0100, Luca Ceresoli wrote:
>
> > config SND_SOC_RK3308
> > tristate "Rockchip RK3308 audio CODEC"
> > + depends on OF
>
> There's no actual build dependency on OF, please add an || COMPILE_TEST
> to improve build coverage and help maintainability.
I see, thanks for the comment.
While there, an even better improvement is probably:
depends on ARM64 || COMPILE_TEST
using ARM64 because this codec is known to exist only on the RK3308 and
ARM64 selects OF.
Best regards,
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2024-04-02 15:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-29 20:44 [PATCH] ASoC: codecs: rk3308: add dependency on OF Luca Ceresoli
2024-04-02 13:04 ` Mark Brown
2024-04-02 15:17 ` Luca Ceresoli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240402171745.2cae620a@booty \
--to=luca.ceresoli@bootlin.com \
--cc=broonie@kernel.org \
--cc=heiko@sntech.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=lkp@intel.com \
--cc=perex@perex.cz \
--cc=thomas.petazzoni@bootlin.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.