From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6DF94085A; Wed, 3 Apr 2024 03:30:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712115057; cv=none; b=efX0nxd3Sl25GLBVn6b+YKQPcIrWZv17nKqxiPFF/Px0HDQVybMA4gWzhC+tXuE6bq5eMNMCAQJUrRLZVeuoUfeKZ/D3UpAbLv0Az4BnLbTNVLBwADFl3GNz5NjByLL4XlVC3ukdmHFu10ttsSRdSvsh3QsK4uNHNsQvTf3VSmk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712115057; c=relaxed/simple; bh=aUHCt2G7OXXo2o4YJpgKFb2OWsCjhGSf+zKg2+GPiFU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qQsBfRJ2p5A6cXElYBw1ZgxmJzhQk113uwbbVlQ6aa2GMH/FWR7Sca0RCIIC45cwAvUur1av/kDEU68e8y8eQDyXWXkRno2w3rp6bAuywM36CL73xy+jxjAaw8pdWedXxtVU8FTOX2IoXR/FA/CfG9fjuGOYZQaKyW86AHtv6f8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=uAAEV/1P; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="uAAEV/1P" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3129C433F1; Wed, 3 Apr 2024 03:30:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712115057; bh=aUHCt2G7OXXo2o4YJpgKFb2OWsCjhGSf+zKg2+GPiFU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uAAEV/1P7uecv9LxBjxJwaDuB2DRliq+mLbtBH9a5/NTqmXTxKzZcVLyIjR7h9nSu RavWKK8nGD3a5I6ZXc5gfgy2LALZOYSpW7/4TrWkzA82V1l+cZvrkNIMW2b1vhxqqe Kso9i34D4Pvnz3sLruOqRQ8siwwmLZwVkNmcAfKQEbe8WYWdesfZdW2m/64pN/xuGQ N+CIMfgrTwjWlJSCPriefrDG1SbvppJhHi4iZ5JqCUMZki6fw0N2TwdUItWBhitd9U 13eCEPhcqGY3M3Z9piSfZV7WgYBFuS1Eq7pX1POdh+k8gCSo5wVktHhTKcAwBbU5xx HNgLbEV1k7FxQ== Date: Tue, 2 Apr 2024 20:30:55 -0700 From: Eric Biggers To: Eugen Hristev Cc: tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, jaegeuk@kernel.org, chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, krisman@suse.de, Gabriel Krisman Bertazi Subject: Re: [PATCH v15 2/9] f2fs: Simplify the handling of cached insensitive names Message-ID: <20240403033055.GD2576@sol.localdomain> References: <20240402154842.508032-1-eugen.hristev@collabora.com> <20240402154842.508032-3-eugen.hristev@collabora.com> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240402154842.508032-3-eugen.hristev@collabora.com> On Tue, Apr 02, 2024 at 06:48:35PM +0300, Eugen Hristev wrote: > diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c > index d0f24ccbd1ac..7e53abf6d216 100644 > --- a/fs/f2fs/recovery.c > +++ b/fs/f2fs/recovery.c > @@ -153,11 +153,8 @@ static int init_recovered_filename(const struct inode *dir, > if (err) > return err; > f2fs_hash_filename(dir, fname); > -#if IS_ENABLED(CONFIG_UNICODE) > /* Case-sensitive match is fine for recovery */ > - kmem_cache_free(f2fs_cf_name_slab, fname->cf_name.name); > - fname->cf_name.name = NULL; > -#endif > + f2fs_free_casefolded_name(fname); > } else { > f2fs_hash_filename(dir, fname); > } This change makes the declaration of f2fs_cf_name_slab in recovery.c unnecessary. It can be removed. - Eric From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D7BE4C6FD1F for ; Wed, 3 Apr 2024 03:31:12 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1rrrL9-0004PD-BT; Wed, 03 Apr 2024 03:31:07 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rrrL7-0004P3-VI for linux-f2fs-devel@lists.sourceforge.net; Wed, 03 Apr 2024 03:31:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=7XvrA6hpFmQN68c+PhQ6b+lMMbQYAJc8dV3oVn/oTDU=; b=LW6ZdPMX3NUTsst0mnZ+LtFt1K 0tMH62MBvxS+QOeB4ZjwiEVa3/OJiBfUiokMo4GIptPBzNQ9pmJhuwSNo8/0Z3P8/3S5H6xEtlEDk DV9bTaS1YBpRb37N2cNgbx6h3EhYWB1hq2fZ1tzDn2nJCNNu+3TXnrG1VwheVavy4qSg=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=7XvrA6hpFmQN68c+PhQ6b+lMMbQYAJc8dV3oVn/oTDU=; b=PGDOmjRpN21VPo+8zAPJNqCOM4 pD874whPaudxNpGc6kPy0ttSSyjnBEr/P2pykSMn17tW3A5rYx1LXZXv+v44cnkm89oWe6+J8u/cr C+srS1qAyLwpjZ5GVeYWZ3zVL/pAXkuILO3nBx1S0/xv/9UMX2bMessm7TBHuNXXq5Gg=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1rrrL4-0005PR-L1 for linux-f2fs-devel@lists.sourceforge.net; Wed, 03 Apr 2024 03:31:06 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 917EE61200; Wed, 3 Apr 2024 03:30:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3129C433F1; Wed, 3 Apr 2024 03:30:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712115057; bh=aUHCt2G7OXXo2o4YJpgKFb2OWsCjhGSf+zKg2+GPiFU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uAAEV/1P7uecv9LxBjxJwaDuB2DRliq+mLbtBH9a5/NTqmXTxKzZcVLyIjR7h9nSu RavWKK8nGD3a5I6ZXc5gfgy2LALZOYSpW7/4TrWkzA82V1l+cZvrkNIMW2b1vhxqqe Kso9i34D4Pvnz3sLruOqRQ8siwwmLZwVkNmcAfKQEbe8WYWdesfZdW2m/64pN/xuGQ N+CIMfgrTwjWlJSCPriefrDG1SbvppJhHi4iZ5JqCUMZki6fw0N2TwdUItWBhitd9U 13eCEPhcqGY3M3Z9piSfZV7WgYBFuS1Eq7pX1POdh+k8gCSo5wVktHhTKcAwBbU5xx HNgLbEV1k7FxQ== Date: Tue, 2 Apr 2024 20:30:55 -0700 From: Eric Biggers To: Eugen Hristev Message-ID: <20240403033055.GD2576@sol.localdomain> References: <20240402154842.508032-1-eugen.hristev@collabora.com> <20240402154842.508032-3-eugen.hristev@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240402154842.508032-3-eugen.hristev@collabora.com> X-Headers-End: 1rrrL4-0005PR-L1 Subject: Re: [f2fs-dev] [PATCH v15 2/9] f2fs: Simplify the handling of cached insensitive names X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: krisman@suse.de, brauner@kernel.org, kernel@collabora.com, tytso@mit.edu, jack@suse.cz, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, adilger.kernel@dilger.ca, viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, jaegeuk@kernel.org, linux-ext4@vger.kernel.org, Gabriel Krisman Bertazi Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Tue, Apr 02, 2024 at 06:48:35PM +0300, Eugen Hristev wrote: > diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c > index d0f24ccbd1ac..7e53abf6d216 100644 > --- a/fs/f2fs/recovery.c > +++ b/fs/f2fs/recovery.c > @@ -153,11 +153,8 @@ static int init_recovered_filename(const struct inode *dir, > if (err) > return err; > f2fs_hash_filename(dir, fname); > -#if IS_ENABLED(CONFIG_UNICODE) > /* Case-sensitive match is fine for recovery */ > - kmem_cache_free(f2fs_cf_name_slab, fname->cf_name.name); > - fname->cf_name.name = NULL; > -#endif > + f2fs_free_casefolded_name(fname); > } else { > f2fs_hash_filename(dir, fname); > } This change makes the declaration of f2fs_cf_name_slab in recovery.c unnecessary. It can be removed. - Eric _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel