From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADBF0374CF; Wed, 3 Apr 2024 04:20:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712118028; cv=none; b=uZeRyKxgddP3zz4hAy2emBJvOYGAP0YAb0FtysHNAA0Lmptj2Q01HgwS6cBKQZLNyf/9D5xmifvPhA6iHDVEZn7MhzXFjt/wiNUF7b1JUYgbWp/OVdmLDyEd3yoP/h4W0UsIgAvzKQnEYB8vnlurUKVcx0EpqYeHuimHteYZxpc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712118028; c=relaxed/simple; bh=Tcj0j+1YWOxbiPelc6hNIb/Y8mkmLGVcLgWgtH4cpsY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ndOmcD+VB0GFB0eWhXrkWXSGa9LDm7uFSbXv41h9pdnRWEBuH7qv8S7TBQJcKHO0n5LZN0MbQDhfwkvJctzBCMj7cT10NswBd822/2dyKJ7FHOVrRVNf0zK/z+RJSBB2Qv1UxiTBuoWKCTzV+LEv/MofUjjkHxkWHy+0RfOGkfg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IK3N90/s; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IK3N90/s" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C99C2C433C7; Wed, 3 Apr 2024 04:20:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712118028; bh=Tcj0j+1YWOxbiPelc6hNIb/Y8mkmLGVcLgWgtH4cpsY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IK3N90/stwO6flnkEFAcjrGv++OvGc5A3+Q3yHAT2MbgfhRpUYiBOsKEnNGNnXCe0 hG6u6J5PsMNsc9UZDdPB/OsTCzD5rXcorEGJlgk/s9S7+EKycsLD+lbQDC2upMc0J7 9JMBbktmK8LLG6nrDCk1mtd1cr5LB16HsyEWb7SRBdjQF/otJ9NoEveRdXWcOkRu5R 2K7C6kdwVKAzBYqvWRb5y+Tg8Fu+b/v8SXQfgxoWCJ518/eTHc4UGwL70AC8Ccs0Ol l36nqpI2SDN1oKatrTeVK4NresoHeE8IEK0lT6oKhAVj/DLfCvKIZOhBoHyEKO71Gu RkAYeVxFHi2jg== Date: Tue, 2 Apr 2024 21:20:26 -0700 From: Eric Biggers To: Eugen Hristev Cc: tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, jaegeuk@kernel.org, chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, krisman@suse.de, Gabriel Krisman Bertazi Subject: Re: [PATCH v15 4/9] ext4: Reuse generic_ci_match for ci comparisons Message-ID: <20240403042026.GG2576@sol.localdomain> References: <20240402154842.508032-1-eugen.hristev@collabora.com> <20240402154842.508032-5-eugen.hristev@collabora.com> <20240403034328.GF2576@sol.localdomain> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240403034328.GF2576@sol.localdomain> On Tue, Apr 02, 2024 at 08:43:28PM -0700, Eric Biggers wrote: > On Tue, Apr 02, 2024 at 06:48:37PM +0300, Eugen Hristev wrote: > > + ret = generic_ci_match(parent, fname->usr_fname, > > + &fname->cf_name, de->name, > > + de->name_len); > > + if (ret < 0) { > > + /* > > + * Treat comparison errors as not a match. The > > + * only case where it happens is on a disk > > + * corruption or ENOMEM. > > + */ > > + return false; > > } > > - return !ext4_ci_compare(parent, fname->usr_fname, de->name, > > - de->name_len, false); > > + return ret; > > Maybe write this as simply 'return ret > 0;'? Ah, I see that patch 6 adds a check for -EINVAL here, in which case the 'if (ret < 0)' makes sense. - Eric From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 154EFC6FD1F for ; Wed, 3 Apr 2024 04:20:43 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1rrs76-0007uP-OM; Wed, 03 Apr 2024 04:20:41 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rrs75-0007uI-7t for linux-f2fs-devel@lists.sourceforge.net; Wed, 03 Apr 2024 04:20:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=UiEtDgGMda8ZdAXfCbsyJkkWzqImT53vCo9+yby3p8Y=; b=YF4zYQdlqyxoZ4Z8oRrxxT1yvf VZxQ/0Gs6XgYqbMXmV2e4X35f+kr6S5geS4LKFCldg/gikAwogdx+qlB58khiU0+fuh2xf1tndvVH gkb9qB9F0T4FeFHFzg0TkYkOmjGXeDMv8pZRzEZupp1Y98Q3PEmTyvy50aKlXXMTiIb0=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=UiEtDgGMda8ZdAXfCbsyJkkWzqImT53vCo9+yby3p8Y=; b=mSg8tEbkDc+6JbxmwC+ab1TDN4 BFSqrjOyEg4w7v8T0tEEGS7xPKah2vK+vQfNKR8fVDn8yNXVdM6DEWyHJipOf5wfMYBXBEZ4QuEel NajzR2nDQhPIva1rx8fFMT+/lxZT8342rFz1kudKn2wurMosfyj5QtRG2OEgMAlkAQGY=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1rrs74-0000CF-Md for linux-f2fs-devel@lists.sourceforge.net; Wed, 03 Apr 2024 04:20:39 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 9781860DBF; Wed, 3 Apr 2024 04:20:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C99C2C433C7; Wed, 3 Apr 2024 04:20:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712118028; bh=Tcj0j+1YWOxbiPelc6hNIb/Y8mkmLGVcLgWgtH4cpsY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IK3N90/stwO6flnkEFAcjrGv++OvGc5A3+Q3yHAT2MbgfhRpUYiBOsKEnNGNnXCe0 hG6u6J5PsMNsc9UZDdPB/OsTCzD5rXcorEGJlgk/s9S7+EKycsLD+lbQDC2upMc0J7 9JMBbktmK8LLG6nrDCk1mtd1cr5LB16HsyEWb7SRBdjQF/otJ9NoEveRdXWcOkRu5R 2K7C6kdwVKAzBYqvWRb5y+Tg8Fu+b/v8SXQfgxoWCJ518/eTHc4UGwL70AC8Ccs0Ol l36nqpI2SDN1oKatrTeVK4NresoHeE8IEK0lT6oKhAVj/DLfCvKIZOhBoHyEKO71Gu RkAYeVxFHi2jg== Date: Tue, 2 Apr 2024 21:20:26 -0700 From: Eric Biggers To: Eugen Hristev Message-ID: <20240403042026.GG2576@sol.localdomain> References: <20240402154842.508032-1-eugen.hristev@collabora.com> <20240402154842.508032-5-eugen.hristev@collabora.com> <20240403034328.GF2576@sol.localdomain> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240403034328.GF2576@sol.localdomain> X-Headers-End: 1rrs74-0000CF-Md Subject: Re: [f2fs-dev] [PATCH v15 4/9] ext4: Reuse generic_ci_match for ci comparisons X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: krisman@suse.de, brauner@kernel.org, kernel@collabora.com, tytso@mit.edu, jack@suse.cz, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, adilger.kernel@dilger.ca, viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, jaegeuk@kernel.org, linux-ext4@vger.kernel.org, Gabriel Krisman Bertazi Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Tue, Apr 02, 2024 at 08:43:28PM -0700, Eric Biggers wrote: > On Tue, Apr 02, 2024 at 06:48:37PM +0300, Eugen Hristev wrote: > > + ret = generic_ci_match(parent, fname->usr_fname, > > + &fname->cf_name, de->name, > > + de->name_len); > > + if (ret < 0) { > > + /* > > + * Treat comparison errors as not a match. The > > + * only case where it happens is on a disk > > + * corruption or ENOMEM. > > + */ > > + return false; > > } > > - return !ext4_ci_compare(parent, fname->usr_fname, de->name, > > - de->name_len, false); > > + return ret; > > Maybe write this as simply 'return ret > 0;'? Ah, I see that patch 6 adds a check for -EINVAL here, in which case the 'if (ret < 0)' makes sense. - Eric _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel