From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f46.google.com (mail-oa1-f46.google.com [209.85.160.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A5367317E for ; Wed, 3 Apr 2024 09:25:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712136327; cv=none; b=PPfNv+9tOsMgXHo3sqiIfo1yNHlmKlE04kcxhB0po2fa68KRmP9Dwb52Odp9trk2x5a89UA5qUaD5rgPW3EhUmakG34FruUC4DDKwegg+qA0Jv8ss1ODtqYKtpfDGru9w34xJkUdRFLSghYd4xDnD19YG1ot171boRFjjlkeRxc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712136327; c=relaxed/simple; bh=YoRIxI0T1TTf4Vz0hXZqLHz1tclkG7IgkBBUpuKeMJs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=m1B6zotPQ/7B6xatzWcwb+QfufwJN+g6/CrnjmcclD/lTuzBnosfV0uHm1Knd4iqrjcj0li773Ho56UwwikupawtGC/vShxhYGHO51l0U+ho6THX8ZScQEQdqHIcMpK8kvTRmhIPQMr9nkq+VpgTpHKgdnFx6rzSPoIM3VP5LW0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=PmGaad4O; arc=none smtp.client-ip=209.85.160.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PmGaad4O" Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-2228c4c5ac3so3675678fac.0 for ; Wed, 03 Apr 2024 02:25:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712136325; x=1712741125; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=rpFhM8SqXyBu94hYk7CEfVvlLlSK54Yy6BQDmzkvVHs=; b=PmGaad4O/qLxrQUVdlnwvIv5nprJf9RTaWejIBUwbMYjq8egLzXSPRMc2hqd81Aq+b ItqABBYVCRdsVFbyd2kSbyCfpvigmiZT6fYhfOfXL6Cy0qaEuzeFWZoPa+d338MGPL3v zipZCfTXSPCp9lhNxGoIVE+CkVzvpmajN5y/3FmdwYPxQbZ4W0BRg7ZEZ6YvH7SLOt1j 7pnm5IIm0i+bctWigTfowDkhSD4YPjEcwPQ8tqXttHIWpHbYItKHR1P09Qv74XILxMIS Sn97flgeci5/To1yPPn6IBLNpx/KLaFbiJccN57AwVaAay8NLmlnS1vokZLKQidoR97H G2tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712136325; x=1712741125; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rpFhM8SqXyBu94hYk7CEfVvlLlSK54Yy6BQDmzkvVHs=; b=HXH33BLgUyYxKePp5b1Y8MQ7U/4tsvh49LP9biv6LdZs9QS92JLAtVxgQ9f/G4vwk0 qU02XPmm9VR4XIjj3qMeeEmiHpt37x7KJ/nL6N77oXqM17+FYB4sj6oNShxjaDksbad/ l5zpHOJ6xq//9GHjq7v5mk4qzvUXh1NVwf/Wxw7wQm1WnFvMwbmUATm8WsgcwkHF6uLx kk0Moidr3AtrYnB/MxnJvvaT9jnC4BDwPDKMTBqZJ0Us3TzuD2+SizDUaRkbExTXfTXu PPZyq77/T0DvF7qwD2RCGbD3AiunKIFlymi5M2RAzogcnBnbC+517yUqhVoIzo/KHVfx zDCQ== X-Forwarded-Encrypted: i=1; AJvYcCVmvLlvO0Bt9PtPocpWxTrbhpPOECmiaqNd3F/R923hN2ZNTkyic2Ylp4Dw9QRiuO/H+NHU5tFejuh8zJlq/l0znL7vyO8yWt10 X-Gm-Message-State: AOJu0Yw6grSzcdS38TSMBe0HRB9EhS0bEj7vPRc1jbwhrTXhb9FqZcz6 718/NP55UkSLqtns+P2mHDdZJ2Ca64COHGhilYLurKtyQkNxg9k7hF5ffJ798Q== X-Google-Smtp-Source: AGHT+IFACkuRVnBA2XXRimm7ghfL1FGbrX9cbZUJ2UEvfTWLcQUIWAhUSwegdo/x91KpBnylAMFTpQ== X-Received: by 2002:a05:6870:e6c8:b0:22a:4c6a:39ea with SMTP id s8-20020a056870e6c800b0022a4c6a39eamr2423701oak.14.1712136324914; Wed, 03 Apr 2024 02:25:24 -0700 (PDT) Received: from thinkpad ([103.28.246.48]) by smtp.gmail.com with ESMTPSA id k8-20020aa78208000000b006eaad01817esm11345067pfi.105.2024.04.03.02.25.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Apr 2024 02:25:24 -0700 (PDT) Date: Wed, 3 Apr 2024 14:55:17 +0530 From: Manivannan Sadhasivam To: Damien Le Moal Cc: Lorenzo Pieralisi , Kishon Vijay Abraham I , Shawn Lin , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Heiko Stuebner , linux-pci@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Rick Wertenbroek , Wilfred Mallawa , Niklas Cassel Subject: Re: [PATCH v2 00/18] Improve PCI memory mapping API Message-ID: <20240403092517.GH25309@thinkpad> References: <20240330041928.1555578-1-dlemoal@kernel.org> <20240403075034.GF25309@thinkpad> <2cdc7045-e277-4d1f-ad7c-66e4ac819a41@kernel.org> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2cdc7045-e277-4d1f-ad7c-66e4ac819a41@kernel.org> On Wed, Apr 03, 2024 at 04:58:42PM +0900, Damien Le Moal wrote: > On 4/3/24 16:50, Manivannan Sadhasivam wrote: > > On Sat, Mar 30, 2024 at 01:19:10PM +0900, Damien Le Moal wrote: > >> This series introduces the new functions pci_epc_map_align(), > >> pci_epc_mem_map() and pci_epc_mem_unmap() to improve handling of the > >> PCI address mapping alignment constraints of endpoint controllers in a > >> controller independent manner. > >> > >> The issue fixed is that the fixed alignment defined by the "align" field > >> of struct pci_epc_features assumes that the alignment of the endpoint > >> memory used to map a RC PCI address range is independent of the PCI > >> address being mapped. But that is not the case for the rk3399 SoC > >> controller: in endpoint mode, this controller uses the lower bits of the > >> local endpoint memory address as the lower bits for the PCI addresses > >> for data transfers. That is, when mapping local memory, one must take > >> into account the number of bits of the RC PCI address that change from > >> the start address of the mapping. > >> > >> To fix this, the new endpoint controller method .map_align is introduced > >> and called from pci_epc_map_align(). This method is optional and for > >> controllers that do not define it, the mapping information returned > >> is based of the fixed alignment constraint as defined by the align > >> feature. > >> > >> The functions pci_epc_mem_map() is a helper function which obtains > >> mapping information, allocates endpoint controller memory according to > >> the mapping size obtained and maps the memory. pci_epc_mem_map() unmaps > >> and frees the endpoint memory. > >> > >> This series is organized as follows: > >> - Patch 1 tidy up the epc core code > >> - Patch 2 and 3 introduce the new map_align endpoint controller method > >> and related epc functions. > >> - Patch 4 to 6 modify the test endpoint driver to use these new > >> functions and improve the code of this driver. > > > > While posting the next version, please split the endpoint patches into a > > separate series. It helps in code review and can be applied separately. > > Which patches ? They are all endpoint related: > (1) Core code > (2) test function driver Till patch 6, that's why I inlined my reply at the 3rd point. > (3) rockchip rk3399 controller > > (2) and (3) depend on the patches in (1), so splitting the series is a big > possible only if (1) is applied first, so that is a source of delays and breaks > the context of the patches... > If you split patches 1-6 and post the rest of the Rockchip patches as a follow up, it perfectly makes sense. - Mani -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5EACFCD1288 for ; Wed, 3 Apr 2024 09:25:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=woQp2o5vAP/aPr0/xUKJhDIHmd2yOx88yqH7tdXHehM=; b=ORGGFi7qIhN0QI 01/h2mOroOvXtHdNy1QWULdwzWvv/ygXqiAn4pYuwUVX4DSG/F7CfjJyozpbVnhoIiZt4vd0JuHRS 3ntslXRHWrt/UKtvHxniumtfvzxXn5XVlI57Oj1Y288nqHltAx+tE+cTyqSmZ3VBL6zNjWoFNeo6U snm2QgJIxBuYCzCKaj51O4/j6DloITfAlpUUrujQSDaOU1IhCfa5rwaj0ZGgIAkSZvt7dDG9sTewn vTpXmHTtyotsq9jNrQNbmoB998mtMCx9Om/uxpMtdwSidpkIHoJDSOxo0TrklN1lNKLjpHl+rPl4g tLd1o/NB9I0v3UFgwQtQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrws6-0000000FCfM-1rNd; Wed, 03 Apr 2024 09:25:30 +0000 Received: from mail-oa1-x31.google.com ([2001:4860:4864:20::31]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrws3-0000000FCco-0PEN for linux-rockchip@lists.infradead.org; Wed, 03 Apr 2024 09:25:28 +0000 Received: by mail-oa1-x31.google.com with SMTP id 586e51a60fabf-221e6bf537dso3996293fac.1 for ; Wed, 03 Apr 2024 02:25:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712136325; x=1712741125; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=rpFhM8SqXyBu94hYk7CEfVvlLlSK54Yy6BQDmzkvVHs=; b=GgtxLkVPDWlkVYH9QvLLKNWqBruDm/SDahCcZHArRqzjHOC2fHQrEBgR3S9rnMMCiQ eLD91V+bFirF70+NG5AfeOMsSAPwM8LSYOdXa3m5NoR6d3+A/se8pDT4SJh1VIYKeBaz IOX1MDwvEoLMA9N0bEHW3vo4ljKxc6yd5GO6DBAsXiPECpuIHa2ppHYoAeY5xEF6z0jl mUAtfQ6ZpHQy1VkpZg76lOksiuK18lSvV6hJXdbA7GyngVhTFihc8YlK5X1s06+vp56/ gO7cZV7sgLWj4HBXoQNX3lE5k+8HOy2FZPMRNtGsbrF9T3El1egc/Ccal3FKK+x49kE8 9N9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712136325; x=1712741125; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rpFhM8SqXyBu94hYk7CEfVvlLlSK54Yy6BQDmzkvVHs=; b=KcFYVR6rqU7VCQYARqNFP6cVisH0iKQWbSPw9FpbQcK21obJxJLw837Gwo7ZwuxkPi hxqvHGbVqb/0hrWSxuMMaH8mdWraltUJoOtoaR3oCO49GKoR4NqPYX9/z0sEVvtGk9D5 1OfoSnhnTRgJyWjtAtS7TBnEnoEcBo+FLG4JCd5J9wmLQzuJSVa3SJri4fRxQtpZgEvB TrZRPsMtnZYklRGseTGSmuPjN4k/iw0eVT7aR18ThaX3oEpQx3W0xGypp16eD5KG3+M3 lYC1f6XCBW00StwIfH1M/qpNL3KsuKS3psw9B+e1nQigB1pEaITH7E9zWKEMH2MQZKa8 QJvQ== X-Forwarded-Encrypted: i=1; AJvYcCWHtPDTIEOpL7wrZBS6Bu0pSQ6Gh4Fkfw32ytj4IuBJdkp1KTOSfCbeHgwyezJWqURymEJZOE2EQUTTrILihD0NxwgCvBRt/oNWrg+mdT/fbHt9 X-Gm-Message-State: AOJu0YwUd8BSXfr5LpcHlPa6Px2w7zUkxP5I6WlqU3nJl/RYwVfYFwZV EcL7y0obBLvwqyF8xdfb2bH4f+s+ZAyB9yvzhXw47EaDR5V8eec/1DnT0qZJZg== X-Google-Smtp-Source: AGHT+IFACkuRVnBA2XXRimm7ghfL1FGbrX9cbZUJ2UEvfTWLcQUIWAhUSwegdo/x91KpBnylAMFTpQ== X-Received: by 2002:a05:6870:e6c8:b0:22a:4c6a:39ea with SMTP id s8-20020a056870e6c800b0022a4c6a39eamr2423701oak.14.1712136324914; Wed, 03 Apr 2024 02:25:24 -0700 (PDT) Received: from thinkpad ([103.28.246.48]) by smtp.gmail.com with ESMTPSA id k8-20020aa78208000000b006eaad01817esm11345067pfi.105.2024.04.03.02.25.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Apr 2024 02:25:24 -0700 (PDT) Date: Wed, 3 Apr 2024 14:55:17 +0530 From: Manivannan Sadhasivam To: Damien Le Moal Cc: Lorenzo Pieralisi , Kishon Vijay Abraham I , Shawn Lin , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Heiko Stuebner , linux-pci@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Rick Wertenbroek , Wilfred Mallawa , Niklas Cassel Subject: Re: [PATCH v2 00/18] Improve PCI memory mapping API Message-ID: <20240403092517.GH25309@thinkpad> References: <20240330041928.1555578-1-dlemoal@kernel.org> <20240403075034.GF25309@thinkpad> <2cdc7045-e277-4d1f-ad7c-66e4ac819a41@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2cdc7045-e277-4d1f-ad7c-66e4ac819a41@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240403_022527_194885_A06477E4 X-CRM114-Status: GOOD ( 28.77 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org T24gV2VkLCBBcHIgMDMsIDIwMjQgYXQgMDQ6NTg6NDJQTSArMDkwMCwgRGFtaWVuIExlIE1vYWwg d3JvdGU6Cj4gT24gNC8zLzI0IDE2OjUwLCBNYW5pdmFubmFuIFNhZGhhc2l2YW0gd3JvdGU6Cj4g PiBPbiBTYXQsIE1hciAzMCwgMjAyNCBhdCAwMToxOToxMFBNICswOTAwLCBEYW1pZW4gTGUgTW9h bCB3cm90ZToKPiA+PiBUaGlzIHNlcmllcyBpbnRyb2R1Y2VzIHRoZSBuZXcgZnVuY3Rpb25zIHBj aV9lcGNfbWFwX2FsaWduKCksCj4gPj4gcGNpX2VwY19tZW1fbWFwKCkgYW5kIHBjaV9lcGNfbWVt X3VubWFwKCkgdG8gaW1wcm92ZSBoYW5kbGluZyBvZiB0aGUKPiA+PiBQQ0kgYWRkcmVzcyBtYXBw aW5nIGFsaWdubWVudCBjb25zdHJhaW50cyBvZiBlbmRwb2ludCBjb250cm9sbGVycyBpbiBhCj4g Pj4gY29udHJvbGxlciBpbmRlcGVuZGVudCBtYW5uZXIuCj4gPj4KPiA+PiBUaGUgaXNzdWUgZml4 ZWQgaXMgdGhhdCB0aGUgZml4ZWQgYWxpZ25tZW50IGRlZmluZWQgYnkgdGhlICJhbGlnbiIgZmll bGQKPiA+PiBvZiBzdHJ1Y3QgcGNpX2VwY19mZWF0dXJlcyBhc3N1bWVzIHRoYXQgdGhlIGFsaWdu bWVudCBvZiB0aGUgZW5kcG9pbnQKPiA+PiBtZW1vcnkgdXNlZCB0byBtYXAgYSBSQyBQQ0kgYWRk cmVzcyByYW5nZSBpcyBpbmRlcGVuZGVudCBvZiB0aGUgUENJCj4gPj4gYWRkcmVzcyBiZWluZyBt YXBwZWQuIEJ1dCB0aGF0IGlzIG5vdCB0aGUgY2FzZSBmb3IgdGhlIHJrMzM5OSBTb0MKPiA+PiBj b250cm9sbGVyOiBpbiBlbmRwb2ludCBtb2RlLCB0aGlzIGNvbnRyb2xsZXIgdXNlcyB0aGUgbG93 ZXIgYml0cyBvZiB0aGUKPiA+PiBsb2NhbCBlbmRwb2ludCBtZW1vcnkgYWRkcmVzcyBhcyB0aGUg bG93ZXIgYml0cyBmb3IgdGhlIFBDSSBhZGRyZXNzZXMKPiA+PiBmb3IgZGF0YSB0cmFuc2ZlcnMu IFRoYXQgaXMsIHdoZW4gbWFwcGluZyBsb2NhbCBtZW1vcnksIG9uZSBtdXN0IHRha2UKPiA+PiBp bnRvIGFjY291bnQgdGhlIG51bWJlciBvZiBiaXRzIG9mIHRoZSBSQyBQQ0kgYWRkcmVzcyB0aGF0 IGNoYW5nZSBmcm9tCj4gPj4gdGhlIHN0YXJ0IGFkZHJlc3Mgb2YgdGhlIG1hcHBpbmcuCj4gPj4K PiA+PiBUbyBmaXggdGhpcywgdGhlIG5ldyBlbmRwb2ludCBjb250cm9sbGVyIG1ldGhvZCAubWFw X2FsaWduIGlzIGludHJvZHVjZWQKPiA+PiBhbmQgY2FsbGVkIGZyb20gcGNpX2VwY19tYXBfYWxp Z24oKS4gVGhpcyBtZXRob2QgaXMgb3B0aW9uYWwgYW5kIGZvcgo+ID4+IGNvbnRyb2xsZXJzIHRo YXQgZG8gbm90IGRlZmluZSBpdCwgdGhlIG1hcHBpbmcgaW5mb3JtYXRpb24gcmV0dXJuZWQKPiA+ PiBpcyBiYXNlZCBvZiB0aGUgZml4ZWQgYWxpZ25tZW50IGNvbnN0cmFpbnQgYXMgZGVmaW5lZCBi eSB0aGUgYWxpZ24KPiA+PiBmZWF0dXJlLgo+ID4+Cj4gPj4gVGhlIGZ1bmN0aW9ucyBwY2lfZXBj X21lbV9tYXAoKSBpcyBhIGhlbHBlciBmdW5jdGlvbiB3aGljaCBvYnRhaW5zCj4gPj4gbWFwcGlu ZyBpbmZvcm1hdGlvbiwgYWxsb2NhdGVzIGVuZHBvaW50IGNvbnRyb2xsZXIgbWVtb3J5IGFjY29y ZGluZyB0bwo+ID4+IHRoZSBtYXBwaW5nIHNpemUgb2J0YWluZWQgYW5kIG1hcHMgdGhlIG1lbW9y eS4gcGNpX2VwY19tZW1fbWFwKCkgdW5tYXBzCj4gPj4gYW5kIGZyZWVzIHRoZSBlbmRwb2ludCBt ZW1vcnkuCj4gPj4KPiA+PiBUaGlzIHNlcmllcyBpcyBvcmdhbml6ZWQgYXMgZm9sbG93czoKPiA+ PiAgLSBQYXRjaCAxIHRpZHkgdXAgdGhlIGVwYyBjb3JlIGNvZGUKPiA+PiAgLSBQYXRjaCAyIGFu ZCAzIGludHJvZHVjZSB0aGUgbmV3IG1hcF9hbGlnbiBlbmRwb2ludCBjb250cm9sbGVyIG1ldGhv ZAo+ID4+ICAgIGFuZCByZWxhdGVkIGVwYyBmdW5jdGlvbnMuCj4gPj4gIC0gUGF0Y2ggNCB0byA2 IG1vZGlmeSB0aGUgdGVzdCBlbmRwb2ludCBkcml2ZXIgdG8gdXNlIHRoZXNlIG5ldwo+ID4+ICAg IGZ1bmN0aW9ucyBhbmQgaW1wcm92ZSB0aGUgY29kZSBvZiB0aGlzIGRyaXZlci4KPiA+IAo+ID4g V2hpbGUgcG9zdGluZyB0aGUgbmV4dCB2ZXJzaW9uLCBwbGVhc2Ugc3BsaXQgdGhlIGVuZHBvaW50 IHBhdGNoZXMgaW50byBhCj4gPiBzZXBhcmF0ZSBzZXJpZXMuIEl0IGhlbHBzIGluIGNvZGUgcmV2 aWV3IGFuZCBjYW4gYmUgYXBwbGllZCBzZXBhcmF0ZWx5Lgo+IAo+IFdoaWNoIHBhdGNoZXMgPyBU aGV5IGFyZSBhbGwgZW5kcG9pbnQgcmVsYXRlZDoKPiAgKDEpIENvcmUgY29kZQo+ICAoMikgdGVz dCBmdW5jdGlvbiBkcml2ZXIKClRpbGwgcGF0Y2ggNiwgdGhhdCdzIHdoeSBJIGlubGluZWQgbXkg cmVwbHkgYXQgdGhlIDNyZCBwb2ludC4KCj4gICgzKSByb2NrY2hpcCByazMzOTkgY29udHJvbGxl cgo+IAo+ICgyKSBhbmQgKDMpIGRlcGVuZCBvbiB0aGUgcGF0Y2hlcyBpbiAoMSksIHNvIHNwbGl0 dGluZyB0aGUgc2VyaWVzIGlzIGEgYmlnCj4gcG9zc2libGUgb25seSBpZiAoMSkgaXMgYXBwbGll ZCBmaXJzdCwgc28gdGhhdCBpcyBhIHNvdXJjZSBvZiBkZWxheXMgYW5kIGJyZWFrcwo+IHRoZSBj b250ZXh0IG9mIHRoZSBwYXRjaGVzLi4uCj4gCgpJZiB5b3Ugc3BsaXQgcGF0Y2hlcyAxLTYgYW5k IHBvc3QgdGhlIHJlc3Qgb2YgdGhlIFJvY2tjaGlwIHBhdGNoZXMgYXMgYSBmb2xsb3cKdXAsIGl0 IHBlcmZlY3RseSBtYWtlcyBzZW5zZS4KCi0gTWFuaQoKLS0gCuCuruCuo+Cuv+CuteCuo+CvjeCu o+CuqeCvjSDgrprgrqTgrr7grprgrr/grrXgrq7gr40KCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdApMaW51 eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L21haWxtYW4vbGlzdGluZm8vbGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 70883CD1294 for ; Wed, 3 Apr 2024 09:25:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qzZQI6l0mOejnBjPR/KNYb9nUXuYumCKJMMpW/VtGFE=; b=zc7cKS0GmPKGgN fDmWhuv1OvhgN/WWKs3dGMihzhqA3MhYp7JEpgWngG6xkQ7K6PjkVf2NcwhBSmwtLk3xaQgMQ87M/ QDDfe04QdmIKKRNq7HAFBGiT1qZTtsvC8E2fkohzX+9HpWFu8o8fXAsNFxIQMKzVHOhZXwTYWQSSO xTv1RDDNXDKU+jTvIETgfo7cvBOMtn+R7ZyLczUZcMux2hmLvA0pOpJAA0gbvDDIuqjgWonsU9DiO XnTLNqg1etD0MmmxsmpOBkq+y4Ft7EpzkFi/2tuk1JMf1KLw+GCpZ5untRlkJQqxWz9o2JpRLbsMZ b7gVfQhGRZ1Il/l3FAJw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrws7-0000000FCfc-02xM; Wed, 03 Apr 2024 09:25:31 +0000 Received: from mail-oa1-x30.google.com ([2001:4860:4864:20::30]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrws3-0000000FCcp-0Pmg for linux-arm-kernel@lists.infradead.org; Wed, 03 Apr 2024 09:25:28 +0000 Received: by mail-oa1-x30.google.com with SMTP id 586e51a60fabf-22e7444c5a0so756218fac.2 for ; Wed, 03 Apr 2024 02:25:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712136325; x=1712741125; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=rpFhM8SqXyBu94hYk7CEfVvlLlSK54Yy6BQDmzkvVHs=; b=GgtxLkVPDWlkVYH9QvLLKNWqBruDm/SDahCcZHArRqzjHOC2fHQrEBgR3S9rnMMCiQ eLD91V+bFirF70+NG5AfeOMsSAPwM8LSYOdXa3m5NoR6d3+A/se8pDT4SJh1VIYKeBaz IOX1MDwvEoLMA9N0bEHW3vo4ljKxc6yd5GO6DBAsXiPECpuIHa2ppHYoAeY5xEF6z0jl mUAtfQ6ZpHQy1VkpZg76lOksiuK18lSvV6hJXdbA7GyngVhTFihc8YlK5X1s06+vp56/ gO7cZV7sgLWj4HBXoQNX3lE5k+8HOy2FZPMRNtGsbrF9T3El1egc/Ccal3FKK+x49kE8 9N9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712136325; x=1712741125; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rpFhM8SqXyBu94hYk7CEfVvlLlSK54Yy6BQDmzkvVHs=; b=aQ8mSXYYGp0loZnApsspGG46UcVpQYPScv4CVBzv0diBofjZw1nqPngTbsVYlmeapA XMyhPR/h9ApsfNRwLXjCv+/uEGq+yfpZaQWuLOQnYfw9iGOzpJpj283pcyklh4gcxX0C El/ohE+7EWuRWNa9HPdQeuOPjzj3Hny1hDSB9EZUKP7mDxwJ23GBICMK51bv7cqhBYif /I78VBHSq0NZ9LBBY4tvTkjCh7sN3p45fdfKJz49g/j1QhHQOhKDWc8CsgASDNIxlW+O UJwZmCyqz1GTXJwqhItfPVZk4u3QFBGALSdq9DMWpFhbtx/4BKVuK5pOk9LmW3NwbTDx LA/Q== X-Forwarded-Encrypted: i=1; AJvYcCXi2Z3eneBgOe8YjJJ3teGV6fYbzNwB9AwzSS9mm4pBEcRCFnhcZfaa4BO1EbIFMxgwo9QBlJYYob8SMFvO9ztkw13dqv/SHHI/HNjonRMubEZiIcw= X-Gm-Message-State: AOJu0YzhhNbarxR3bF0Eof7OCv+D+uvEETHY/ZH1Jo88QZngOiCf5iAO AzjMebEXB0MEgWQNmWFJMj0p6O4kpvWEaVoeowIqzQ1brHlf5WBCgpEX6D/NsQ== X-Google-Smtp-Source: AGHT+IFACkuRVnBA2XXRimm7ghfL1FGbrX9cbZUJ2UEvfTWLcQUIWAhUSwegdo/x91KpBnylAMFTpQ== X-Received: by 2002:a05:6870:e6c8:b0:22a:4c6a:39ea with SMTP id s8-20020a056870e6c800b0022a4c6a39eamr2423701oak.14.1712136324914; Wed, 03 Apr 2024 02:25:24 -0700 (PDT) Received: from thinkpad ([103.28.246.48]) by smtp.gmail.com with ESMTPSA id k8-20020aa78208000000b006eaad01817esm11345067pfi.105.2024.04.03.02.25.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Apr 2024 02:25:24 -0700 (PDT) Date: Wed, 3 Apr 2024 14:55:17 +0530 From: Manivannan Sadhasivam To: Damien Le Moal Cc: Lorenzo Pieralisi , Kishon Vijay Abraham I , Shawn Lin , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Heiko Stuebner , linux-pci@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Rick Wertenbroek , Wilfred Mallawa , Niklas Cassel Subject: Re: [PATCH v2 00/18] Improve PCI memory mapping API Message-ID: <20240403092517.GH25309@thinkpad> References: <20240330041928.1555578-1-dlemoal@kernel.org> <20240403075034.GF25309@thinkpad> <2cdc7045-e277-4d1f-ad7c-66e4ac819a41@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2cdc7045-e277-4d1f-ad7c-66e4ac819a41@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240403_022527_177076_F06BFA44 X-CRM114-Status: GOOD ( 30.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBBcHIgMDMsIDIwMjQgYXQgMDQ6NTg6NDJQTSArMDkwMCwgRGFtaWVuIExlIE1vYWwg d3JvdGU6Cj4gT24gNC8zLzI0IDE2OjUwLCBNYW5pdmFubmFuIFNhZGhhc2l2YW0gd3JvdGU6Cj4g PiBPbiBTYXQsIE1hciAzMCwgMjAyNCBhdCAwMToxOToxMFBNICswOTAwLCBEYW1pZW4gTGUgTW9h bCB3cm90ZToKPiA+PiBUaGlzIHNlcmllcyBpbnRyb2R1Y2VzIHRoZSBuZXcgZnVuY3Rpb25zIHBj aV9lcGNfbWFwX2FsaWduKCksCj4gPj4gcGNpX2VwY19tZW1fbWFwKCkgYW5kIHBjaV9lcGNfbWVt X3VubWFwKCkgdG8gaW1wcm92ZSBoYW5kbGluZyBvZiB0aGUKPiA+PiBQQ0kgYWRkcmVzcyBtYXBw aW5nIGFsaWdubWVudCBjb25zdHJhaW50cyBvZiBlbmRwb2ludCBjb250cm9sbGVycyBpbiBhCj4g Pj4gY29udHJvbGxlciBpbmRlcGVuZGVudCBtYW5uZXIuCj4gPj4KPiA+PiBUaGUgaXNzdWUgZml4 ZWQgaXMgdGhhdCB0aGUgZml4ZWQgYWxpZ25tZW50IGRlZmluZWQgYnkgdGhlICJhbGlnbiIgZmll bGQKPiA+PiBvZiBzdHJ1Y3QgcGNpX2VwY19mZWF0dXJlcyBhc3N1bWVzIHRoYXQgdGhlIGFsaWdu bWVudCBvZiB0aGUgZW5kcG9pbnQKPiA+PiBtZW1vcnkgdXNlZCB0byBtYXAgYSBSQyBQQ0kgYWRk cmVzcyByYW5nZSBpcyBpbmRlcGVuZGVudCBvZiB0aGUgUENJCj4gPj4gYWRkcmVzcyBiZWluZyBt YXBwZWQuIEJ1dCB0aGF0IGlzIG5vdCB0aGUgY2FzZSBmb3IgdGhlIHJrMzM5OSBTb0MKPiA+PiBj b250cm9sbGVyOiBpbiBlbmRwb2ludCBtb2RlLCB0aGlzIGNvbnRyb2xsZXIgdXNlcyB0aGUgbG93 ZXIgYml0cyBvZiB0aGUKPiA+PiBsb2NhbCBlbmRwb2ludCBtZW1vcnkgYWRkcmVzcyBhcyB0aGUg bG93ZXIgYml0cyBmb3IgdGhlIFBDSSBhZGRyZXNzZXMKPiA+PiBmb3IgZGF0YSB0cmFuc2ZlcnMu IFRoYXQgaXMsIHdoZW4gbWFwcGluZyBsb2NhbCBtZW1vcnksIG9uZSBtdXN0IHRha2UKPiA+PiBp bnRvIGFjY291bnQgdGhlIG51bWJlciBvZiBiaXRzIG9mIHRoZSBSQyBQQ0kgYWRkcmVzcyB0aGF0 IGNoYW5nZSBmcm9tCj4gPj4gdGhlIHN0YXJ0IGFkZHJlc3Mgb2YgdGhlIG1hcHBpbmcuCj4gPj4K PiA+PiBUbyBmaXggdGhpcywgdGhlIG5ldyBlbmRwb2ludCBjb250cm9sbGVyIG1ldGhvZCAubWFw X2FsaWduIGlzIGludHJvZHVjZWQKPiA+PiBhbmQgY2FsbGVkIGZyb20gcGNpX2VwY19tYXBfYWxp Z24oKS4gVGhpcyBtZXRob2QgaXMgb3B0aW9uYWwgYW5kIGZvcgo+ID4+IGNvbnRyb2xsZXJzIHRo YXQgZG8gbm90IGRlZmluZSBpdCwgdGhlIG1hcHBpbmcgaW5mb3JtYXRpb24gcmV0dXJuZWQKPiA+ PiBpcyBiYXNlZCBvZiB0aGUgZml4ZWQgYWxpZ25tZW50IGNvbnN0cmFpbnQgYXMgZGVmaW5lZCBi eSB0aGUgYWxpZ24KPiA+PiBmZWF0dXJlLgo+ID4+Cj4gPj4gVGhlIGZ1bmN0aW9ucyBwY2lfZXBj X21lbV9tYXAoKSBpcyBhIGhlbHBlciBmdW5jdGlvbiB3aGljaCBvYnRhaW5zCj4gPj4gbWFwcGlu ZyBpbmZvcm1hdGlvbiwgYWxsb2NhdGVzIGVuZHBvaW50IGNvbnRyb2xsZXIgbWVtb3J5IGFjY29y ZGluZyB0bwo+ID4+IHRoZSBtYXBwaW5nIHNpemUgb2J0YWluZWQgYW5kIG1hcHMgdGhlIG1lbW9y eS4gcGNpX2VwY19tZW1fbWFwKCkgdW5tYXBzCj4gPj4gYW5kIGZyZWVzIHRoZSBlbmRwb2ludCBt ZW1vcnkuCj4gPj4KPiA+PiBUaGlzIHNlcmllcyBpcyBvcmdhbml6ZWQgYXMgZm9sbG93czoKPiA+ PiAgLSBQYXRjaCAxIHRpZHkgdXAgdGhlIGVwYyBjb3JlIGNvZGUKPiA+PiAgLSBQYXRjaCAyIGFu ZCAzIGludHJvZHVjZSB0aGUgbmV3IG1hcF9hbGlnbiBlbmRwb2ludCBjb250cm9sbGVyIG1ldGhv ZAo+ID4+ICAgIGFuZCByZWxhdGVkIGVwYyBmdW5jdGlvbnMuCj4gPj4gIC0gUGF0Y2ggNCB0byA2 IG1vZGlmeSB0aGUgdGVzdCBlbmRwb2ludCBkcml2ZXIgdG8gdXNlIHRoZXNlIG5ldwo+ID4+ICAg IGZ1bmN0aW9ucyBhbmQgaW1wcm92ZSB0aGUgY29kZSBvZiB0aGlzIGRyaXZlci4KPiA+IAo+ID4g V2hpbGUgcG9zdGluZyB0aGUgbmV4dCB2ZXJzaW9uLCBwbGVhc2Ugc3BsaXQgdGhlIGVuZHBvaW50 IHBhdGNoZXMgaW50byBhCj4gPiBzZXBhcmF0ZSBzZXJpZXMuIEl0IGhlbHBzIGluIGNvZGUgcmV2 aWV3IGFuZCBjYW4gYmUgYXBwbGllZCBzZXBhcmF0ZWx5Lgo+IAo+IFdoaWNoIHBhdGNoZXMgPyBU aGV5IGFyZSBhbGwgZW5kcG9pbnQgcmVsYXRlZDoKPiAgKDEpIENvcmUgY29kZQo+ICAoMikgdGVz dCBmdW5jdGlvbiBkcml2ZXIKClRpbGwgcGF0Y2ggNiwgdGhhdCdzIHdoeSBJIGlubGluZWQgbXkg cmVwbHkgYXQgdGhlIDNyZCBwb2ludC4KCj4gICgzKSByb2NrY2hpcCByazMzOTkgY29udHJvbGxl cgo+IAo+ICgyKSBhbmQgKDMpIGRlcGVuZCBvbiB0aGUgcGF0Y2hlcyBpbiAoMSksIHNvIHNwbGl0 dGluZyB0aGUgc2VyaWVzIGlzIGEgYmlnCj4gcG9zc2libGUgb25seSBpZiAoMSkgaXMgYXBwbGll ZCBmaXJzdCwgc28gdGhhdCBpcyBhIHNvdXJjZSBvZiBkZWxheXMgYW5kIGJyZWFrcwo+IHRoZSBj b250ZXh0IG9mIHRoZSBwYXRjaGVzLi4uCj4gCgpJZiB5b3Ugc3BsaXQgcGF0Y2hlcyAxLTYgYW5k IHBvc3QgdGhlIHJlc3Qgb2YgdGhlIFJvY2tjaGlwIHBhdGNoZXMgYXMgYSBmb2xsb3cKdXAsIGl0 IHBlcmZlY3RseSBtYWtlcyBzZW5zZS4KCi0gTWFuaQoKLS0gCuCuruCuo+Cuv+CuteCuo+CvjeCu o+CuqeCvjSDgrprgrqTgrr7grprgrr/grrXgrq7gr40KCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0Cmxp bnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFk Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK