From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f41.google.com (mail-io1-f41.google.com [209.85.166.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B77211353E4 for ; Wed, 3 Apr 2024 09:48:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712137729; cv=none; b=g5Cuy7h6Tp/3AeZFxOBAKQWB54aZ4zIzVDCitg6uyJ3AVyPeGykt1Pf0Is+avzARkzlcCf88cvGe0KfKqA0/bSKEjiywwRceWW02oXXoQcADM8j+kJe5KrA2OUbsheNynMwoDVK8HdqmPlQ+h+9Yb46xRGyVFP21EH0rltsG++A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712137729; c=relaxed/simple; bh=VZVjk4Lg+32DYX1V0hHFzAoXwy2zWj8ikBfocb2aiao=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jNGoyB1C/YwLfWlDVjehR/neV+Qo52Cn0styM7MFaLubd/iB3u13c42vwQecjVUe3LgcL72FnN7y+ylKIgQqW2Jn/HUwK+r6cfU7UxNoQ60rk9P7evSQGQVDWGHOdkTQ8nnDphQri5xtrIOS5Srb9CsI47woV+UtxWIgHICpyrE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=mHJDPhfQ; arc=none smtp.client-ip=209.85.166.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mHJDPhfQ" Received: by mail-io1-f41.google.com with SMTP id ca18e2360f4ac-7d0262036afso314511439f.3 for ; Wed, 03 Apr 2024 02:48:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712137727; x=1712742527; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=EPXFh7gsPyAU+iXcewtYZIELGdFkMytovmlJfVGNhNo=; b=mHJDPhfQel320iBKatX5c98HlzL0+RusBU927Aguf3ZWD+PLIChNO0C0bIGBtxi1e0 7WsKbKV/pcnU9+iPPiW/33xY1+aCbBoh3bp2iC0n9IBoPx8kqk/xiEDpZVJbDGQjfZyG gZheo0KYEG6HoQMe9yrzBn+6nrBDhN1myjir+nGtNXMilN4Dmpzh9i21/rf5Ybsm5GQ5 aSNMLLtoMMqX4EO/8n1+wOCfu77mKzil+54g9QiG+RUUAqSyYerhe8TmXymrcWezwAtr O/d7K5/eQYZJOMLd2LVmT0dWWRjTTFbimtD7OyKVuSIVUsCnDKOYGDLI3Ld8Wv4qZ6jz Talg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712137727; x=1712742527; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EPXFh7gsPyAU+iXcewtYZIELGdFkMytovmlJfVGNhNo=; b=mNPzFAKYf60WnIb1luAX3XnAXiNAmPruPVCnLz5FbhYIGs02pNEb/JKE6Oo3qlbpSp NI1rAxmuxU1B+DJI7kpIJ4Sc95NX0Be962oG3i0MEGO57tCDhmwXTdteFj3uefBkf1xk 3C+RGv3TDsVqyjmPBxzDqGC2esd1C00U7auqaIz3NArqepJ8Gdq2WxhGiUtP1UFimyyr fVA16lAcPLUGCNR3s7x7p4h1ohH3cBFzYN6KMrF+aLCXtXCJ8F3G9Yl2JQuP3vgcPi7a oVKd363X2dgJQlNgCQ+Oo0euU129NGuuGE91k9DBWbnE4aGDvXTp267w/2IiPAyTi7Ul hyTA== X-Forwarded-Encrypted: i=1; AJvYcCXeLNqWFwQh3+yvQ9MyGqcWvgG5QQnBvtEYB5voyeJbsgh1gB41ecGRalb+YDe2pCF136ve6Mm01IbuENZSNOtbkMXp4+Is1Wgt X-Gm-Message-State: AOJu0YxFhTd5YetIgtEojAyVD/qnx8Eg5ZVJMBBrxVKo81J/h4sjDLSh velK5ZFyv1FRBJwlhZu0oeNiFShwKZ9rEO9cAxzv+HbIyvphY1zoTtxW+FMecg== X-Google-Smtp-Source: AGHT+IEbUkv1YVum64pYJ7p3hjvBN8WVLeTTz4TjDHu3j5DUSh/cjz4maB41kqZEWFfHUMT1vj9VFA== X-Received: by 2002:a05:6e02:1c08:b0:369:efba:71c1 with SMTP id l8-20020a056e021c0800b00369efba71c1mr1638352ilh.16.1712137726677; Wed, 03 Apr 2024 02:48:46 -0700 (PDT) Received: from thinkpad ([103.28.246.48]) by smtp.gmail.com with ESMTPSA id d21-20020a634f15000000b005dbd0facb4dsm10931377pgb.61.2024.04.03.02.48.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Apr 2024 02:48:46 -0700 (PDT) Date: Wed, 3 Apr 2024 15:18:40 +0530 From: Manivannan Sadhasivam To: Damien Le Moal Cc: Lorenzo Pieralisi , Kishon Vijay Abraham I , Shawn Lin , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Heiko Stuebner , linux-pci@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Rick Wertenbroek , Wilfred Mallawa , Niklas Cassel Subject: Re: [PATCH v2 03/18] PCI: endpoint: Introduce pci_epc_mem_map()/unmap() Message-ID: <20240403094840.GI25309@thinkpad> References: <20240330041928.1555578-1-dlemoal@kernel.org> <20240330041928.1555578-4-dlemoal@kernel.org> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240330041928.1555578-4-dlemoal@kernel.org> On Sat, Mar 30, 2024 at 01:19:13PM +0900, Damien Le Moal wrote: > Introduce the function pci_epc_mem_map() to facilitate controller memory > address allocation and mapping to a RC PCI address region in endpoint > function drivers. > > This function first uses pci_epc_map_align() to determine the controller > memory address alignment (offset and size) constraints. The result of > this function is used to allocate a controller physical memory region > using pci_epc_mem_alloc_addr() and map it to the RC PCI address > space with pci_epc_map_addr(). Since pci_epc_map_align() may indicate > that a mapping can be smaller than the requested size, pci_epc_mem_map() > may only partially map the RC PCI address region specified and return > a smaller size for the effective mapping. > > The counterpart of pci_epc_mem_map() to unmap and free the controller > memory address region is pci_epc_mem_unmap(). > > Both functions operate using struct pci_epc_map data structure which is > extended to contain the physical and virtual addresses of the allocated > controller memory. Endpoint function drivers can use struct pci_epc_map > to implement read/write accesses within the mapped RC PCI address region > using the ->virt_addr and ->size fields. > > This commit contains contributions from Rick Wertenbroek > . > Adding 'Co-developed-by && Signed-off-by' tags would give the due credit. > Signed-off-by: Damien Le Moal > --- > drivers/pci/endpoint/pci-epc-core.c | 68 +++++++++++++++++++++++++++++ > include/linux/pci-epc.h | 6 +++ > 2 files changed, 74 insertions(+) > > diff --git a/drivers/pci/endpoint/pci-epc-core.c b/drivers/pci/endpoint/pci-epc-core.c > index 37758ca91d7f..0095b54bdf9e 100644 > --- a/drivers/pci/endpoint/pci-epc-core.c > +++ b/drivers/pci/endpoint/pci-epc-core.c > @@ -530,6 +530,74 @@ int pci_epc_map_addr(struct pci_epc *epc, u8 func_no, u8 vfunc_no, > } > EXPORT_SYMBOL_GPL(pci_epc_map_addr); > > +/** > + * pci_epc_mem_map() - allocate and map CPU address to PCI address How about, 'pci_epc_alloc_map()'? I think the 'mem' prefix was added to the existing APIs since the function definitions are in pci-epc-mem driver, but not needed here. > + * @epc: the EPC device on which the CPU address is to be allocated and mapped > + * @func_no: the physical endpoint function number in the EPC device > + * @vfunc_no: the virtual endpoint function number in the physical function > + * @pci_addr: PCI address to which the CPU address should be mapped > + * @size: the number of bytes to map starting from @pci_addr > + * @map: where to return the mapping information > + * > + * Allocate a controller physical address region and map it to a RC PCI address "Allocate an EPC address space region..." > + * region, taking into account the controller physical address mapping > + * constraints (if any). Returns the effective size of the mapping, which may Return value should be specified separately for Kdoc. > + * be less than @size, or a negative error code in case of error. > + */ > +ssize_t pci_epc_mem_map(struct pci_epc *epc, u8 func_no, u8 vfunc_no, > + u64 pci_addr, size_t size, struct pci_epc_map *map) > +{ > + int ret; > + > + ret = pci_epc_map_align(epc, func_no, vfunc_no, pci_addr, size, map); > + if (ret) > + return ret; > + > + map->virt_base = pci_epc_mem_alloc_addr(epc, &map->phys_base, > + map->map_size); It'd be nice to move pci_epc_map_align() inside the existing pci_epc_mem_alloc_addr() API to make sure that the allocated memory follows the constraints of the EPC. Would that make sense? - Mani > + if (!map->virt_base) > + return -ENOMEM; > + > + map->phys_addr = map->phys_base + map->map_ofst; > + map->virt_addr = map->virt_base + map->map_ofst; > + > + ret = pci_epc_map_addr(epc, func_no, vfunc_no, map->phys_base, > + map->map_pci_addr, map->map_size); > + if (ret) { > + pci_epc_mem_free_addr(epc, map->phys_base, map->virt_base, > + map->map_size); > + return ret; > + } > + > + return map->pci_size; > +} > +EXPORT_SYMBOL_GPL(pci_epc_mem_map); > + > +/** > + * pci_epc_mem_unmap() - unmap from PCI address and free a CPU address region > + * @epc: the EPC device on which the CPU address is allocated and mapped > + * @func_no: the physical endpoint function number in the EPC device > + * @vfunc_no: the virtual endpoint function number in the physical function > + * @map: the mapping information > + * > + * Allocate and map local CPU address to a PCI address, accounting for the > + * controller local CPU address alignment constraints. > + */ > +void pci_epc_mem_unmap(struct pci_epc *epc, u8 func_no, u8 vfunc_no, > + struct pci_epc_map *map) > +{ > + if (!pci_epc_function_is_valid(epc, func_no, vfunc_no)) > + return; > + > + if (!map || !map->pci_size) > + return; > + > + pci_epc_unmap_addr(epc, func_no, vfunc_no, map->phys_base); > + pci_epc_mem_free_addr(epc, map->phys_base, map->virt_base, > + map->map_size); > +} > +EXPORT_SYMBOL_GPL(pci_epc_mem_unmap); > + > /** > * pci_epc_clear_bar() - reset the BAR > * @epc: the EPC device for which the BAR has to be cleared > diff --git a/include/linux/pci-epc.h b/include/linux/pci-epc.h > index 8cfb4aaf2628..86397a500b54 100644 > --- a/include/linux/pci-epc.h > +++ b/include/linux/pci-epc.h > @@ -304,4 +304,10 @@ void __iomem *pci_epc_mem_alloc_addr(struct pci_epc *epc, > phys_addr_t *phys_addr, size_t size); > void pci_epc_mem_free_addr(struct pci_epc *epc, phys_addr_t phys_addr, > void __iomem *virt_addr, size_t size); > + > +ssize_t pci_epc_mem_map(struct pci_epc *epc, u8 func_no, u8 vfunc_no, > + u64 pci_addr, size_t size, struct pci_epc_map *map); > +void pci_epc_mem_unmap(struct pci_epc *epc, u8 func_no, u8 vfunc_no, > + struct pci_epc_map *map); > + > #endif /* __LINUX_PCI_EPC_H */ > -- > 2.44.0 > -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E1070CD1294 for ; Wed, 3 Apr 2024 09:49:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7rKwemLIpGybuwG5qUCstOPT9/JtSVt444PUBv/U0HQ=; b=A5UBvyqBC8W45r 0gSBO9q5b+evtDPMgnYoRt97IZbVgxF9N56BCZHU5AIbQxVsKbMpvyo/xgzWUnYEqdCS1VmIX9gKE Ykrxt448BvrT1gzwns4EDFuBlq5HvwYIUJ+eXEIyUyoozK3FORJBenJWZpUPxKX02ItoCslHNB8e9 2X7sDxEjcri1IWO9h8CyjypXVvRzelEfL1SJmTUUHhGgXSOV0/IZy0cP3zJjegfqonOGstWJ7O82S fswYifzbe0QNiy7Dzkbh7j0Mz1YLhycPDmy3AEMFnQiWnh1b0DVWYkbiTtOVISAVgOQKHsMbBH/If ELHdwzsWNWr+S97PaQlw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrxEi-0000000FIEJ-37V5; Wed, 03 Apr 2024 09:48:52 +0000 Received: from mail-io1-xd2e.google.com ([2607:f8b0:4864:20::d2e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrxEf-0000000FIBB-19DN for linux-rockchip@lists.infradead.org; Wed, 03 Apr 2024 09:48:51 +0000 Received: by mail-io1-xd2e.google.com with SMTP id ca18e2360f4ac-7d0262036afso314511339f.3 for ; Wed, 03 Apr 2024 02:48:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712137727; x=1712742527; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=EPXFh7gsPyAU+iXcewtYZIELGdFkMytovmlJfVGNhNo=; b=Hoh8/pOQaa/2icM08Ja5k9coQlMMLX2BNgpH3drJ1u/l8gpT9Xys4DZD6KlJVyuzja XkrY1Gu2n1nfxwPcVRI1hXQC2J958w3FP/m15sWs8XJFTspqrDZeH21qsDXuxbTAwnrq jZOkhOcnfFja5mZoTmsMTgI2nEZzGgzFYwulLZ4fRp5i9dpHGIx6C3qJcU7wsUYXaOfR SDePTv5HCJFpuzNot2TUx02EgKoxYfpK0XIduVqyQ+JqCzTZrbdtvjP49vIvgLTGVoWp jdY3naIOLzNyrG6/UERmeFaU2THmgm1ROcya+TzNepFUAcBIzWhIEOvXk+zYyHkc/MiA H+gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712137727; x=1712742527; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EPXFh7gsPyAU+iXcewtYZIELGdFkMytovmlJfVGNhNo=; b=Rgarfgd6Ld+5Hbpw8rmfNZu8kFPd4K0ggnwg6BiTHTpBDiMAn32sFPpHx8Kn7aoP3O XHfaf8CH9LdzJ0jvYMzE2M1QQ6KRMnGXE1cmwb8Wsu1QojTRXZ6SvsDdNFyH7ZDXt8Gk ZLU+ACiQ75wvCw00kNhbMyvjKc0yENrdPathyKBTcJEy4a8nTZEqTyNWmhVQr0kttPrb wY49LF05yFK7dtPsd7iwNb9VC9YUbrNdYaXQaQDV9a5CzmbPq/sHT6CSINJr+XQ1f9S6 xLBU7Lq5B5R0OFpo2/74TROU9Ps3PXQlg9zhVHZP1V2oT6IA7fmO3NkGnAEFwwZYj2z/ pOfQ== X-Forwarded-Encrypted: i=1; AJvYcCU3k3C3UVsSI9lhkMkHBfZmoNATTGHuWm4PfzniFhTPvqw2kTgI8pHQWgUZtwYv9zbiIcOaXM/q8h7042V0m4YmQXnBW97zVS7nIi4234m3qNg3 X-Gm-Message-State: AOJu0YzxX0HbZ3hsJ7Tnnln095KmaM5dHUxu69QV5Kib5/jO+Ti+duLo DcNRJH1cTQLxZ1jREwRbjRWuWGw7iAXULnVCBftjwfLOlNFLk3NAYBTP+ULjr6OiLHZzgfUyH+Q = X-Google-Smtp-Source: AGHT+IEbUkv1YVum64pYJ7p3hjvBN8WVLeTTz4TjDHu3j5DUSh/cjz4maB41kqZEWFfHUMT1vj9VFA== X-Received: by 2002:a05:6e02:1c08:b0:369:efba:71c1 with SMTP id l8-20020a056e021c0800b00369efba71c1mr1638352ilh.16.1712137726677; Wed, 03 Apr 2024 02:48:46 -0700 (PDT) Received: from thinkpad ([103.28.246.48]) by smtp.gmail.com with ESMTPSA id d21-20020a634f15000000b005dbd0facb4dsm10931377pgb.61.2024.04.03.02.48.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Apr 2024 02:48:46 -0700 (PDT) Date: Wed, 3 Apr 2024 15:18:40 +0530 From: Manivannan Sadhasivam To: Damien Le Moal Cc: Lorenzo Pieralisi , Kishon Vijay Abraham I , Shawn Lin , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Heiko Stuebner , linux-pci@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Rick Wertenbroek , Wilfred Mallawa , Niklas Cassel Subject: Re: [PATCH v2 03/18] PCI: endpoint: Introduce pci_epc_mem_map()/unmap() Message-ID: <20240403094840.GI25309@thinkpad> References: <20240330041928.1555578-1-dlemoal@kernel.org> <20240330041928.1555578-4-dlemoal@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240330041928.1555578-4-dlemoal@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240403_024849_456865_5BBF11E9 X-CRM114-Status: GOOD ( 33.93 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org T24gU2F0LCBNYXIgMzAsIDIwMjQgYXQgMDE6MTk6MTNQTSArMDkwMCwgRGFtaWVuIExlIE1vYWwg d3JvdGU6Cj4gSW50cm9kdWNlIHRoZSBmdW5jdGlvbiBwY2lfZXBjX21lbV9tYXAoKSB0byBmYWNp bGl0YXRlIGNvbnRyb2xsZXIgbWVtb3J5Cj4gYWRkcmVzcyBhbGxvY2F0aW9uIGFuZCBtYXBwaW5n IHRvIGEgUkMgUENJIGFkZHJlc3MgcmVnaW9uIGluIGVuZHBvaW50Cj4gZnVuY3Rpb24gZHJpdmVy cy4KPiAKPiBUaGlzIGZ1bmN0aW9uIGZpcnN0IHVzZXMgcGNpX2VwY19tYXBfYWxpZ24oKSB0byBk ZXRlcm1pbmUgdGhlIGNvbnRyb2xsZXIKPiBtZW1vcnkgYWRkcmVzcyBhbGlnbm1lbnQgKG9mZnNl dCBhbmQgc2l6ZSkgY29uc3RyYWludHMuIFRoZSByZXN1bHQgb2YKPiB0aGlzIGZ1bmN0aW9uIGlz IHVzZWQgdG8gYWxsb2NhdGUgYSBjb250cm9sbGVyIHBoeXNpY2FsIG1lbW9yeSByZWdpb24KPiB1 c2luZyBwY2lfZXBjX21lbV9hbGxvY19hZGRyKCkgYW5kIG1hcCBpdCB0byB0aGUgUkMgUENJIGFk ZHJlc3MKPiBzcGFjZSB3aXRoIHBjaV9lcGNfbWFwX2FkZHIoKS4gU2luY2UgcGNpX2VwY19tYXBf YWxpZ24oKSBtYXkgaW5kaWNhdGUKPiB0aGF0IGEgbWFwcGluZyBjYW4gYmUgc21hbGxlciB0aGFu IHRoZSByZXF1ZXN0ZWQgc2l6ZSwgcGNpX2VwY19tZW1fbWFwKCkKPiBtYXkgb25seSBwYXJ0aWFs bHkgbWFwIHRoZSBSQyBQQ0kgYWRkcmVzcyByZWdpb24gc3BlY2lmaWVkIGFuZCByZXR1cm4KPiBh IHNtYWxsZXIgc2l6ZSBmb3IgdGhlIGVmZmVjdGl2ZSBtYXBwaW5nLgo+IAo+IFRoZSBjb3VudGVy cGFydCBvZiBwY2lfZXBjX21lbV9tYXAoKSB0byB1bm1hcCBhbmQgZnJlZSB0aGUgY29udHJvbGxl cgo+IG1lbW9yeSBhZGRyZXNzIHJlZ2lvbiBpcyBwY2lfZXBjX21lbV91bm1hcCgpLgo+IAo+IEJv dGggZnVuY3Rpb25zIG9wZXJhdGUgdXNpbmcgc3RydWN0IHBjaV9lcGNfbWFwIGRhdGEgc3RydWN0 dXJlIHdoaWNoIGlzCj4gZXh0ZW5kZWQgdG8gY29udGFpbiB0aGUgcGh5c2ljYWwgYW5kIHZpcnR1 YWwgYWRkcmVzc2VzIG9mIHRoZSBhbGxvY2F0ZWQKPiBjb250cm9sbGVyIG1lbW9yeS4gRW5kcG9p bnQgZnVuY3Rpb24gZHJpdmVycyBjYW4gdXNlIHN0cnVjdCBwY2lfZXBjX21hcAo+IHRvIGltcGxl bWVudCByZWFkL3dyaXRlIGFjY2Vzc2VzIHdpdGhpbiB0aGUgbWFwcGVkIFJDIFBDSSBhZGRyZXNz IHJlZ2lvbgo+IHVzaW5nIHRoZSAtPnZpcnRfYWRkciBhbmQgLT5zaXplIGZpZWxkcy4KPiAKPiBU aGlzIGNvbW1pdCBjb250YWlucyBjb250cmlidXRpb25zIGZyb20gUmljayBXZXJ0ZW5icm9lawo+ IDxyaWNrLndlcnRlbmJyb2VrQGdtYWlsLmNvbT4uCj4gCgpBZGRpbmcgJ0NvLWRldmVsb3BlZC1i eSAmJiBTaWduZWQtb2ZmLWJ5JyB0YWdzIHdvdWxkIGdpdmUgdGhlIGR1ZSBjcmVkaXQuCgo+IFNp Z25lZC1vZmYtYnk6IERhbWllbiBMZSBNb2FsIDxkbGVtb2FsQGtlcm5lbC5vcmc+Cj4gLS0tCj4g IGRyaXZlcnMvcGNpL2VuZHBvaW50L3BjaS1lcGMtY29yZS5jIHwgNjggKysrKysrKysrKysrKysr KysrKysrKysrKysrKysKPiAgaW5jbHVkZS9saW51eC9wY2ktZXBjLmggICAgICAgICAgICAgfCAg NiArKysKPiAgMiBmaWxlcyBjaGFuZ2VkLCA3NCBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvcGNpL2VuZHBvaW50L3BjaS1lcGMtY29yZS5jIGIvZHJpdmVycy9wY2kvZW5k cG9pbnQvcGNpLWVwYy1jb3JlLmMKPiBpbmRleCAzNzc1OGNhOTFkN2YuLjAwOTViNTRiZGY5ZSAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL3BjaS9lbmRwb2ludC9wY2ktZXBjLWNvcmUuYwo+ICsrKyBi L2RyaXZlcnMvcGNpL2VuZHBvaW50L3BjaS1lcGMtY29yZS5jCj4gQEAgLTUzMCw2ICs1MzAsNzQg QEAgaW50IHBjaV9lcGNfbWFwX2FkZHIoc3RydWN0IHBjaV9lcGMgKmVwYywgdTggZnVuY19ubywg dTggdmZ1bmNfbm8sCj4gIH0KPiAgRVhQT1JUX1NZTUJPTF9HUEwocGNpX2VwY19tYXBfYWRkcik7 Cj4gIAo+ICsvKioKPiArICogcGNpX2VwY19tZW1fbWFwKCkgLSBhbGxvY2F0ZSBhbmQgbWFwIENQ VSBhZGRyZXNzIHRvIFBDSSBhZGRyZXNzCgpIb3cgYWJvdXQsICdwY2lfZXBjX2FsbG9jX21hcCgp Jz8gSSB0aGluayB0aGUgJ21lbScgcHJlZml4IHdhcyBhZGRlZCB0byB0aGUKZXhpc3RpbmcgQVBJ cyBzaW5jZSB0aGUgZnVuY3Rpb24gZGVmaW5pdGlvbnMgYXJlIGluIHBjaS1lcGMtbWVtIGRyaXZl ciwgYnV0Cm5vdCBuZWVkZWQgaGVyZS4KCj4gKyAqIEBlcGM6IHRoZSBFUEMgZGV2aWNlIG9uIHdo aWNoIHRoZSBDUFUgYWRkcmVzcyBpcyB0byBiZSBhbGxvY2F0ZWQgYW5kIG1hcHBlZAo+ICsgKiBA ZnVuY19ubzogdGhlIHBoeXNpY2FsIGVuZHBvaW50IGZ1bmN0aW9uIG51bWJlciBpbiB0aGUgRVBD IGRldmljZQo+ICsgKiBAdmZ1bmNfbm86IHRoZSB2aXJ0dWFsIGVuZHBvaW50IGZ1bmN0aW9uIG51 bWJlciBpbiB0aGUgcGh5c2ljYWwgZnVuY3Rpb24KPiArICogQHBjaV9hZGRyOiBQQ0kgYWRkcmVz cyB0byB3aGljaCB0aGUgQ1BVIGFkZHJlc3Mgc2hvdWxkIGJlIG1hcHBlZAo+ICsgKiBAc2l6ZTog dGhlIG51bWJlciBvZiBieXRlcyB0byBtYXAgc3RhcnRpbmcgZnJvbSBAcGNpX2FkZHIKPiArICog QG1hcDogd2hlcmUgdG8gcmV0dXJuIHRoZSBtYXBwaW5nIGluZm9ybWF0aW9uCj4gKyAqCj4gKyAq IEFsbG9jYXRlIGEgY29udHJvbGxlciBwaHlzaWNhbCBhZGRyZXNzIHJlZ2lvbiBhbmQgbWFwIGl0 IHRvIGEgUkMgUENJIGFkZHJlc3MKCiJBbGxvY2F0ZSBhbiBFUEMgYWRkcmVzcyBzcGFjZSByZWdp b24uLi4iCgo+ICsgKiByZWdpb24sIHRha2luZyBpbnRvIGFjY291bnQgdGhlIGNvbnRyb2xsZXIg cGh5c2ljYWwgYWRkcmVzcyBtYXBwaW5nCj4gKyAqIGNvbnN0cmFpbnRzIChpZiBhbnkpLiBSZXR1 cm5zIHRoZSBlZmZlY3RpdmUgc2l6ZSBvZiB0aGUgbWFwcGluZywgd2hpY2ggbWF5CgpSZXR1cm4g dmFsdWUgc2hvdWxkIGJlIHNwZWNpZmllZCBzZXBhcmF0ZWx5IGZvciBLZG9jLgoKPiArICogYmUg bGVzcyB0aGFuIEBzaXplLCBvciBhIG5lZ2F0aXZlIGVycm9yIGNvZGUgaW4gY2FzZSBvZiBlcnJv ci4KPiArICovCj4gK3NzaXplX3QgcGNpX2VwY19tZW1fbWFwKHN0cnVjdCBwY2lfZXBjICplcGMs IHU4IGZ1bmNfbm8sIHU4IHZmdW5jX25vLAo+ICsJCQl1NjQgcGNpX2FkZHIsIHNpemVfdCBzaXpl LCBzdHJ1Y3QgcGNpX2VwY19tYXAgKm1hcCkKPiArewo+ICsJaW50IHJldDsKPiArCj4gKwlyZXQg PSBwY2lfZXBjX21hcF9hbGlnbihlcGMsIGZ1bmNfbm8sIHZmdW5jX25vLCBwY2lfYWRkciwgc2l6 ZSwgbWFwKTsKPiArCWlmIChyZXQpCj4gKwkJcmV0dXJuIHJldDsKPiArCj4gKwltYXAtPnZpcnRf YmFzZSA9IHBjaV9lcGNfbWVtX2FsbG9jX2FkZHIoZXBjLCAmbWFwLT5waHlzX2Jhc2UsCj4gKwkJ CQkJCW1hcC0+bWFwX3NpemUpOwoKSXQnZCBiZSBuaWNlIHRvIG1vdmUgcGNpX2VwY19tYXBfYWxp Z24oKSBpbnNpZGUgdGhlIGV4aXN0aW5nCnBjaV9lcGNfbWVtX2FsbG9jX2FkZHIoKSBBUEkgdG8g bWFrZSBzdXJlIHRoYXQgdGhlIGFsbG9jYXRlZCBtZW1vcnkgZm9sbG93cyB0aGUKY29uc3RyYWlu dHMgb2YgdGhlIEVQQy4KCldvdWxkIHRoYXQgbWFrZSBzZW5zZT8KCi0gTWFuaQoKPiArCWlmICgh bWFwLT52aXJ0X2Jhc2UpCj4gKwkJcmV0dXJuIC1FTk9NRU07Cj4gKwo+ICsJbWFwLT5waHlzX2Fk ZHIgPSBtYXAtPnBoeXNfYmFzZSArIG1hcC0+bWFwX29mc3Q7Cj4gKwltYXAtPnZpcnRfYWRkciA9 IG1hcC0+dmlydF9iYXNlICsgbWFwLT5tYXBfb2ZzdDsKPiArCj4gKwlyZXQgPSBwY2lfZXBjX21h cF9hZGRyKGVwYywgZnVuY19ubywgdmZ1bmNfbm8sIG1hcC0+cGh5c19iYXNlLAo+ICsJCQkgICAg ICAgbWFwLT5tYXBfcGNpX2FkZHIsIG1hcC0+bWFwX3NpemUpOwo+ICsJaWYgKHJldCkgewo+ICsJ CXBjaV9lcGNfbWVtX2ZyZWVfYWRkcihlcGMsIG1hcC0+cGh5c19iYXNlLCBtYXAtPnZpcnRfYmFz ZSwKPiArCQkJCSAgICAgIG1hcC0+bWFwX3NpemUpOwo+ICsJCXJldHVybiByZXQ7Cj4gKwl9Cj4g Kwo+ICsJcmV0dXJuIG1hcC0+cGNpX3NpemU7Cj4gK30KPiArRVhQT1JUX1NZTUJPTF9HUEwocGNp X2VwY19tZW1fbWFwKTsKPiArCj4gKy8qKgo+ICsgKiBwY2lfZXBjX21lbV91bm1hcCgpIC0gdW5t YXAgZnJvbSBQQ0kgYWRkcmVzcyBhbmQgZnJlZSBhIENQVSBhZGRyZXNzIHJlZ2lvbgo+ICsgKiBA ZXBjOiB0aGUgRVBDIGRldmljZSBvbiB3aGljaCB0aGUgQ1BVIGFkZHJlc3MgaXMgYWxsb2NhdGVk IGFuZCBtYXBwZWQKPiArICogQGZ1bmNfbm86IHRoZSBwaHlzaWNhbCBlbmRwb2ludCBmdW5jdGlv biBudW1iZXIgaW4gdGhlIEVQQyBkZXZpY2UKPiArICogQHZmdW5jX25vOiB0aGUgdmlydHVhbCBl bmRwb2ludCBmdW5jdGlvbiBudW1iZXIgaW4gdGhlIHBoeXNpY2FsIGZ1bmN0aW9uCj4gKyAqIEBt YXA6IHRoZSBtYXBwaW5nIGluZm9ybWF0aW9uCj4gKyAqCj4gKyAqIEFsbG9jYXRlIGFuZCBtYXAg bG9jYWwgQ1BVIGFkZHJlc3MgdG8gYSBQQ0kgYWRkcmVzcywgYWNjb3VudGluZyBmb3IgdGhlCj4g KyAqIGNvbnRyb2xsZXIgbG9jYWwgQ1BVIGFkZHJlc3MgYWxpZ25tZW50IGNvbnN0cmFpbnRzLgo+ ICsgKi8KPiArdm9pZCBwY2lfZXBjX21lbV91bm1hcChzdHJ1Y3QgcGNpX2VwYyAqZXBjLCB1OCBm dW5jX25vLCB1OCB2ZnVuY19ubywKPiArCQkgICAgICAgc3RydWN0IHBjaV9lcGNfbWFwICptYXAp Cj4gK3sKPiArCWlmICghcGNpX2VwY19mdW5jdGlvbl9pc192YWxpZChlcGMsIGZ1bmNfbm8sIHZm dW5jX25vKSkKPiArCQlyZXR1cm47Cj4gKwo+ICsJaWYgKCFtYXAgfHwgIW1hcC0+cGNpX3NpemUp Cj4gKwkJcmV0dXJuOwo+ICsKPiArCXBjaV9lcGNfdW5tYXBfYWRkcihlcGMsIGZ1bmNfbm8sIHZm dW5jX25vLCBtYXAtPnBoeXNfYmFzZSk7Cj4gKwlwY2lfZXBjX21lbV9mcmVlX2FkZHIoZXBjLCBt YXAtPnBoeXNfYmFzZSwgbWFwLT52aXJ0X2Jhc2UsCj4gKwkJCSAgICAgIG1hcC0+bWFwX3NpemUp Owo+ICt9Cj4gK0VYUE9SVF9TWU1CT0xfR1BMKHBjaV9lcGNfbWVtX3VubWFwKTsKPiArCj4gIC8q Kgo+ICAgKiBwY2lfZXBjX2NsZWFyX2JhcigpIC0gcmVzZXQgdGhlIEJBUgo+ICAgKiBAZXBjOiB0 aGUgRVBDIGRldmljZSBmb3Igd2hpY2ggdGhlIEJBUiBoYXMgdG8gYmUgY2xlYXJlZAo+IGRpZmYg LS1naXQgYS9pbmNsdWRlL2xpbnV4L3BjaS1lcGMuaCBiL2luY2x1ZGUvbGludXgvcGNpLWVwYy5o Cj4gaW5kZXggOGNmYjRhYWYyNjI4Li44NjM5N2E1MDBiNTQgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVk ZS9saW51eC9wY2ktZXBjLmgKPiArKysgYi9pbmNsdWRlL2xpbnV4L3BjaS1lcGMuaAo+IEBAIC0z MDQsNCArMzA0LDEwIEBAIHZvaWQgX19pb21lbSAqcGNpX2VwY19tZW1fYWxsb2NfYWRkcihzdHJ1 Y3QgcGNpX2VwYyAqZXBjLAo+ICAJCQkJICAgICBwaHlzX2FkZHJfdCAqcGh5c19hZGRyLCBzaXpl X3Qgc2l6ZSk7Cj4gIHZvaWQgcGNpX2VwY19tZW1fZnJlZV9hZGRyKHN0cnVjdCBwY2lfZXBjICpl cGMsIHBoeXNfYWRkcl90IHBoeXNfYWRkciwKPiAgCQkJICAgdm9pZCBfX2lvbWVtICp2aXJ0X2Fk ZHIsIHNpemVfdCBzaXplKTsKPiArCj4gK3NzaXplX3QgcGNpX2VwY19tZW1fbWFwKHN0cnVjdCBw Y2lfZXBjICplcGMsIHU4IGZ1bmNfbm8sIHU4IHZmdW5jX25vLAo+ICsJCQl1NjQgcGNpX2FkZHIs IHNpemVfdCBzaXplLCBzdHJ1Y3QgcGNpX2VwY19tYXAgKm1hcCk7Cj4gK3ZvaWQgcGNpX2VwY19t ZW1fdW5tYXAoc3RydWN0IHBjaV9lcGMgKmVwYywgdTggZnVuY19ubywgdTggdmZ1bmNfbm8sCj4g KwkJICAgICAgIHN0cnVjdCBwY2lfZXBjX21hcCAqbWFwKTsKPiArCj4gICNlbmRpZiAvKiBfX0xJ TlVYX1BDSV9FUENfSCAqLwo+IC0tIAo+IDIuNDQuMAo+IAoKLS0gCuCuruCuo+Cuv+CuteCuo+Cv jeCuo+CuqeCvjSDgrprgrqTgrr7grprgrr/grrXgrq7gr40KCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdApM aW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F15FCCD1288 for ; Wed, 3 Apr 2024 09:49:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Z1UvNrc2BFHaIVcfPJZwyMoblu6Cgl+tFmhp6f6H7Zc=; b=n03H+YSkcBBgFO Ol2y+gvYxHPORZt8fez3+pTycOJqUw52OaMY/OA+dZbG9K9VfavdDISnA8acNWHH8B1FAYymY9g5Q KwTPBgy9WTE/VT2dKCDpOy+VkMcID1cKpJmdf2Qy7bfmTvFIykuk4OX5wDbdGIOCV7XetN1/xM34x 3xcNQiD0nLmRkGIF7yhnDj7eahQiAYJ/VdR5qQcmG0ZyWqtFHQKbFKr7Hfeh0hxpfYksqVTICmDS3 kGAiESEnHzWUkLCfwL/hRn91raMOL8hxq0EtYWg+zZKpqTRxsU9MJ8Z+BmjHUYiNxW6DHTNvhBnzy UYmI1N32kp9t6RlBVLvg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrxEi-0000000FIDh-0LV3; Wed, 03 Apr 2024 09:48:52 +0000 Received: from mail-il1-x12e.google.com ([2607:f8b0:4864:20::12e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrxEf-0000000FIB8-1BWy for linux-arm-kernel@lists.infradead.org; Wed, 03 Apr 2024 09:48:51 +0000 Received: by mail-il1-x12e.google.com with SMTP id e9e14a558f8ab-3689641c9a2so7625955ab.1 for ; Wed, 03 Apr 2024 02:48:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712137727; x=1712742527; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=EPXFh7gsPyAU+iXcewtYZIELGdFkMytovmlJfVGNhNo=; b=Hoh8/pOQaa/2icM08Ja5k9coQlMMLX2BNgpH3drJ1u/l8gpT9Xys4DZD6KlJVyuzja XkrY1Gu2n1nfxwPcVRI1hXQC2J958w3FP/m15sWs8XJFTspqrDZeH21qsDXuxbTAwnrq jZOkhOcnfFja5mZoTmsMTgI2nEZzGgzFYwulLZ4fRp5i9dpHGIx6C3qJcU7wsUYXaOfR SDePTv5HCJFpuzNot2TUx02EgKoxYfpK0XIduVqyQ+JqCzTZrbdtvjP49vIvgLTGVoWp jdY3naIOLzNyrG6/UERmeFaU2THmgm1ROcya+TzNepFUAcBIzWhIEOvXk+zYyHkc/MiA H+gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712137727; x=1712742527; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EPXFh7gsPyAU+iXcewtYZIELGdFkMytovmlJfVGNhNo=; b=nu2UPKq/QzHg6AzjoIt+gLFNBSTee03xuvY35VerQsqZ80cCHibZueFwzyNV9T9IwS KTIpWVhD4AP8V0KEpOhDMoTcr1C7Z9Z7mSup6xDueii5TYgZ9wr1KVEXM86C/igd9hrd qRoR/Q98+CeCkxhHWfNrg269LUy58uqmnvHbnElqNy8OfFK26fkVBgE15DbjzhqBW1ej 6ULEafrqvvB2MlVDOIj+QeechOFiL3io6sUUaqEOMMFUbTctadePeff/rQRCXMfn15XW 8/EmB/eGvcXz47XQpSuUNq9V97V9Gobf05IMaJi/0qan+njoOPR82zwV4SGf97tOAvlh uWdQ== X-Forwarded-Encrypted: i=1; AJvYcCWci8nlx6hwC5j7BcdCZ4WLmC/xuttoSXzSc+lHA6TnbN8bJ6SAA7C7f7t3QxLGZVcARW0rZBA7zkBvy9yiAiPLs56l0C4yqemfwcXP6pqyIrEKAUQ= X-Gm-Message-State: AOJu0YwTYbN30WKvkRfzewkGRAYntRXaeEchlUKBB4dVfWqkduiLuxoQ jiKxtvkEyWIJi0SE5UrGXPMMz565jnzviXTvrnaSVciKyAxwWEJPGapjvlyhYA== X-Google-Smtp-Source: AGHT+IEbUkv1YVum64pYJ7p3hjvBN8WVLeTTz4TjDHu3j5DUSh/cjz4maB41kqZEWFfHUMT1vj9VFA== X-Received: by 2002:a05:6e02:1c08:b0:369:efba:71c1 with SMTP id l8-20020a056e021c0800b00369efba71c1mr1638352ilh.16.1712137726677; Wed, 03 Apr 2024 02:48:46 -0700 (PDT) Received: from thinkpad ([103.28.246.48]) by smtp.gmail.com with ESMTPSA id d21-20020a634f15000000b005dbd0facb4dsm10931377pgb.61.2024.04.03.02.48.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Apr 2024 02:48:46 -0700 (PDT) Date: Wed, 3 Apr 2024 15:18:40 +0530 From: Manivannan Sadhasivam To: Damien Le Moal Cc: Lorenzo Pieralisi , Kishon Vijay Abraham I , Shawn Lin , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Heiko Stuebner , linux-pci@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Rick Wertenbroek , Wilfred Mallawa , Niklas Cassel Subject: Re: [PATCH v2 03/18] PCI: endpoint: Introduce pci_epc_mem_map()/unmap() Message-ID: <20240403094840.GI25309@thinkpad> References: <20240330041928.1555578-1-dlemoal@kernel.org> <20240330041928.1555578-4-dlemoal@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240330041928.1555578-4-dlemoal@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240403_024849_435336_954DD21F X-CRM114-Status: GOOD ( 35.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU2F0LCBNYXIgMzAsIDIwMjQgYXQgMDE6MTk6MTNQTSArMDkwMCwgRGFtaWVuIExlIE1vYWwg d3JvdGU6Cj4gSW50cm9kdWNlIHRoZSBmdW5jdGlvbiBwY2lfZXBjX21lbV9tYXAoKSB0byBmYWNp bGl0YXRlIGNvbnRyb2xsZXIgbWVtb3J5Cj4gYWRkcmVzcyBhbGxvY2F0aW9uIGFuZCBtYXBwaW5n IHRvIGEgUkMgUENJIGFkZHJlc3MgcmVnaW9uIGluIGVuZHBvaW50Cj4gZnVuY3Rpb24gZHJpdmVy cy4KPiAKPiBUaGlzIGZ1bmN0aW9uIGZpcnN0IHVzZXMgcGNpX2VwY19tYXBfYWxpZ24oKSB0byBk ZXRlcm1pbmUgdGhlIGNvbnRyb2xsZXIKPiBtZW1vcnkgYWRkcmVzcyBhbGlnbm1lbnQgKG9mZnNl dCBhbmQgc2l6ZSkgY29uc3RyYWludHMuIFRoZSByZXN1bHQgb2YKPiB0aGlzIGZ1bmN0aW9uIGlz IHVzZWQgdG8gYWxsb2NhdGUgYSBjb250cm9sbGVyIHBoeXNpY2FsIG1lbW9yeSByZWdpb24KPiB1 c2luZyBwY2lfZXBjX21lbV9hbGxvY19hZGRyKCkgYW5kIG1hcCBpdCB0byB0aGUgUkMgUENJIGFk ZHJlc3MKPiBzcGFjZSB3aXRoIHBjaV9lcGNfbWFwX2FkZHIoKS4gU2luY2UgcGNpX2VwY19tYXBf YWxpZ24oKSBtYXkgaW5kaWNhdGUKPiB0aGF0IGEgbWFwcGluZyBjYW4gYmUgc21hbGxlciB0aGFu IHRoZSByZXF1ZXN0ZWQgc2l6ZSwgcGNpX2VwY19tZW1fbWFwKCkKPiBtYXkgb25seSBwYXJ0aWFs bHkgbWFwIHRoZSBSQyBQQ0kgYWRkcmVzcyByZWdpb24gc3BlY2lmaWVkIGFuZCByZXR1cm4KPiBh IHNtYWxsZXIgc2l6ZSBmb3IgdGhlIGVmZmVjdGl2ZSBtYXBwaW5nLgo+IAo+IFRoZSBjb3VudGVy cGFydCBvZiBwY2lfZXBjX21lbV9tYXAoKSB0byB1bm1hcCBhbmQgZnJlZSB0aGUgY29udHJvbGxl cgo+IG1lbW9yeSBhZGRyZXNzIHJlZ2lvbiBpcyBwY2lfZXBjX21lbV91bm1hcCgpLgo+IAo+IEJv dGggZnVuY3Rpb25zIG9wZXJhdGUgdXNpbmcgc3RydWN0IHBjaV9lcGNfbWFwIGRhdGEgc3RydWN0 dXJlIHdoaWNoIGlzCj4gZXh0ZW5kZWQgdG8gY29udGFpbiB0aGUgcGh5c2ljYWwgYW5kIHZpcnR1 YWwgYWRkcmVzc2VzIG9mIHRoZSBhbGxvY2F0ZWQKPiBjb250cm9sbGVyIG1lbW9yeS4gRW5kcG9p bnQgZnVuY3Rpb24gZHJpdmVycyBjYW4gdXNlIHN0cnVjdCBwY2lfZXBjX21hcAo+IHRvIGltcGxl bWVudCByZWFkL3dyaXRlIGFjY2Vzc2VzIHdpdGhpbiB0aGUgbWFwcGVkIFJDIFBDSSBhZGRyZXNz IHJlZ2lvbgo+IHVzaW5nIHRoZSAtPnZpcnRfYWRkciBhbmQgLT5zaXplIGZpZWxkcy4KPiAKPiBU aGlzIGNvbW1pdCBjb250YWlucyBjb250cmlidXRpb25zIGZyb20gUmljayBXZXJ0ZW5icm9lawo+ IDxyaWNrLndlcnRlbmJyb2VrQGdtYWlsLmNvbT4uCj4gCgpBZGRpbmcgJ0NvLWRldmVsb3BlZC1i eSAmJiBTaWduZWQtb2ZmLWJ5JyB0YWdzIHdvdWxkIGdpdmUgdGhlIGR1ZSBjcmVkaXQuCgo+IFNp Z25lZC1vZmYtYnk6IERhbWllbiBMZSBNb2FsIDxkbGVtb2FsQGtlcm5lbC5vcmc+Cj4gLS0tCj4g IGRyaXZlcnMvcGNpL2VuZHBvaW50L3BjaS1lcGMtY29yZS5jIHwgNjggKysrKysrKysrKysrKysr KysrKysrKysrKysrKysKPiAgaW5jbHVkZS9saW51eC9wY2ktZXBjLmggICAgICAgICAgICAgfCAg NiArKysKPiAgMiBmaWxlcyBjaGFuZ2VkLCA3NCBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvcGNpL2VuZHBvaW50L3BjaS1lcGMtY29yZS5jIGIvZHJpdmVycy9wY2kvZW5k cG9pbnQvcGNpLWVwYy1jb3JlLmMKPiBpbmRleCAzNzc1OGNhOTFkN2YuLjAwOTViNTRiZGY5ZSAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL3BjaS9lbmRwb2ludC9wY2ktZXBjLWNvcmUuYwo+ICsrKyBi L2RyaXZlcnMvcGNpL2VuZHBvaW50L3BjaS1lcGMtY29yZS5jCj4gQEAgLTUzMCw2ICs1MzAsNzQg QEAgaW50IHBjaV9lcGNfbWFwX2FkZHIoc3RydWN0IHBjaV9lcGMgKmVwYywgdTggZnVuY19ubywg dTggdmZ1bmNfbm8sCj4gIH0KPiAgRVhQT1JUX1NZTUJPTF9HUEwocGNpX2VwY19tYXBfYWRkcik7 Cj4gIAo+ICsvKioKPiArICogcGNpX2VwY19tZW1fbWFwKCkgLSBhbGxvY2F0ZSBhbmQgbWFwIENQ VSBhZGRyZXNzIHRvIFBDSSBhZGRyZXNzCgpIb3cgYWJvdXQsICdwY2lfZXBjX2FsbG9jX21hcCgp Jz8gSSB0aGluayB0aGUgJ21lbScgcHJlZml4IHdhcyBhZGRlZCB0byB0aGUKZXhpc3RpbmcgQVBJ cyBzaW5jZSB0aGUgZnVuY3Rpb24gZGVmaW5pdGlvbnMgYXJlIGluIHBjaS1lcGMtbWVtIGRyaXZl ciwgYnV0Cm5vdCBuZWVkZWQgaGVyZS4KCj4gKyAqIEBlcGM6IHRoZSBFUEMgZGV2aWNlIG9uIHdo aWNoIHRoZSBDUFUgYWRkcmVzcyBpcyB0byBiZSBhbGxvY2F0ZWQgYW5kIG1hcHBlZAo+ICsgKiBA ZnVuY19ubzogdGhlIHBoeXNpY2FsIGVuZHBvaW50IGZ1bmN0aW9uIG51bWJlciBpbiB0aGUgRVBD IGRldmljZQo+ICsgKiBAdmZ1bmNfbm86IHRoZSB2aXJ0dWFsIGVuZHBvaW50IGZ1bmN0aW9uIG51 bWJlciBpbiB0aGUgcGh5c2ljYWwgZnVuY3Rpb24KPiArICogQHBjaV9hZGRyOiBQQ0kgYWRkcmVz cyB0byB3aGljaCB0aGUgQ1BVIGFkZHJlc3Mgc2hvdWxkIGJlIG1hcHBlZAo+ICsgKiBAc2l6ZTog dGhlIG51bWJlciBvZiBieXRlcyB0byBtYXAgc3RhcnRpbmcgZnJvbSBAcGNpX2FkZHIKPiArICog QG1hcDogd2hlcmUgdG8gcmV0dXJuIHRoZSBtYXBwaW5nIGluZm9ybWF0aW9uCj4gKyAqCj4gKyAq IEFsbG9jYXRlIGEgY29udHJvbGxlciBwaHlzaWNhbCBhZGRyZXNzIHJlZ2lvbiBhbmQgbWFwIGl0 IHRvIGEgUkMgUENJIGFkZHJlc3MKCiJBbGxvY2F0ZSBhbiBFUEMgYWRkcmVzcyBzcGFjZSByZWdp b24uLi4iCgo+ICsgKiByZWdpb24sIHRha2luZyBpbnRvIGFjY291bnQgdGhlIGNvbnRyb2xsZXIg cGh5c2ljYWwgYWRkcmVzcyBtYXBwaW5nCj4gKyAqIGNvbnN0cmFpbnRzIChpZiBhbnkpLiBSZXR1 cm5zIHRoZSBlZmZlY3RpdmUgc2l6ZSBvZiB0aGUgbWFwcGluZywgd2hpY2ggbWF5CgpSZXR1cm4g dmFsdWUgc2hvdWxkIGJlIHNwZWNpZmllZCBzZXBhcmF0ZWx5IGZvciBLZG9jLgoKPiArICogYmUg bGVzcyB0aGFuIEBzaXplLCBvciBhIG5lZ2F0aXZlIGVycm9yIGNvZGUgaW4gY2FzZSBvZiBlcnJv ci4KPiArICovCj4gK3NzaXplX3QgcGNpX2VwY19tZW1fbWFwKHN0cnVjdCBwY2lfZXBjICplcGMs IHU4IGZ1bmNfbm8sIHU4IHZmdW5jX25vLAo+ICsJCQl1NjQgcGNpX2FkZHIsIHNpemVfdCBzaXpl LCBzdHJ1Y3QgcGNpX2VwY19tYXAgKm1hcCkKPiArewo+ICsJaW50IHJldDsKPiArCj4gKwlyZXQg PSBwY2lfZXBjX21hcF9hbGlnbihlcGMsIGZ1bmNfbm8sIHZmdW5jX25vLCBwY2lfYWRkciwgc2l6 ZSwgbWFwKTsKPiArCWlmIChyZXQpCj4gKwkJcmV0dXJuIHJldDsKPiArCj4gKwltYXAtPnZpcnRf YmFzZSA9IHBjaV9lcGNfbWVtX2FsbG9jX2FkZHIoZXBjLCAmbWFwLT5waHlzX2Jhc2UsCj4gKwkJ CQkJCW1hcC0+bWFwX3NpemUpOwoKSXQnZCBiZSBuaWNlIHRvIG1vdmUgcGNpX2VwY19tYXBfYWxp Z24oKSBpbnNpZGUgdGhlIGV4aXN0aW5nCnBjaV9lcGNfbWVtX2FsbG9jX2FkZHIoKSBBUEkgdG8g bWFrZSBzdXJlIHRoYXQgdGhlIGFsbG9jYXRlZCBtZW1vcnkgZm9sbG93cyB0aGUKY29uc3RyYWlu dHMgb2YgdGhlIEVQQy4KCldvdWxkIHRoYXQgbWFrZSBzZW5zZT8KCi0gTWFuaQoKPiArCWlmICgh bWFwLT52aXJ0X2Jhc2UpCj4gKwkJcmV0dXJuIC1FTk9NRU07Cj4gKwo+ICsJbWFwLT5waHlzX2Fk ZHIgPSBtYXAtPnBoeXNfYmFzZSArIG1hcC0+bWFwX29mc3Q7Cj4gKwltYXAtPnZpcnRfYWRkciA9 IG1hcC0+dmlydF9iYXNlICsgbWFwLT5tYXBfb2ZzdDsKPiArCj4gKwlyZXQgPSBwY2lfZXBjX21h cF9hZGRyKGVwYywgZnVuY19ubywgdmZ1bmNfbm8sIG1hcC0+cGh5c19iYXNlLAo+ICsJCQkgICAg ICAgbWFwLT5tYXBfcGNpX2FkZHIsIG1hcC0+bWFwX3NpemUpOwo+ICsJaWYgKHJldCkgewo+ICsJ CXBjaV9lcGNfbWVtX2ZyZWVfYWRkcihlcGMsIG1hcC0+cGh5c19iYXNlLCBtYXAtPnZpcnRfYmFz ZSwKPiArCQkJCSAgICAgIG1hcC0+bWFwX3NpemUpOwo+ICsJCXJldHVybiByZXQ7Cj4gKwl9Cj4g Kwo+ICsJcmV0dXJuIG1hcC0+cGNpX3NpemU7Cj4gK30KPiArRVhQT1JUX1NZTUJPTF9HUEwocGNp X2VwY19tZW1fbWFwKTsKPiArCj4gKy8qKgo+ICsgKiBwY2lfZXBjX21lbV91bm1hcCgpIC0gdW5t YXAgZnJvbSBQQ0kgYWRkcmVzcyBhbmQgZnJlZSBhIENQVSBhZGRyZXNzIHJlZ2lvbgo+ICsgKiBA ZXBjOiB0aGUgRVBDIGRldmljZSBvbiB3aGljaCB0aGUgQ1BVIGFkZHJlc3MgaXMgYWxsb2NhdGVk IGFuZCBtYXBwZWQKPiArICogQGZ1bmNfbm86IHRoZSBwaHlzaWNhbCBlbmRwb2ludCBmdW5jdGlv biBudW1iZXIgaW4gdGhlIEVQQyBkZXZpY2UKPiArICogQHZmdW5jX25vOiB0aGUgdmlydHVhbCBl bmRwb2ludCBmdW5jdGlvbiBudW1iZXIgaW4gdGhlIHBoeXNpY2FsIGZ1bmN0aW9uCj4gKyAqIEBt YXA6IHRoZSBtYXBwaW5nIGluZm9ybWF0aW9uCj4gKyAqCj4gKyAqIEFsbG9jYXRlIGFuZCBtYXAg bG9jYWwgQ1BVIGFkZHJlc3MgdG8gYSBQQ0kgYWRkcmVzcywgYWNjb3VudGluZyBmb3IgdGhlCj4g KyAqIGNvbnRyb2xsZXIgbG9jYWwgQ1BVIGFkZHJlc3MgYWxpZ25tZW50IGNvbnN0cmFpbnRzLgo+ ICsgKi8KPiArdm9pZCBwY2lfZXBjX21lbV91bm1hcChzdHJ1Y3QgcGNpX2VwYyAqZXBjLCB1OCBm dW5jX25vLCB1OCB2ZnVuY19ubywKPiArCQkgICAgICAgc3RydWN0IHBjaV9lcGNfbWFwICptYXAp Cj4gK3sKPiArCWlmICghcGNpX2VwY19mdW5jdGlvbl9pc192YWxpZChlcGMsIGZ1bmNfbm8sIHZm dW5jX25vKSkKPiArCQlyZXR1cm47Cj4gKwo+ICsJaWYgKCFtYXAgfHwgIW1hcC0+cGNpX3NpemUp Cj4gKwkJcmV0dXJuOwo+ICsKPiArCXBjaV9lcGNfdW5tYXBfYWRkcihlcGMsIGZ1bmNfbm8sIHZm dW5jX25vLCBtYXAtPnBoeXNfYmFzZSk7Cj4gKwlwY2lfZXBjX21lbV9mcmVlX2FkZHIoZXBjLCBt YXAtPnBoeXNfYmFzZSwgbWFwLT52aXJ0X2Jhc2UsCj4gKwkJCSAgICAgIG1hcC0+bWFwX3NpemUp Owo+ICt9Cj4gK0VYUE9SVF9TWU1CT0xfR1BMKHBjaV9lcGNfbWVtX3VubWFwKTsKPiArCj4gIC8q Kgo+ICAgKiBwY2lfZXBjX2NsZWFyX2JhcigpIC0gcmVzZXQgdGhlIEJBUgo+ICAgKiBAZXBjOiB0 aGUgRVBDIGRldmljZSBmb3Igd2hpY2ggdGhlIEJBUiBoYXMgdG8gYmUgY2xlYXJlZAo+IGRpZmYg LS1naXQgYS9pbmNsdWRlL2xpbnV4L3BjaS1lcGMuaCBiL2luY2x1ZGUvbGludXgvcGNpLWVwYy5o Cj4gaW5kZXggOGNmYjRhYWYyNjI4Li44NjM5N2E1MDBiNTQgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVk ZS9saW51eC9wY2ktZXBjLmgKPiArKysgYi9pbmNsdWRlL2xpbnV4L3BjaS1lcGMuaAo+IEBAIC0z MDQsNCArMzA0LDEwIEBAIHZvaWQgX19pb21lbSAqcGNpX2VwY19tZW1fYWxsb2NfYWRkcihzdHJ1 Y3QgcGNpX2VwYyAqZXBjLAo+ICAJCQkJICAgICBwaHlzX2FkZHJfdCAqcGh5c19hZGRyLCBzaXpl X3Qgc2l6ZSk7Cj4gIHZvaWQgcGNpX2VwY19tZW1fZnJlZV9hZGRyKHN0cnVjdCBwY2lfZXBjICpl cGMsIHBoeXNfYWRkcl90IHBoeXNfYWRkciwKPiAgCQkJICAgdm9pZCBfX2lvbWVtICp2aXJ0X2Fk ZHIsIHNpemVfdCBzaXplKTsKPiArCj4gK3NzaXplX3QgcGNpX2VwY19tZW1fbWFwKHN0cnVjdCBw Y2lfZXBjICplcGMsIHU4IGZ1bmNfbm8sIHU4IHZmdW5jX25vLAo+ICsJCQl1NjQgcGNpX2FkZHIs IHNpemVfdCBzaXplLCBzdHJ1Y3QgcGNpX2VwY19tYXAgKm1hcCk7Cj4gK3ZvaWQgcGNpX2VwY19t ZW1fdW5tYXAoc3RydWN0IHBjaV9lcGMgKmVwYywgdTggZnVuY19ubywgdTggdmZ1bmNfbm8sCj4g KwkJICAgICAgIHN0cnVjdCBwY2lfZXBjX21hcCAqbWFwKTsKPiArCj4gICNlbmRpZiAvKiBfX0xJ TlVYX1BDSV9FUENfSCAqLwo+IC0tIAo+IDIuNDQuMAo+IAoKLS0gCuCuruCuo+Cuv+CuteCuo+Cv jeCuo+CuqeCvjSDgrprgrqTgrr7grprgrr/grrXgrq7gr40KCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0 CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK