From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB91054F8C; Wed, 3 Apr 2024 10:14:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712139270; cv=none; b=uZa8KMoTShY3tXqr7yNNeRCgyBQBZGk0nXwi9zKHjxKOoArOgm52HtToR1q9o+t+AaTBvcHud2fIVO35jQMrM0cWUKYlmAkNFJMP/o6gBUfOJywVuh5RLtSAzDefn+3Rs1SCluOEkx8+uBVSIPBT37FMIbhpV8O+06jj73w2YvQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712139270; c=relaxed/simple; bh=r5zbDD1xPnIx0hjHcD74GYNbkecVM237ZbayTgPGrgY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ONJJdcrrfHK/njyv8lqjFQLjBDbQyuOXi4JOaLtDSkqeu1/byFaZAZ6oYpEiCgpPDYRCZv06xmikDikYgLYZ8o+zKGDvW8KS82EiZ09asqrNq7qO682IHJBiEgC58XKp855P7AhidgFDG5OLdaRKAMxfm1N1ciJSzFTb6ryK9pc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 44E2068BEB; Wed, 3 Apr 2024 12:14:22 +0200 (CEST) Date: Wed, 3 Apr 2024 12:14:22 +0200 From: Christoph Hellwig To: David Howells Cc: Christoph Hellwig , Christian Brauner , Jeff Layton , Gao Xiang , Dominique Martinet , Matthew Wilcox , Steve French , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Eric Van Hensbergen , Ilya Dryomov , netfs@lists.linux.dev, linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 15/26] mm: Export writeback_iter() Message-ID: <20240403101422.GA7285@lst.de> References: <20240403085918.GA1178@lst.de> <20240328163424.2781320-1-dhowells@redhat.com> <20240328163424.2781320-16-dhowells@redhat.com> <3235934.1712139047@warthog.procyon.org.uk> Precedence: bulk X-Mailing-List: ceph-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3235934.1712139047@warthog.procyon.org.uk> User-Agent: Mutt/1.5.17 (2007-11-01) On Wed, Apr 03, 2024 at 11:10:47AM +0100, David Howells wrote: > That depends. You put a comment on write_cache_pages() saying that people > should use writeback_iter() instead. w_c_p() is not marked GPL. Is it your > intention to get rid of it? Yes. If you think you're not a derivate work of Linux you have no business using either one. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8461DCD128A for ; Wed, 3 Apr 2024 10:14:38 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4V8gbK1H4mz3vkD for ; Wed, 3 Apr 2024 21:14:37 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lst.de (client-ip=213.95.11.211; helo=verein.lst.de; envelope-from=hch@lst.de; receiver=lists.ozlabs.org) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4V8gbC1b3Kz3vdh for ; Wed, 3 Apr 2024 21:14:30 +1100 (AEDT) Received: by verein.lst.de (Postfix, from userid 2407) id 44E2068BEB; Wed, 3 Apr 2024 12:14:22 +0200 (CEST) Date: Wed, 3 Apr 2024 12:14:22 +0200 From: Christoph Hellwig To: David Howells Subject: Re: [PATCH 15/26] mm: Export writeback_iter() Message-ID: <20240403101422.GA7285@lst.de> References: <20240403085918.GA1178@lst.de> <20240328163424.2781320-1-dhowells@redhat.com> <20240328163424.2781320-16-dhowells@redhat.com> <3235934.1712139047@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3235934.1712139047@warthog.procyon.org.uk> User-Agent: Mutt/1.5.17 (2007-11-01) X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dominique Martinet , linux-mm@kvack.org, Marc Dionne , linux-afs@lists.infradead.org, Paulo Alcantara , linux-cifs@vger.kernel.org, Matthew Wilcox , Christoph Hellwig , Steve French , linux-cachefs@redhat.com, Gao Xiang , Ilya Dryomov , Shyam Prasad N , Tom Talpey , ceph-devel@vger.kernel.org, Eric Van Hensbergen , Christian Brauner , linux-nfs@vger.kernel.org, netdev@vger.kernel.org, v9fs@lists.linux.dev, Jeff Layton , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, netfs@lists.linux.dev, linux-erofs@lists.ozlabs.org Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" On Wed, Apr 03, 2024 at 11:10:47AM +0100, David Howells wrote: > That depends. You put a comment on write_cache_pages() saying that people > should use writeback_iter() instead. w_c_p() is not marked GPL. Is it your > intention to get rid of it? Yes. If you think you're not a derivate work of Linux you have no business using either one.