Re: [PATCH net-next 12/15] mlxsw: pci: Break mlxsw_pci_cq_tasklet() into tasklets per queue type

[Simon Horman <horms@kernel.org>]

On Tue, Apr 02, 2024 at 03:54:25PM +0200, Petr Machata wrote:
> From: Amit Cohen <amcohen@nvidia.com>
> 
> Completion queues are used for completions of RDQ or SDQ. Each
> completion queue is used for one DQ. The first CQs are used for SDQs and
> the rest are used for RDQs.
> 
> Currently, for each CQE (completion queue element), we check 'sr' value
> (send/receive) to know if it is completion of RDQ or SDQ. Actually, we
> do not really have to check it, as according to the queue number we know
> if it handles completions of Rx or Tx.
> 
> Break the tasklet into two - one for Rx (RDQ) and one for Tx (SDQ). Then,
> setup the appropriate tasklet for each queue as part of queue
> initialization. Use 'sr' value for unlikely case that we get completion
> with type that we do not expect. Call WARN_ON_ONCE() only after checking
> the value, to avoid calling this method for each completion.
> 
> A next patch set will use NAPI to handle events, then we will have a
> separate poll method for Rx and Tx. This change is a preparation for
> NAPI usage.
> 
> Signed-off-by: Amit Cohen <amcohen@nvidia.com>
> Reviewed-by: Ido Schimmel <idosch@nvidia.com>
> Signed-off-by: Petr Machata <petrm@nvidia.com>

Reviewed-by: Simon Horman <horms@kernel.org>