From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DA414CD128A for ; Wed, 3 Apr 2024 20:45:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: Message-Id:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gcRPTpP4ZYzThP+3QYvECR/Tg4sIUsT2diSuLMb0twE=; b=SqbYVg3eQgBu26 AzW61oi4OQ9zvq//foaYfg4+FtFs5YWoNFjkFIoyjX9q7NfFoXe4+tap4+r1s5nGfHb5dTv/pkBQo PJ4HyTwInaXWebqseyfsIJQm6YOLb5hvoM+mKfBwZ34amMBUkH6pOszRVCpIZ00M6mqtoZK4vAMSe qXDTetNUVHIzULTjCrQHhTmgE8ojXfYwxiqeXDOvY5K55v7fbohnXb4rWsVfb7YkmR6HxvIXcMTF9 /BbAHdDwsKBBGJ5tHBGiwULYIwanDZS2Da24J10V1aC3OrQC3FGtezhgv4JYICqbE72iMLTKNf1Oh IguVuTNHGXaoSOTGkBZQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rs7UO-000000009fz-44MA; Wed, 03 Apr 2024 20:45:44 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rs7UM-000000009ez-0BLK; Wed, 03 Apr 2024 20:45:43 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id C7100612A4; Wed, 3 Apr 2024 20:45:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD8F4C433F1; Wed, 3 Apr 2024 20:45:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1712177140; bh=yNRma02riMpShZw5OlGNXboXuC4yjz6G1J9H55luJl0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WbDgetigVfP4aw5GQwkC4/+qzJgMfkCRZ/CwVfM+DoWhVsV2cSyKM+d0KjSYmohjG D9MNWSGnvMyDqphojTexHK6yncBn+D75NAjadehGe185l4ywdlwBA4CRdqXEgUAQpQ LFHfUu8b17Q+Go/GjBQs5pUYIY0N53InUiC/aUt8= Date: Wed, 3 Apr 2024 13:45:39 -0700 From: Andrew Morton To: Kefeng Wang Cc: Russell King , Catalin Marinas , Will Deacon , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Gordeev , Gerald Schaefer , Dave Hansen , Andy Lutomirski , Peter Zijlstra , , , , , , , Subject: Re: [PATCH v2 0/7] arch/mm/fault: accelerate pagefault when badaccess Message-Id: <20240403134539.fde3a6c594f2d88409be30ed@linux-foundation.org> In-Reply-To: <20240403083805.1818160-1-wangkefeng.wang@huawei.com> References: <20240403083805.1818160-1-wangkefeng.wang@huawei.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240403_134542_159924_56D1CA2E X-CRM114-Status: GOOD ( 10.61 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Wed, 3 Apr 2024 16:37:58 +0800 Kefeng Wang wrote: > After VMA lock-based page fault handling enabled, if bad access met > under per-vma lock, it will fallback to mmap_lock-based handling, > so it leads to unnessary mmap lock and vma find again. A test from > lmbench shows 34% improve after this changes on arm64, > > lat_sig -P 1 prot lat_sig 0.29194 -> 0.19198 > > Only build test on other archs except arm64. Thanks. So we now want a bunch of architectures to runtime test this. Do we have a selftest in place which will adequately do this? _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9457154BE2 for ; Wed, 3 Apr 2024 20:45:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712177140; cv=none; b=P+hENDA/FLCPD4oTX7xTgGDFDmTnoSvEqyPKb+svUAAdZvCD+mMgdV6s54GEAnOCjDL1R9Mrdfb6IZve2Ovr+c0rWJ2jiV8H0sG9CEPcTJQwkaYbinn4qLgGNzORBFhlGxwT6PoJ7PlNNga66UAck6BzLwFZVBPolQs3kZn2rMc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712177140; c=relaxed/simple; bh=yNRma02riMpShZw5OlGNXboXuC4yjz6G1J9H55luJl0=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=Fhnow+RAzRYEQiTrzFHo9N4/RfOqPkzYE4m0ntJXRZ8nrgm7dZATg9JuExUyblkxXjHjXxVlefQ8+OQ4OUgKb0BjAUhEU4dDBESFAkBrB5v47kb+BZLtGaN3yqCmeenkzlQinR00Sp+iHE3jWAGx63lO2WR7hIMO9DljaJ4NyuY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=WbDgetig; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="WbDgetig" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD8F4C433F1; Wed, 3 Apr 2024 20:45:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1712177140; bh=yNRma02riMpShZw5OlGNXboXuC4yjz6G1J9H55luJl0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WbDgetigVfP4aw5GQwkC4/+qzJgMfkCRZ/CwVfM+DoWhVsV2cSyKM+d0KjSYmohjG D9MNWSGnvMyDqphojTexHK6yncBn+D75NAjadehGe185l4ywdlwBA4CRdqXEgUAQpQ LFHfUu8b17Q+Go/GjBQs5pUYIY0N53InUiC/aUt8= Date: Wed, 3 Apr 2024 13:45:39 -0700 From: Andrew Morton To: Kefeng Wang Cc: Russell King , Catalin Marinas , Will Deacon , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Gordeev , Gerald Schaefer , Dave Hansen , Andy Lutomirski , Peter Zijlstra , , , , , , , Subject: Re: [PATCH v2 0/7] arch/mm/fault: accelerate pagefault when badaccess Message-Id: <20240403134539.fde3a6c594f2d88409be30ed@linux-foundation.org> In-Reply-To: <20240403083805.1818160-1-wangkefeng.wang@huawei.com> References: <20240403083805.1818160-1-wangkefeng.wang@huawei.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 3 Apr 2024 16:37:58 +0800 Kefeng Wang wrote: > After VMA lock-based page fault handling enabled, if bad access met > under per-vma lock, it will fallback to mmap_lock-based handling, > so it leads to unnessary mmap lock and vma find again. A test from > lmbench shows 34% improve after this changes on arm64, > > lat_sig -P 1 prot lat_sig 0.29194 -> 0.19198 > > Only build test on other archs except arm64. Thanks. So we now want a bunch of architectures to runtime test this. Do we have a selftest in place which will adequately do this? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F361CD128A for ; Wed, 3 Apr 2024 20:46:27 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linux-foundation.org header.i=@linux-foundation.org header.a=rsa-sha256 header.s=korg header.b=WbDgetig; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4V8xcL43rtz3vZ1 for ; Thu, 4 Apr 2024 07:46:26 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linux-foundation.org header.i=@linux-foundation.org header.a=rsa-sha256 header.s=korg header.b=WbDgetig; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux-foundation.org (client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=akpm@linux-foundation.org; receiver=lists.ozlabs.org) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4V8xbX73VNz2y3b for ; Thu, 4 Apr 2024 07:45:43 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id C7100612A4; Wed, 3 Apr 2024 20:45:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD8F4C433F1; Wed, 3 Apr 2024 20:45:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1712177140; bh=yNRma02riMpShZw5OlGNXboXuC4yjz6G1J9H55luJl0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WbDgetigVfP4aw5GQwkC4/+qzJgMfkCRZ/CwVfM+DoWhVsV2cSyKM+d0KjSYmohjG D9MNWSGnvMyDqphojTexHK6yncBn+D75NAjadehGe185l4ywdlwBA4CRdqXEgUAQpQ LFHfUu8b17Q+Go/GjBQs5pUYIY0N53InUiC/aUt8= Date: Wed, 3 Apr 2024 13:45:39 -0700 From: Andrew Morton To: Kefeng Wang Subject: Re: [PATCH v2 0/7] arch/mm/fault: accelerate pagefault when badaccess Message-Id: <20240403134539.fde3a6c594f2d88409be30ed@linux-foundation.org> In-Reply-To: <20240403083805.1818160-1-wangkefeng.wang@huawei.com> References: <20240403083805.1818160-1-wangkefeng.wang@huawei.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: x86@kernel.org, linux-s390@vger.kernel.org, Albert Ou , linuxppc-dev@lists.ozlabs.org, Peter Zijlstra , Catalin Marinas , Paul Walmsley , Russell King , surenb@google.com, Dave Hansen , linux-riscv@lists.infradead.org, Palmer Dabbelt , Nicholas Piggin , Andy Lutomirski , Alexander Gordeev , Will Deacon , Gerald Schaefer , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, 3 Apr 2024 16:37:58 +0800 Kefeng Wang wrote: > After VMA lock-based page fault handling enabled, if bad access met > under per-vma lock, it will fallback to mmap_lock-based handling, > so it leads to unnessary mmap lock and vma find again. A test from > lmbench shows 34% improve after this changes on arm64, > > lat_sig -P 1 prot lat_sig 0.29194 -> 0.19198 > > Only build test on other archs except arm64. Thanks. So we now want a bunch of architectures to runtime test this. Do we have a selftest in place which will adequately do this? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C677ACD128A for ; Wed, 3 Apr 2024 20:46:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: Message-Id:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=i9vne/mP4oSRRhtrrj4CvPdDriFNzZO6XsmBY51i4o0=; b=W1b1nU+eDMJJsl dQfdg15j3b9goq/CLMetvB3QunmtPlv+TYLixahXA3UtU4PCJiK/+GPLKjiD2Rh4bbAvbLtAjJSL1 mlycTFRLmhk/Kxn5r1Tad1ZHBQAMvCwU70Bq60JpT1YDkXQ004QonaxjJfda1cQXkPm4iqkOdFEMr aL4D4DJzMD4ORXx8zOuTIa/QaCJQJRDy+DB5JeLa33zNy//4Z3aduC2K0nYxo4KUquZSTB2bo34PF 4cG3XxBYrD2RVqHXXcIetM7GYWw6fQFHjm94vbMhROvuv7aq3xVKLoAelXXnmECD84wutPY858x4B sISqT9JEHoDO74ybd9Cw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rs7UO-000000009fs-1NfW; Wed, 03 Apr 2024 20:45:44 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rs7UM-000000009ez-0BLK; Wed, 03 Apr 2024 20:45:43 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id C7100612A4; Wed, 3 Apr 2024 20:45:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD8F4C433F1; Wed, 3 Apr 2024 20:45:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1712177140; bh=yNRma02riMpShZw5OlGNXboXuC4yjz6G1J9H55luJl0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WbDgetigVfP4aw5GQwkC4/+qzJgMfkCRZ/CwVfM+DoWhVsV2cSyKM+d0KjSYmohjG D9MNWSGnvMyDqphojTexHK6yncBn+D75NAjadehGe185l4ywdlwBA4CRdqXEgUAQpQ LFHfUu8b17Q+Go/GjBQs5pUYIY0N53InUiC/aUt8= Date: Wed, 3 Apr 2024 13:45:39 -0700 From: Andrew Morton To: Kefeng Wang Cc: Russell King , Catalin Marinas , Will Deacon , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Gordeev , Gerald Schaefer , Dave Hansen , Andy Lutomirski , Peter Zijlstra , , , , , , , Subject: Re: [PATCH v2 0/7] arch/mm/fault: accelerate pagefault when badaccess Message-Id: <20240403134539.fde3a6c594f2d88409be30ed@linux-foundation.org> In-Reply-To: <20240403083805.1818160-1-wangkefeng.wang@huawei.com> References: <20240403083805.1818160-1-wangkefeng.wang@huawei.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240403_134542_159924_56D1CA2E X-CRM114-Status: GOOD ( 10.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 3 Apr 2024 16:37:58 +0800 Kefeng Wang wrote: > After VMA lock-based page fault handling enabled, if bad access met > under per-vma lock, it will fallback to mmap_lock-based handling, > so it leads to unnessary mmap lock and vma find again. A test from > lmbench shows 34% improve after this changes on arm64, > > lat_sig -P 1 prot lat_sig 0.29194 -> 0.19198 > > Only build test on other archs except arm64. Thanks. So we now want a bunch of architectures to runtime test this. Do we have a selftest in place which will adequately do this? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel