From: Greg KH <gregkh@linuxfoundation.org>
To: Joseph Salisbury <joseph.salisbury@canonical.com>
Cc: hch@lst.de, linux-kernel@vger.kernel.org,
linux-block@vger.kernel.org, axboe@kernel.dk, sashal@kernel.org,
stable@vger.kernel.org,
Francis Ginther <francis.ginther@canonical.com>
Subject: Re: [v5.15 Regression] block: rename GENHD_FL_NO_PART_SCAN to GENHD_FL_NO_PART
Date: Wed, 3 Apr 2024 19:54:28 +0200 [thread overview]
Message-ID: <2024040329-unstopped-spelling-64c8@gregkh> (raw)
In-Reply-To: <924449dc-9b1f-4943-afe3-a68c03aedbb5@canonical.com>
On Wed, Apr 03, 2024 at 01:50:09PM -0400, Joseph Salisbury wrote:
> Hi Christoph,
>
> A kernel bug report was opened against Ubuntu [0]. This bug is a regression
> introduced in mainline version v5.17-rc1 and made it's way into v5.15 stable
> updates.
>
> The following commit was identified as the cause of the regression in 5.15:
>
> c6ce1c5dd327 ("block: rename GENHD_FL_NO_PART_SCAN to GENHD_FL_NO_PART")
How is renaming a define a "regression"?
> I was hoping to get your feedback, since you are the patch author. Is the
> best approach to revert this commit, since many third parties rely on the
> name being GENHD_FL_NO_PART_SCAN in kernel headers?
External kernel modules are never an issue. Is this a userspace thing?
> Is there a specific need that you know of that requires this commit
> in the 5.15 and earlier stable kernels?
Yes. And Christoph did not do the backport, so I doubt he cares :)
Again, what in-kernel issue is caused by this?
thanks,
greg k-h
next prev parent reply other threads:[~2024-04-03 17:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 17:50 [v5.15 Regression] block: rename GENHD_FL_NO_PART_SCAN to GENHD_FL_NO_PART Joseph Salisbury
2024-04-03 17:54 ` Greg KH [this message]
2024-04-03 18:06 ` Joseph Salisbury
2024-04-03 18:40 ` Greg KH
2024-04-04 5:13 ` Greg KH
2024-04-04 15:02 ` Joseph Salisbury
2024-04-03 18:05 ` Christoph Hellwig
2024-04-03 18:10 ` Joseph Salisbury
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024040329-unstopped-spelling-64c8@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=axboe@kernel.dk \
--cc=francis.ginther@canonical.com \
--cc=hch@lst.de \
--cc=joseph.salisbury@canonical.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.