From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8FA045970 for ; Thu, 4 Apr 2024 08:24:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712219051; cv=none; b=KNYhK1bC1hNeiohxXMnaZ0QWaVpS4R5xrNSXzD54qv0xia8UB6kvRyF3lZGQUkjYPpmPB+Bu2hbTjZO6iXZCXagvBCLMWqDbtXj8Cgl9VUm4typ56Ih4iuK0OhcdYaRQJYQtxZW607sXkcnhc7EWs6qI1+14EcxAfkFKrnfE83Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712219051; c=relaxed/simple; bh=+e2vG4tCQaHsVCk2vFM+wuQLOCDfcUuBuhVC9FGmQ6w=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=n++u2Cl03LV1jt/5NaM29ZwJq4DoE+dMCsKLqw8pNezTzp+RRMH9psL/JKB/385RF0D+s4i0B5hSkKHe4ic4M0dnKvReUdtDgqSpXrqTWLs583QruVMdPfX/yy3WtZN1Jfgx32vlH+OHiVh4wZnN87BMkUBTIdSP0Jjjv6RuBL4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=d99sM31K; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="d99sM31K" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1207BC433F1; Thu, 4 Apr 2024 08:24:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1712219051; bh=+e2vG4tCQaHsVCk2vFM+wuQLOCDfcUuBuhVC9FGmQ6w=; h=From:To:Cc:Subject:Date:Reply-to:From; b=d99sM31KSfktBhoiJkxrnCfmN5lCQ+5iyIiGxqgRu8uNaQVdIhaVGgYcAtUdzGPEM Dk6uTREcaoiHYyePqmEuJbnbcw2Ffv/Ebsca9kb40nY1bHDDskyjPi3D4GiYeI4eLz gltKk/RywGhhRTnmVRoT20TL3dKe+gQ6LTb1tqN8= From: Greg Kroah-Hartman To: linux-cve-announce@vger.kernel.org Cc: Greg Kroah-Hartman Subject: CVE-2024-26802: stmmac: Clear variable when destroying workqueue Date: Thu, 4 Apr 2024 10:23:19 +0200 Message-ID: <2024040403-CVE-2024-26802-b3da@gregkh> X-Mailer: git-send-email 2.44.0 Precedence: bulk X-Mailing-List: linux-cve-announce@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Reply-to: , X-Developer-Signature: v=1; a=openpgp-sha256; l=4407; i=gregkh@linuxfoundation.org; h=from:subject:message-id; bh=+e2vG4tCQaHsVCk2vFM+wuQLOCDfcUuBuhVC9FGmQ6w=; b=owGbwMvMwCRo6H6F97bub03G02pJDGl8yemyAiVOTm4X86zk5j6aWdc9pVnRPab1YJdD8a2ql n2M3qYdsSwMgkwMsmKKLF+28RzdX3FI0cvQ9jTMHFYmkCEMXJwCMJHrbQwLdnRVy9Q570nMmeC8 31DttxbrqrL3DAsmPku3qt2p8F1vp7Tr8YJXFte81LUB X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 Content-Transfer-Encoding: 8bit Description =========== In the Linux kernel, the following vulnerability has been resolved: stmmac: Clear variable when destroying workqueue Currently when suspending driver and stopping workqueue it is checked whether workqueue is not NULL and if so, it is destroyed. Function destroy_workqueue() does drain queue and does clear variable, but it does not set workqueue variable to NULL. This can cause kernel/module panic if code attempts to clear workqueue that was not initialized. This scenario is possible when resuming suspended driver in stmmac_resume(), because there is no handling for failed stmmac_hw_setup(), which can fail and return if DMA engine has failed to initialize, and workqueue is initialized after DMA engine. Should DMA engine fail to initialize, resume will proceed normally, but interface won't work and TX queue will eventually timeout, causing 'Reset adapter' error. This then does destroy workqueue during reset process. And since workqueue is initialized after DMA engine and can be skipped, it will cause kernel/module panic. To secure against this possible crash, set workqueue variable to NULL when destroying workqueue. Log/backtrace from crash goes as follows: [88.031977]------------[ cut here ]------------ [88.031985]NETDEV WATCHDOG: eth0 (sxgmac): transmit queue 1 timed out [88.032017]WARNING: CPU: 0 PID: 0 at net/sched/sch_generic.c:477 dev_watchdog+0x390/0x398 [88.032251]---[ end trace e70de432e4d5c2c0 ]--- [88.032282]sxgmac 16d88000.ethernet eth0: Reset adapter. [88.036359]------------[ cut here ]------------ [88.036519]Call trace: [88.036523] flush_workqueue+0x3e4/0x430 [88.036528] drain_workqueue+0xc4/0x160 [88.036533] destroy_workqueue+0x40/0x270 [88.036537] stmmac_fpe_stop_wq+0x4c/0x70 [88.036541] stmmac_release+0x278/0x280 [88.036546] __dev_close_many+0xcc/0x158 [88.036551] dev_close_many+0xbc/0x190 [88.036555] dev_close.part.0+0x70/0xc0 [88.036560] dev_close+0x24/0x30 [88.036564] stmmac_service_task+0x110/0x140 [88.036569] process_one_work+0x1d8/0x4a0 [88.036573] worker_thread+0x54/0x408 [88.036578] kthread+0x164/0x170 [88.036583] ret_from_fork+0x10/0x20 [88.036588]---[ end trace e70de432e4d5c2c1 ]--- [88.036597]Unable to handle kernel NULL pointer dereference at virtual address 0000000000000004 The Linux kernel CVE team has assigned CVE-2024-26802 to this issue. Affected and fixed versions =========================== Issue introduced in 5.13 with commit 5a5586112b92 and fixed in 5.15.151 with commit 8e9955630117 Issue introduced in 5.13 with commit 5a5586112b92 and fixed in 6.1.81 with commit 17ccd9798fe0 Issue introduced in 5.13 with commit 5a5586112b92 and fixed in 6.6.21 with commit 699b103e48ce Issue introduced in 5.13 with commit 5a5586112b92 and fixed in 6.7.9 with commit f72cf22dccc9 Issue introduced in 5.13 with commit 5a5586112b92 and fixed in 6.8 with commit 8af411bbba1f Please see https://www.kernel.org for a full list of currently supported kernel versions by the kernel community. Unaffected versions might change over time as fixes are backported to older supported kernel versions. The official CVE entry at https://cve.org/CVERecord/?id=CVE-2024-26802 will be updated if fixes are backported, please check that for the most up to date information about this issue. Affected files ============== The file(s) affected by this issue are: drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Mitigation ========== The Linux kernel CVE team recommends that you update to the latest stable kernel version for this, and many other bugfixes. Individual changes are never tested alone, but rather are part of a larger kernel release. Cherry-picking individual commits is not recommended or supported by the Linux kernel community at all. If however, updating to the latest release is impossible, the individual changes to resolve this issue can be found at these commits: https://git.kernel.org/stable/c/8e99556301172465c8fe33c7f78c39a3d4ce8462 https://git.kernel.org/stable/c/17ccd9798fe0beda3db212cfa3ebe373f605cbd6 https://git.kernel.org/stable/c/699b103e48ce32d03fc86c35b37ee8ae4288c7e3 https://git.kernel.org/stable/c/f72cf22dccc94038cbbaa1029cb575bf52e5cbc8 https://git.kernel.org/stable/c/8af411bbba1f457c33734795f024d0ef26d0963f