From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41B82CD1284 for ; Thu, 4 Apr 2024 12:55:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id E464C4185E; Thu, 4 Apr 2024 12:55:39 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id Zw8oOQBESPYu; Thu, 4 Apr 2024 12:55:38 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 3A27A41839 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1712235338; bh=ViUegWaXlivcRT6tyb5DdL8TZIko2HJfQNQ8reLljuU=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=EyvDIq0biH6hUNmRlHPhoZJGAzEGQRCXyegGGj2JwmT5EE7yPppxXHhzMckaUANYS IUpilTjj0BJJDfzRxpQP/V3gLaU1TFSPPiAuWAnPKk894qyGuvzg+EQmzsNHiK1ZH7 aWvfNo2V0CWwHlltfPqH2zx/s2aEdmIZLXDTFyN3R8w8ovDn6/gaACelI4HBSIeQoh DkqGhsU8ItcoOfGQS1D6HkYy9Fzc1tMq2ulXxSIz57thS6xNde6eowzeiCUfDAf26D +ZbqR0J3rd3Vlq5xJH1CgVWCb8fcSIpjNl2cdJ6dlc3T58Qwp5vjKXOcB6xuv2gJBA o4UTcFoaSzW4w== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 3A27A41839; Thu, 4 Apr 2024 12:55:38 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 0376A1BF3D8 for ; Thu, 4 Apr 2024 12:55:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id E035482D40 for ; Thu, 4 Apr 2024 12:55:35 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id kOlyf8Z2vWiT for ; Thu, 4 Apr 2024 12:55:35 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2604:1380:40e1:4800::1; helo=sin.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org 031ED82BFD DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 031ED82BFD Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by smtp1.osuosl.org (Postfix) with ESMTPS id 031ED82BFD for ; Thu, 4 Apr 2024 12:55:34 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 4F6F1CE2FCB; Thu, 4 Apr 2024 12:55:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81528C433F1; Thu, 4 Apr 2024 12:55:27 +0000 (UTC) Date: Thu, 4 Apr 2024 13:55:25 +0100 From: Simon Horman To: Lukasz Plachno Message-ID: <20240404125525.GQ26556@kernel.org> References: <20240403102402.20144-1-lukasz.plachno@intel.com> <20240403102402.20144-3-lukasz.plachno@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240403102402.20144-3-lukasz.plachno@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712235329; bh=piYo9QgAQMJLzSMJ3LRhK+TE3bBd7tdG5/UH/HfIJc0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IUDEOBspoRxl/DL7MB77NtCe+CapCd0Y8/dwk83ZnBkwXRHtpBTFfC/92Un7GZPEY ekVMARg5hIsRmYeHMeVdJTmOBRPxFFdlqlQhucDAMGC3PeOzPg+xa/Nj/essVyvZii UerZRHaEBQ0CiToYRVBb5pKM1VTBE8Q8iR1SC55GpAPxRkwuwZjkm508K0L58H6r0l e3el3gIXOrs8tPyF+mjsiKFlExp83Lan56AB4FPDWFjhV99SGayMjMdZSF1MB8Ch5s s3oo+tgel35LpVM2MrkAZ6ks6Z+XqEvpWQdYYQ7FMahk1XevXE0vgfvDCvWe+f3g2F 1/KROFhLVjJmg== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=none dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=IUDEOBsp Subject: Re: [Intel-wired-lan] [PATCH iwl-next v8 2/2] ice: Implement 'flow-type ether' rules X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pmenzel@molgen.mpg.de, brett.creeley@amd.com, netdev@vger.kernel.org, Jakub Buchocki , aleksander.lobakin@intel.com, intel-wired-lan@lists.osuosl.org, Mateusz Pacuszka , Jacob Keller , Przemek Kitszel Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Wed, Apr 03, 2024 at 12:24:02PM +0200, Lukasz Plachno wrote: > From: Jakub Buchocki > > Add support for 'flow-type ether' Flow Director rules via ethtool. > > Create packet segment info for filter configuration based on ethtool > command parameters. Reuse infrastructure already created for > ipv4 and ipv6 flows to convert packet segment into > extraction sequence, which is later used to program the filter > inside Flow Director block of the Rx pipeline. > > Rules not containing masks are processed by the Flow Director, > and support the following set of input parameters in all combinations: > src, dst, proto, vlan-etype, vlan, action. > > It is possible to specify address mask in ethtool parameters but only > 00:00:00:00:00 and FF:FF:FF:FF:FF are valid. > The same applies to proto, vlan-etype and vlan masks: > only 0x0000 and 0xffff masks are valid. > > Testing: > (DUT) iperf3 -s > (DUT) ethtool -U ens785f0np0 flow-type ether dst \ > action 10 > (DUT) watch 'ethtool -S ens785f0np0 | grep rx_queue' > (LP) iperf3 -c ${DUT_IP} > > Counters increase only for: > 'rx_queue_10_packets' > 'rx_queue_10_bytes' > > Signed-off-by: Jakub Buchocki > Co-developed-by: Mateusz Pacuszka > Signed-off-by: Mateusz Pacuszka > Reviewed-by: Przemek Kitszel > Signed-off-by: Lukasz Plachno > Reviewed-by: Jacob Keller Reviewed-by: Simon Horman From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1418A839F8 for ; Thu, 4 Apr 2024 12:55:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712235330; cv=none; b=Y5FtKhVdHq67oqrQEZy5PJbVGS+VceoNtOBSEvQPC2jxLlkv+aOTsUpx8x1dMZTLChjyqSwP2RZJUbyp+qDTx8U7qPkNNm6C7WYFxkm4WEmvq5Re/7n1bBG1evP7yKKUsQtp7pKGx5nSMxqKpoRuid86Jc8E5Y/liTWqEgJaI7s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712235330; c=relaxed/simple; bh=piYo9QgAQMJLzSMJ3LRhK+TE3bBd7tdG5/UH/HfIJc0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dmXie+zFeS2WYoh2eKXUYsQJQ+A/x1sZ9zorIsC8eUBbQWoKeN5aQ1eA3oym4dqVKv5BFAlesE9a/x0SK5N2OLeR2ZfOXvRxEuyR/cYgoQDcdL1oeEPM51ZjN4AP4ZH/AJIRVhZx3QySQO7JllAbyOWjhyGrCsW1rA5bZ9oo3zg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IUDEOBsp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IUDEOBsp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81528C433F1; Thu, 4 Apr 2024 12:55:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712235329; bh=piYo9QgAQMJLzSMJ3LRhK+TE3bBd7tdG5/UH/HfIJc0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IUDEOBspoRxl/DL7MB77NtCe+CapCd0Y8/dwk83ZnBkwXRHtpBTFfC/92Un7GZPEY ekVMARg5hIsRmYeHMeVdJTmOBRPxFFdlqlQhucDAMGC3PeOzPg+xa/Nj/essVyvZii UerZRHaEBQ0CiToYRVBb5pKM1VTBE8Q8iR1SC55GpAPxRkwuwZjkm508K0L58H6r0l e3el3gIXOrs8tPyF+mjsiKFlExp83Lan56AB4FPDWFjhV99SGayMjMdZSF1MB8Ch5s s3oo+tgel35LpVM2MrkAZ6ks6Z+XqEvpWQdYYQ7FMahk1XevXE0vgfvDCvWe+f3g2F 1/KROFhLVjJmg== Date: Thu, 4 Apr 2024 13:55:25 +0100 From: Simon Horman To: Lukasz Plachno Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, brett.creeley@amd.com, pmenzel@molgen.mpg.de, aleksander.lobakin@intel.com, Jakub Buchocki , Mateusz Pacuszka , Przemek Kitszel , Jacob Keller Subject: Re: [PATCH iwl-next v8 2/2] ice: Implement 'flow-type ether' rules Message-ID: <20240404125525.GQ26556@kernel.org> References: <20240403102402.20144-1-lukasz.plachno@intel.com> <20240403102402.20144-3-lukasz.plachno@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240403102402.20144-3-lukasz.plachno@intel.com> On Wed, Apr 03, 2024 at 12:24:02PM +0200, Lukasz Plachno wrote: > From: Jakub Buchocki > > Add support for 'flow-type ether' Flow Director rules via ethtool. > > Create packet segment info for filter configuration based on ethtool > command parameters. Reuse infrastructure already created for > ipv4 and ipv6 flows to convert packet segment into > extraction sequence, which is later used to program the filter > inside Flow Director block of the Rx pipeline. > > Rules not containing masks are processed by the Flow Director, > and support the following set of input parameters in all combinations: > src, dst, proto, vlan-etype, vlan, action. > > It is possible to specify address mask in ethtool parameters but only > 00:00:00:00:00 and FF:FF:FF:FF:FF are valid. > The same applies to proto, vlan-etype and vlan masks: > only 0x0000 and 0xffff masks are valid. > > Testing: > (DUT) iperf3 -s > (DUT) ethtool -U ens785f0np0 flow-type ether dst \ > action 10 > (DUT) watch 'ethtool -S ens785f0np0 | grep rx_queue' > (LP) iperf3 -c ${DUT_IP} > > Counters increase only for: > 'rx_queue_10_packets' > 'rx_queue_10_bytes' > > Signed-off-by: Jakub Buchocki > Co-developed-by: Mateusz Pacuszka > Signed-off-by: Mateusz Pacuszka > Reviewed-by: Przemek Kitszel > Signed-off-by: Lukasz Plachno > Reviewed-by: Jacob Keller Reviewed-by: Simon Horman