From: "David E. Box" <david.e.box@linux.intel.com>
To: david.e.box@linux.intel.com, hdegoede@redhat.com,
ilpo.jarvinen@linux.intel.com,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org,
sathyanarayanan.kuppuswamy@linux.intel.com
Subject: [PATCH V3 7/9] tools/arch/x86/intel_sdsi: Fix meter_certificate decoding
Date: Thu, 4 Apr 2024 20:25:05 -0700 [thread overview]
Message-ID: <20240405032507.2637311-8-david.e.box@linux.intel.com> (raw)
In-Reply-To: <20240405032507.2637311-1-david.e.box@linux.intel.com>
Fix errors in the calculation of the start position of the counters and in
the display loop. While here, use a #define for the bundle count and size.
Fixes: 7fdc03a7370f ("tools/arch/x86: intel_sdsi: Add support for reading meter certificates")
Signed-off-by: David E. Box <david.e.box@linux.intel.com>
Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
---
V3 - Use macros for bundle size and count
V2 - Split of V1 patch 7
tools/arch/x86/intel_sdsi/intel_sdsi.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/tools/arch/x86/intel_sdsi/intel_sdsi.c b/tools/arch/x86/intel_sdsi/intel_sdsi.c
index a0711177e1bb..45bc69e6718e 100644
--- a/tools/arch/x86/intel_sdsi/intel_sdsi.c
+++ b/tools/arch/x86/intel_sdsi/intel_sdsi.c
@@ -394,7 +394,7 @@ static int sdsi_meter_cert_show(struct sdsi_dev *s)
printf("MMRC encoding: %.4s\n", name);
printf("MMRC counter: %d\n", mc->mmrc_counter);
- if (mc->bundle_length % 8) {
+ if (mc->bundle_length % METER_BUNDLE_SIZE) {
fprintf(stderr, "Invalid bundle length\n");
return -1;
}
@@ -405,15 +405,16 @@ static int sdsi_meter_cert_show(struct sdsi_dev *s)
return -1;
}
- bec = (void *)(mc) + sizeof(mc);
+ bec = (void *)(mc) + sizeof(*mc);
printf("Number of Feature Counters: %ld\n", BUNDLE_COUNT(mc->bundle_length));
- while (count++ < mc->bundle_length / 8) {
+ while (count < BUNDLE_COUNT(mc->bundle_length)) {
char feature[5];
feature[4] = '\0';
get_feature(bec[count].encoding, feature);
printf(" %s: %d\n", feature, bec[count].counter);
+ ++count;
}
return 0;
--
2.34.1
next prev parent reply other threads:[~2024-04-05 3:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-05 3:24 [PATCH V3 0/9] Intel On Demand changes David E. Box
2024-04-05 3:24 ` [PATCH V3 1/9] platform/x86/intel/sdsi: Set message size during writes David E. Box
2024-04-05 14:29 ` Kuppuswamy Sathyanarayanan
2024-04-05 3:25 ` [PATCH V3 2/9] platform/x86/intel/sdsi: Combine read and write mailbox flows David E. Box
2024-04-05 3:25 ` [PATCH V3 3/9] platform/x86/intel/sdsi: Add in-band BIOS lock support David E. Box
2024-04-05 3:25 ` [PATCH V3 4/9] platform/x86/intel/sdsi: Add attribute to read the current meter state David E. Box
2024-04-05 3:25 ` [PATCH V3 5/9] tools/arch/x86/intel_sdsi: Fix maximum meter bundle length David E. Box
2024-04-08 16:59 ` Ilpo Järvinen
2024-04-05 3:25 ` [PATCH V3 6/9] tools/arch/x86/intel_sdsi: Fix meter_show display David E. Box
2024-04-05 14:29 ` Kuppuswamy Sathyanarayanan
2024-04-08 17:13 ` Ilpo Järvinen
2024-04-05 3:25 ` David E. Box [this message]
2024-04-08 17:10 ` [PATCH V3 7/9] tools/arch/x86/intel_sdsi: Fix meter_certificate decoding Ilpo Järvinen
2024-04-05 3:25 ` [PATCH V3 8/9] platform/x86/intel/sdsi: Simplify ascii printing David E. Box
2024-04-08 17:22 ` Ilpo Järvinen
2024-04-08 22:11 ` David E. Box
2024-04-05 3:25 ` [PATCH V3 9/9] tools: intel_sdsi: Add current meter support David E. Box
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240405032507.2637311-8-david.e.box@linux.intel.com \
--to=david.e.box@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.