From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
Chandan Babu R <chandan.babu@oracle.com>,
Dave Chinner <david@fromorbit.com>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/3] xfs: move more logic into xfs_extent_busy_clear_one
Date: Fri, 5 Apr 2024 18:40:51 +0200 [thread overview]
Message-ID: <20240405164051.GA14726@lst.de> (raw)
In-Reply-To: <20240405154429.GZ6390@frogsfrogsfrogs>
On Fri, Apr 05, 2024 at 08:44:29AM -0700, Darrick J. Wong wrote:
> On Fri, Apr 05, 2024 at 08:07:08AM +0200, Christoph Hellwig wrote:
> > Move the handling of discarded entries into xfs_extent_busy_clear_one
> > to reuse the length check and tidy up the logic in the caller.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> AFAICT, the return value of xfs_extent_busy_clear_one is whether
> or not it actually changed the pagb_tree, right? And if that return
> value is true, then we want to wake up anyone who might be waiting on
> busy extents to clear the pagb_tree, which is what the @wakeup logic
> does, right?
Yes and yes.
next prev parent reply other threads:[~2024-04-05 16:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-05 6:07 spring cleaning for xfs_extent_busy_clear Christoph Hellwig
2024-04-05 6:07 ` [PATCH 1/3] xfs: move more logic into xfs_extent_busy_clear_one Christoph Hellwig
2024-04-05 15:44 ` Darrick J. Wong
2024-04-05 16:40 ` Christoph Hellwig [this message]
2024-04-05 6:07 ` [PATCH 2/3] xfs: unwind xfs_extent_busy_clear Christoph Hellwig
2024-04-05 15:45 ` Darrick J. Wong
2024-04-05 6:07 ` [PATCH 3/3] xfs: remove the unused xfs_extent_busy_enomem trace event Christoph Hellwig
2024-04-05 15:31 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240405164051.GA14726@lst.de \
--to=hch@lst.de \
--cc=chandan.babu@oracle.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.