From: Christoph Hellwig <hch@lst.de>
To: John Garry <john.g.garry@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
axboe@kernel.dk, linux-block@vger.kernel.org
Subject: Re: [PATCH] block: work around sparse in queue_limits_commit_update
Date: Fri, 5 Apr 2024 19:13:30 +0200 [thread overview]
Message-ID: <20240405171330.GA16914@lst.de> (raw)
In-Reply-To: <343cc769-b318-4c2d-b08a-0bc752f41f78@oracle.com>
On Fri, Apr 05, 2024 at 05:43:24PM +0100, John Garry wrote:
> This actually looks like a kernel issue - that being that the mutex API is
> not annotated for lock checking.
Oh. Yeah, that would explain the weird behavior.
> I would need to investigate further for any progress in adding that lock
> checking to the mutex API, but it did not look promising from that
> patchset. For now I suppose you can either:
> a. remove current annotation.
I can send a patch for that.
> b. change to a spinlock - I don't think that anything requiring scheduling
> is happening when updating the limits, but would need to audit to be sure.
With SCSI we'll hold it over the new ->device_configure, which must
be able to sleep.
next prev parent reply other threads:[~2024-04-05 17:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-05 8:50 [PATCH] block: work around sparse in queue_limits_commit_update Christoph Hellwig
2024-04-05 12:31 ` John Garry
2024-04-05 14:38 ` Christoph Hellwig
2024-04-05 15:13 ` John Garry
2024-04-05 16:43 ` John Garry
2024-04-05 17:13 ` Christoph Hellwig [this message]
2024-05-09 9:49 ` John Garry
2024-05-09 12:58 ` Christoph Hellwig
2024-05-09 13:50 ` John Garry
2024-05-09 14:00 ` Jens Axboe
2024-05-09 15:04 ` John Garry
2024-05-10 1:40 ` Damien Le Moal
2024-06-12 8:37 ` John Garry
2024-06-12 23:45 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240405171330.GA16914@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=john.g.garry@oracle.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.