All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Wick <sebastian.wick@redhat.com>
To: Suraj Kandpal <suraj.kandpal@intel.com>
Cc: intel-gfx@lists.freedesktop.org, chaitanya.kumar.borah@intel.com,
	uma.shankar@intel.com, ankit.k.nautiyal@intel.com,
	arun.r.murthy@intel.com, ville.syrjala@intel.com,
	naveen1.kumar@intel.com
Subject: Re: [3/7] drm/i915/dp: Fix Register bit naming
Date: Fri, 5 Apr 2024 19:16:10 +0200	[thread overview]
Message-ID: <20240405171610.GA931166@toolbox> (raw)
In-Reply-To: <20240404032931.380887-5-suraj.kandpal@intel.com>

On Thu, Apr 04, 2024 at 08:59:27AM +0530, Suraj Kandpal wrote:
> Change INTEL_EDP_HDR_TCON_SDP_COLORIMETRY enable to
> INTEL_EDP_HDR_TCON_SDP_OVERRIDE_AUX as this bit is tells TCON to
> ignore DPCD colorimetry values and take the one's sent through
> SDP.

I actually like the original name because it tells the TCON to enable
processing of SDP Colorimetry. The new name is okay as well.

> 
> Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> index 94edf982eff8..3d9723714c96 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> @@ -74,7 +74,7 @@
>  # define INTEL_EDP_HDR_TCON_BRIGHTNESS_AUX_ENABLE                     BIT(4)
>  # define INTEL_EDP_HDR_TCON_SRGB_TO_PANEL_GAMUT_ENABLE                BIT(5)
>  /* Bit 6 is reserved */
> -# define INTEL_EDP_HDR_TCON_SDP_COLORIMETRY_ENABLE                    BIT(7)
> +# define INTEL_EDP_HDR_TCON_SDP_OVERRIDE_AUX			      BIT(7)
>  
>  #define INTEL_EDP_HDR_CONTENT_LUMINANCE                                0x346 /* Pre-TGL+ */
>  #define INTEL_EDP_HDR_PANEL_LUMINANCE_OVERRIDE                         0x34A


  reply	other threads:[~2024-04-05 17:17 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-04  3:29 [PATCH 0/7] Enable Aux Based EDP HDR Suraj Kandpal
2024-04-04  3:29 ` [PATCH 1/7] drm/i915/dp: Make has_gamut_metadata_dip() non static Suraj Kandpal
2024-04-04  3:29 ` [PATCH 2/7] drm/i915/dp: Add TCON HDR capability checks Suraj Kandpal
2024-04-04  3:29 ` [PATCH 3/7] drm/i915/dp: Fix Register bit naming Suraj Kandpal
2024-04-05 17:16   ` Sebastian Wick [this message]
2024-04-05 17:40     ` [3/7] " Kandpal, Suraj
2024-04-04  3:29 ` [PATCH 4/7] drm/i915/dp: Fix comments on EDP HDR DPCD registers Suraj Kandpal
2024-04-05 17:24   ` [4/7] " Sebastian Wick
2024-04-05 17:45     ` Kandpal, Suraj
2024-04-04  3:29 ` [PATCH 5/7] drm/i915/dp: Enable AUX based backlight for HDR Suraj Kandpal
2024-04-04  8:59   ` Jani Nikula
2024-04-05 18:20   ` [5/7] " Sebastian Wick
2024-04-08  3:47     ` Kandpal, Suraj
2024-04-08  6:45     ` Kandpal, Suraj
2024-04-04  3:29 ` [PATCH 6/7] drm/i915/dp: Write panel override luminance values Suraj Kandpal
2024-04-05 17:31   ` [6/7] " Sebastian Wick
2024-04-05 17:43     ` Kandpal, Suraj
2024-04-04  3:29 ` [PATCH 7/7] drm/i915/dp: Limit brightness level to 20 Suraj Kandpal
2024-04-04  9:04   ` Jani Nikula
2024-04-04 10:15     ` Kandpal, Suraj
2024-04-05  8:37   ` [PATCH 7/7] drm/i915/dp: Limit brightness level to vbt min brightness Suraj Kandpal
2024-04-05 17:55     ` [7/7] " Sebastian Wick
2024-04-08  3:49       ` Kandpal, Suraj
2024-04-08  5:40       ` Kandpal, Suraj
2024-04-04  3:59 ` ✗ Fi.CI.SPARSE: warning for Enable Aux Based EDP HDR Patchwork
2024-04-04  4:03 ` ✓ Fi.CI.BAT: success " Patchwork
2024-04-04  5:51 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-04-05  9:20 ` ✗ Fi.CI.SPARSE: warning for Enable Aux Based EDP HDR (rev2) Patchwork
2024-04-05  9:26 ` ✓ Fi.CI.BAT: success " Patchwork
2024-04-05 16:59 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240405171610.GA931166@toolbox \
    --to=sebastian.wick@redhat.com \
    --cc=ankit.k.nautiyal@intel.com \
    --cc=arun.r.murthy@intel.com \
    --cc=chaitanya.kumar.borah@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=naveen1.kumar@intel.com \
    --cc=suraj.kandpal@intel.com \
    --cc=uma.shankar@intel.com \
    --cc=ville.syrjala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.