From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1D4A4CD129E for ; Sat, 6 Apr 2024 04:25:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id BD7BB4011A; Sat, 6 Apr 2024 04:25:22 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id i_WRwg1GMeDl; Sat, 6 Apr 2024 04:25:22 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 2D453401DD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1712377522; bh=Y7XyfiyinJ3KX0WHALt3dbLxamhT0naKVj2tIECdkcM=; h=Date:From:To:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=1cB/egXwc76QpKOXGzOe5WjTWgy4vJdYuZ5Tv838Ma41zY/TXgYtYrmghdyrDUv3b BRzTueXrtmWQnAqVRMbSoVoow4X7cSE9BcUoBtGSb/VeoXM8o0p/JCahsTA/EmQxCO r5xpei4SNQ162YOi/XxqFKJ/1OMWWwXPI58P642C04ZqwIVNIVFf0h7POdNficAt3J n/Stv9F1TV9+BRxDD3hsh2GhdhlbDlUptoyogJWjNWamkge9H4a9vUZGdUd+4m1EsV hgRQCNhoWJZE/1Q0L6kzca1O4ZqKgCg6oRsPApFtdv3oDhM1Jig4nZl/F5Tx5DI/gk 6xe0SAvi+vTyg== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 2D453401DD; Sat, 6 Apr 2024 04:25:22 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 6769A1BF2FC for ; Sat, 6 Apr 2024 04:25:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 549494011A for ; Sat, 6 Apr 2024 04:25:21 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id R8p9MQcc1L4O for ; Sat, 6 Apr 2024 04:25:20 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=145.40.73.55; helo=sin.source.kernel.org; envelope-from=kuba@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org E9EBE401DD DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org E9EBE401DD Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by smtp2.osuosl.org (Postfix) with ESMTPS id E9EBE401DD for ; Sat, 6 Apr 2024 04:25:19 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id F2A7BCE09AB; Sat, 6 Apr 2024 04:25:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 785DDC433F1; Sat, 6 Apr 2024 04:25:14 +0000 (UTC) Date: Fri, 5 Apr 2024 21:25:13 -0700 From: Jakub Kicinski To: Alexander Lobakin Message-ID: <20240405212513.0d189968@kernel.org> In-Reply-To: <20240404154402.3581254-8-aleksander.lobakin@intel.com> References: <20240404154402.3581254-1-aleksander.lobakin@intel.com> <20240404154402.3581254-8-aleksander.lobakin@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712377515; bh=ip8k07t7BfEvV53PYzakptukPEyy8283oi2ZC+w5ZEU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GwJCrKVk/BoRpIhUWtfsjbnVNUGzObkT8OxbFE/LMQTez+7rMQkGPMuqMHS1GkySM UGacUaysy+K95swWj2+rio0sN5iJa4GbJacU2BfFKksb5oVoRGzODP/+e/aAvQ3VJT nUmw61rqqQZkJ2Zo+nggYjT5rtG5SEOTx7DB+Hpyb8yj/MonmPNoFl8vY859WSSnSn SL8BEAhwn69FaK4DKSAnkjSIAtS5HBWD2LudHMb1D3uhlkewDniU3PAdmKDr+RZ0Fk 3f01J0ykZNP3LU5ZIm8LV/HYKJzTfWeyUzuFL6KdmdMw5wB6kGVQsxrL1RQiRd/ciX Pm8Xo2ZhTrlNQ== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=none dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=GwJCrKVk Subject: Re: [Intel-wired-lan] [PATCH net-next v9 7/9] libeth: add Rx buffer management X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jesper Dangaard Brouer , netdev@vger.kernel.org, Alexander Duyck , Ilias Apalodimas , Eric Dumazet , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Yunsheng Lin , intel-wired-lan@lists.osuosl.org, nex.sw.ncis.osdt.itp.upstreaming@intel.com, Christoph Lameter , Paolo Abeni , "David S. Miller" , Vlastimil Babka Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Thu, 4 Apr 2024 17:44:00 +0200 Alexander Lobakin wrote: > +/** > + * struct libeth_fq - structure representing a buffer queue > + * @fp: hotpath part of the structure Second time this happens this week, so maybe some tooling change in 6.9 but apparently kdoc does not want to know about the tagged struct: include/net/libeth/rx.h:69: warning: Excess struct member 'fp' description in 'libeth_fq' > + * @pp: &page_pool for buffer management > + * @fqes: array of Rx buffers > + * @truesize: size to allocate per buffer, w/overhead > + * @count: number of descriptors/buffers the queue has > + * @buf_len: HW-writeable length per each buffer > + * @nid: ID of the closest NUMA node with memory > + */ > +struct libeth_fq { > + struct_group_tagged(libeth_fq_fp, fp, > + struct page_pool *pp; > + struct libeth_fqe *fqes; > + > + u32 truesize; > + u32 count; > + ); > + > + /* Cold fields */ > + u32 buf_len; > + int nid; > +}; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0ED81CD129C for ; Sat, 6 Apr 2024 04:25:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E8646B0087; Sat, 6 Apr 2024 00:25:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4496F6B0089; Sat, 6 Apr 2024 00:25:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2C2AF6B008A; Sat, 6 Apr 2024 00:25:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0B89B6B0087 for ; Sat, 6 Apr 2024 00:25:22 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 894BAA0214 for ; Sat, 6 Apr 2024 04:25:21 +0000 (UTC) X-FDA: 81977817642.06.9B41AC3 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf29.hostedemail.com (Postfix) with ESMTP id 7CEC6120002 for ; Sat, 6 Apr 2024 04:25:19 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GwJCrKVk; spf=pass (imf29.hostedemail.com: domain of kuba@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=kuba@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712377520; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y7XyfiyinJ3KX0WHALt3dbLxamhT0naKVj2tIECdkcM=; b=zdpEOsTw4MtqrsRXzxI/3v6EPzakERl/+CYF9iEVzgi7DxTWIw4XRZuhHFlRsI6HYGGhEb neKv/eh4Ws4w7n62XBh9mVdOeooNTAIhqU2htPzLInjgg1BVXKyqBUTcj/VzyGCZKbQuXt rp6YkmMpC2oZxUojlwXU7BTtHCFcxL4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712377520; a=rsa-sha256; cv=none; b=JQ016J/33sgsg2638CE5ONJyQT66hVPPQkpoZ7RE6GTq8tBouCBiVxF2VPar1QoKamedFg dyxm6VpIHYInH63LoUZXKpQFJl3lXGqwiw84Lb/kF0D58wRZ/jkn4mxyk8RAZBM1AGQ5G3 l/rg796SUTpTiDhq504jWXj/bYqWW/g= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GwJCrKVk; spf=pass (imf29.hostedemail.com: domain of kuba@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=kuba@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id F2A7BCE09AB; Sat, 6 Apr 2024 04:25:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 785DDC433F1; Sat, 6 Apr 2024 04:25:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712377515; bh=ip8k07t7BfEvV53PYzakptukPEyy8283oi2ZC+w5ZEU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GwJCrKVk/BoRpIhUWtfsjbnVNUGzObkT8OxbFE/LMQTez+7rMQkGPMuqMHS1GkySM UGacUaysy+K95swWj2+rio0sN5iJa4GbJacU2BfFKksb5oVoRGzODP/+e/aAvQ3VJT nUmw61rqqQZkJ2Zo+nggYjT5rtG5SEOTx7DB+Hpyb8yj/MonmPNoFl8vY859WSSnSn SL8BEAhwn69FaK4DKSAnkjSIAtS5HBWD2LudHMb1D3uhlkewDniU3PAdmKDr+RZ0Fk 3f01J0ykZNP3LU5ZIm8LV/HYKJzTfWeyUzuFL6KdmdMw5wB6kGVQsxrL1RQiRd/ciX Pm8Xo2ZhTrlNQ== Date: Fri, 5 Apr 2024 21:25:13 -0700 From: Jakub Kicinski To: Alexander Lobakin Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , Alexander Duyck , Yunsheng Lin , Jesper Dangaard Brouer , Ilias Apalodimas , Christoph Lameter , Vlastimil Babka , Andrew Morton , nex.sw.ncis.osdt.itp.upstreaming@intel.com, netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v9 7/9] libeth: add Rx buffer management Message-ID: <20240405212513.0d189968@kernel.org> In-Reply-To: <20240404154402.3581254-8-aleksander.lobakin@intel.com> References: <20240404154402.3581254-1-aleksander.lobakin@intel.com> <20240404154402.3581254-8-aleksander.lobakin@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 7CEC6120002 X-Rspam-User: X-Stat-Signature: zitiafgztozyaicik3q7z57m3uku1mkc X-Rspamd-Server: rspam03 X-HE-Tag: 1712377519-648425 X-HE-Meta: U2FsdGVkX18dJOF+z24YQ/n/Au/gSkrjMf3e1/DwjfkSa5Nr/8mm7Zg/ou+eBJaE1OIwgseFfCgcE7eyLBZjkCkTQ7kJFloMPKS487JbqnDPp3DJ25s0WQir/DfWdCKY3wGJhfzNUCf8X+BWdMsZVhCbjsvAw9EauOvZA2zkGjZuAlpdauoti7Z+tmJTepQyvnOCOI/eir9Z2SojW+9dn7WsRyH75aQvR/ffyI4LLLehKiMtRN85mDbTwQ2n2RVkHmJP9/5Yh8hGrG1kApqL4rnZjOGm9pyrvtbuSAaOQ6Gtjga2X8r7txhJ7yTZ6eQhdE4iAeGBS4KN/lczyRQFhIu6f+zv38I7MyrlfhX6RwvurltTf4DcHE/FsR65EZCSm6twWM0BT9w2XKqHulLiquYnP7rCfB0UcdREfCYiy4wOwbk6G39nOBBv2FmXJTpjzeJgnDSVz3RkdAtd/M8Ap6WbqMjEmlg2WBL6vjsfca7ng36RtInKDJzyIObFM6rXleA3rvs/MO7UjlKg3cSg7I0WiApiMGAKb021ZIwquAWqZ6sp0ZFsh/SfZunbRPZ2nzVL9O6kSs3NFe/fWQQxXAEPr7GwTbwtRmdkOoZnB80LyB/feycV3OYK9EABDqkxe1ILiJh21A7wflAMWVCuhCNsc1/Medls4nFOuoXXBDYqk38MotATwr+T9V3kDVkLnyUjeIk1G6j5M88I6HQi0HRT7ZBf3Oy5+s3t30iN9K9sCSUGgNNqnd+oCOR+U6kStVh/26Y4gHQqKDfjyw3x9GiZy40iJSGwGP0+69juDwMnQ0CdjHj8pkVgJ1nAIMAEWz5ErCXmQTqyv/I2MERWpee2fwAcyzMaEMG1aaPobSYm8cSZ6k1CZwprQPtGx6JTzWIM5uK5snRa6ELMBZUuFpw60By3YcEg+5GW5fHojoIXBRBAW5A9mYlxT1Q4ds0kh99mBNqifh2q+R0wK6D 1sn17hwq FyaMT84LhSuYUdC8u1QLgfI3fes+OU9+egzxjr/ihcOGWsxXWemPbK/YGA3KdydAwYerVZnPU6dvTEZ6JWK2mG5ixsP6wRRxwV57KKxCv/5IznO/vVE8eXof4GakRCp8KxC3qM2jdI5z12LNQYpWRj94/6s2/LsEgL581IyMGuJCceMOr6UhsDvE3Nv4r1sOY9cj2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 4 Apr 2024 17:44:00 +0200 Alexander Lobakin wrote: > +/** > + * struct libeth_fq - structure representing a buffer queue > + * @fp: hotpath part of the structure Second time this happens this week, so maybe some tooling change in 6.9 but apparently kdoc does not want to know about the tagged struct: include/net/libeth/rx.h:69: warning: Excess struct member 'fp' description in 'libeth_fq' > + * @pp: &page_pool for buffer management > + * @fqes: array of Rx buffers > + * @truesize: size to allocate per buffer, w/overhead > + * @count: number of descriptors/buffers the queue has > + * @buf_len: HW-writeable length per each buffer > + * @nid: ID of the closest NUMA node with memory > + */ > +struct libeth_fq { > + struct_group_tagged(libeth_fq_fp, fp, > + struct page_pool *pp; > + struct libeth_fqe *fqes; > + > + u32 truesize; > + u32 count; > + ); > + > + /* Cold fields */ > + u32 buf_len; > + int nid; > +};