From: kernel test robot <lkp@intel.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [axboe-block:rw_iter 9/133] arch/powerpc/kernel/dawr.c:73:38: error: passing argument 1 of 'debugfs_write_file_bool' from incompatible pointer type
Date: Sun, 7 Apr 2024 06:33:08 +0800 [thread overview]
Message-ID: <202404070610.RCab7C38-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git rw_iter
head: 1a95bcd36c1c2fd1c92f33b5ea95c2e0a5667100
commit: d96e5fb1de409722fee4d4943e5e068935321ff7 [9/133] debugfs: convert to ->read_iter()
config: powerpc-microwatt_defconfig (https://download.01.org/0day-ci/archive/20240407/202404070610.RCab7C38-lkp@intel.com/config)
compiler: powerpc64le-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240407/202404070610.RCab7C38-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202404070610.RCab7C38-lkp@intel.com/
All errors (new ones prefixed by >>):
arch/powerpc/kernel/dawr.c: In function 'dawr_write_file_bool':
>> arch/powerpc/kernel/dawr.c:73:38: error: passing argument 1 of 'debugfs_write_file_bool' from incompatible pointer type [-Werror=incompatible-pointer-types]
73 | rc = debugfs_write_file_bool(iocb, from);
| ^~~~
| |
| struct kiocb *
In file included from arch/powerpc/kernel/dawr.c:11:
include/linux/debugfs.h:383:60: note: expected 'struct file *' but argument is of type 'struct kiocb *'
383 | static inline ssize_t debugfs_write_file_bool(struct file *file,
| ~~~~~~~~~~~~~^~~~
arch/powerpc/kernel/dawr.c:73:44: error: passing argument 2 of 'debugfs_write_file_bool' from incompatible pointer type [-Werror=incompatible-pointer-types]
73 | rc = debugfs_write_file_bool(iocb, from);
| ^~~~
| |
| struct iov_iter *
include/linux/debugfs.h:384:66: note: expected 'const char *' but argument is of type 'struct iov_iter *'
384 | const char __user *user_buf,
| ~~~~~~~~~~~~~~~~~~~^~~~~~~~
>> arch/powerpc/kernel/dawr.c:73:14: error: too few arguments to function 'debugfs_write_file_bool'
73 | rc = debugfs_write_file_bool(iocb, from);
| ^~~~~~~~~~~~~~~~~~~~~~~
include/linux/debugfs.h:383:23: note: declared here
383 | static inline ssize_t debugfs_write_file_bool(struct file *file,
| ^~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/kernel/dawr.c: At top level:
>> arch/powerpc/kernel/dawr.c:85:25: error: initialization of 'ssize_t (*)(struct kiocb *, struct iov_iter *)' {aka 'long int (*)(struct kiocb *, struct iov_iter *)'} from incompatible pointer type 'ssize_t (*)(struct file *, char *, size_t, loff_t *)' {aka 'long int (*)(struct file *, char *, long unsigned int, long long int *)'} [-Werror=incompatible-pointer-types]
85 | .read_iter = debugfs_read_file_bool,
| ^~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/kernel/dawr.c:85:25: note: (near initialization for 'dawr_enable_fops.read_iter')
cc1: some warnings being treated as errors
vim +/debugfs_write_file_bool +73 arch/powerpc/kernel/dawr.c
61
62 static ssize_t dawr_write_file_bool(struct kiocb *iocb, struct iov_iter *from)
63 {
64 struct arch_hw_breakpoint null_brk = {0};
65 size_t rc;
66
67 /* Send error to user if they hypervisor won't allow us to write DAWR */
68 if (!dawr_force_enable &&
69 firmware_has_feature(FW_FEATURE_LPAR) &&
70 set_dawr(0, &null_brk) != H_SUCCESS)
71 return -ENODEV;
72
> 73 rc = debugfs_write_file_bool(iocb, from);
74 if (rc)
75 return rc;
76
77 /* If we are clearing, make sure all CPUs have the DAWR cleared */
78 if (!dawr_force_enable)
79 smp_call_function(disable_dawrs_cb, NULL, 0);
80
81 return rc;
82 }
83
84 static const struct file_operations dawr_enable_fops = {
> 85 .read_iter = debugfs_read_file_bool,
86 .write_iter = dawr_write_file_bool,
87 .open = simple_open,
88 .llseek = default_llseek,
89 };
90
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2024-04-06 22:33 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202404070610.RCab7C38-lkp@intel.com \
--to=lkp@intel.com \
--cc=axboe@kernel.dk \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.