From: Florian Westphal <fw@strlen.de>
To: Son Dinh <dinhtrason@gmail.com>
Cc: netfilter-devel@vger.kernel.org, pablo@netfilter.org
Subject: Re: [nft PATCH] dynset: avoid errouneous assert with ipv6 concat data
Date: Sun, 7 Apr 2024 19:17:34 +0200 [thread overview]
Message-ID: <20240407171734.GA28575@breakpoint.cc> (raw)
In-Reply-To: <20240407124755.1456-1-dinhtrason@gmail.com>
Son Dinh <dinhtrason@gmail.com> wrote:
> Fix assert bug of map dynset having ipv6 concat data
>
> nft add rule ip6 table-test chain-1 update @map-X { ip6 saddr : 1000::1 . 5001 }
> nft: src/netlink_linearize.c:873: netlink_gen_expr: Assertion `dreg < ctx->reg_low' failed.
> Aborted (core dumped)
>
> The current code allocates upto 4 registers for map dynset data, but ipv6 concat
> data of a dynset requires more than 4 registers, resulting in the assert in
> netlink_gen_expr when generating netlink info for the dynset data.
Could you plese either extend an existing test case or add a new one for
this?
> - sreg_data = get_register(ctx, stmt->map.data);
This line is wrong, this sould be
sreg_data = get_register(ctx, stmt->map.data->key);
next prev parent reply other threads:[~2024-04-07 17:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-07 12:47 [nft PATCH] dynset: avoid errouneous assert with ipv6 concat data Son Dinh
2024-04-07 17:17 ` Florian Westphal [this message]
2024-04-08 4:32 ` Son Tra Dinh
2024-04-09 3:02 ` [nft PATCH v2] " Son Dinh
2024-04-09 6:23 ` [nft PATCH v3] " Son Dinh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240407171734.GA28575@breakpoint.cc \
--to=fw@strlen.de \
--cc=dinhtrason@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.