All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Gero Schwäricke" <gero.schwaericke@posteo.de>
To: Arnout Vandecappelle <arnout@mind.be>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package: linux-firmware: update linux fw bluetooth package for rtl88xx
Date: Sun,  7 Apr 2024 20:38:07 +0000	[thread overview]
Message-ID: <20240407203807.GB13509@Apollo> (raw)
In-Reply-To: <9b60fd4d-7a0e-47da-a37a-9690b4ac84db@mind.be>

On Sun, Apr 07, 2024 at 05:50:50PM +0200, Arnout Vandecappelle via buildroot wrote:
> 
> 
> On 05/03/2024 08:04, Karthikeyan Krishnasamy wrote:
> > add realtek 8821cs bluetooth firmware in linux firmware package,
> > BR2_PACKAGE_LINUX_FIRMWARE_RTL_88XX_BT config for realtek 88xx family,
> > not device specific config to enable, add fw's in realtek 88xx family
> > in build instead of adding them separately.
> 
>  I reworded this as follows.
> 
>     package/linux-firmware: RTL_88XX_BT: install all firmware
> 
>     Instead of enumerating each binary, which is cumbersome and may miss
>     some of them, simply install all binaries starting with rtl88.
> 
> 
>  Applied to master, thanks.
> 
>  Regards,
>  Arnout

Hi,

just saw this commit. In effect it added new firmware blobs for
rtl8821cs and rtl8852btu, but also removed one for rtl8852cu, was this
intentional?

  $ diff old new
  4a5,6
  > rtl8821cs_config.bin
  > rtl8821cs_fw.bin
  14a17,18
  > rtl8852btu_config.bin
  > rtl8852btu_fw.bin
  18d21
  < rtl8852cu_fw_v2.bin

Best,
Gero

> 
> > 
> > Signed-off-by: Karthikeyan Krishnasamy <karthikeyan@linumiz.com>
> > ---
> >   package/linux-firmware/linux-firmware.mk | 11 +----------
> >   1 file changed, 1 insertion(+), 10 deletions(-)
> > 
> > diff --git a/package/linux-firmware/linux-firmware.mk b/package/linux-firmware/linux-firmware.mk
> > index 60e8861abe..7e1e5cf6f2 100644
> > --- a/package/linux-firmware/linux-firmware.mk
> > +++ b/package/linux-firmware/linux-firmware.mk
> > @@ -90,16 +90,7 @@ endif
> >   # Realtek 88xx Bluetooth
> >   ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_RTL_88XX_BT),y)
> >   LINUX_FIRMWARE_FILES += \
> > -	rtl_bt/rtl8812ae_fw.bin rtl_bt/rtl8821a_fw.bin \
> > -	rtl_bt/rtl8821c_config.bin rtl_bt/rtl8821c_fw.bin \
> > -	rtl_bt/rtl8822b_config.bin rtl_bt/rtl8822b_fw.bin \
> > -	rtl_bt/rtl8822cs_config.bin rtl_bt/rtl8822cs_fw.bin \
> > -	rtl_bt/rtl8822cu_config.bin rtl_bt/rtl8822cu_fw.bin \
> > -	rtl_bt/rtl8851bu_fw.bin rtl_bt/rtl8851bu_config.bin \
> > -	rtl_bt/rtl8852au_fw.bin rtl_bt/rtl8852au_config.bin \
> > -	rtl_bt/rtl8852bu_fw.bin rtl_bt/rtl8852bu_config.bin \
> > -	rtl_bt/rtl8852cu_fw.bin rtl_bt/rtl8852cu_config.bin \
> > -	rtl_bt/rtl8852cu_fw_v2.bin
> > +	rtl_bt/rtl88*_fw.bin rtl_bt/rtl88*_config.bin
> >   LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENCE.rtlwifi_firmware.txt
> >   endif
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2024-04-07 20:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-05  7:04 [Buildroot] [PATCH] package: linux-firmware: update linux fw bluetooth package for rtl88xx Karthikeyan Krishnasamy
2024-04-07 15:50 ` Arnout Vandecappelle via buildroot
2024-04-07 20:38   ` Gero Schwäricke [this message]
2024-04-10  8:06     ` Arnout Vandecappelle via buildroot
2024-04-17 21:10       ` Gero Schwäricke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240407203807.GB13509@Apollo \
    --to=gero.schwaericke@posteo.de \
    --cc=arnout@mind.be \
    --cc=buildroot@buildroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.