All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Catalin Popescu <catalin.popescu@leica-geosystems.com>
Cc: andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, m.felsch@pengutronix.de,
	bsp-development.geo@leica-geosystems.com
Subject: Re: [PATCH net-next v3] net: phy: dp8382x: keep WOL settings across suspends
Date: Mon, 8 Apr 2024 08:43:52 +0100	[thread overview]
Message-ID: <20240408074352.GZ26556@kernel.org> (raw)
In-Reply-To: <20240404130516.2897310-1-catalin.popescu@leica-geosystems.com>

On Thu, Apr 04, 2024 at 03:05:16PM +0200, Catalin Popescu wrote:
> Unlike other ethernet PHYs from TI, PHY dp8382x has WOL enabled
> at reset. The driver explicitly disables WOL in config_init callback
> which is called during init and during resume from suspend. Hence,
> WOL is unconditionally disabled during resume, even if it was enabled
> before the suspend. We make sure that WOL configuration is persistent
> across suspends.
> 
> Signed-off-by: Catalin Popescu <catalin.popescu@leica-geosystems.com>
> ---
> Changes in v3:
>  - rename function _dp83822_set_wol to dp83822_config_wol

Reviewed-by: Simon Horman <horms@kernel.org>


      reply	other threads:[~2024-04-08  7:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-04 13:05 [PATCH net-next v3] net: phy: dp8382x: keep WOL settings across suspends Catalin Popescu
2024-04-08  7:43 ` Simon Horman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240408074352.GZ26556@kernel.org \
    --to=horms@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=bsp-development.geo@leica-geosystems.com \
    --cc=catalin.popescu@leica-geosystems.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=m.felsch@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.