From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3189A6FE35; Mon, 8 Apr 2024 13:28:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712582892; cv=none; b=j0llf6ie+aCVz79TJEFoKpkrezQufC79gqw/6BkaMj5IedZfPxDRa6oKmUKMGDJErdsVb+qziNdJnRSBHOVOtNvH078bJRxwdv6rd9CbUwTvgor7KzeAH1byN+dql25HwP/08uEJzRDuIDG1AkU9Phw90MRuPv4z/RZOeGwbli4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712582892; c=relaxed/simple; bh=qZh2Rz+KtQDtGp/uzPFSLa5vEJphHLxdTgK3nXN9QmA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JciOSgmOSpmthpWCTSWk0YB8vPXudJaFiOGBHtUQkfClaA6CjH9DVrJMCSDGp0kJ2Dc8g4fieYNv28tEEFQYlpAhDwhx4b+vO9Nic7rCnjd8bhnpC4z1y59h2Cv7V/SfdL9C9qsyGGbd+Dr610SmJPRq4FM1QxnVDmosSmi96A8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=YN/ZFP6d; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="YN/ZFP6d" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ACE28C43394; Mon, 8 Apr 2024 13:28:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1712582892; bh=qZh2Rz+KtQDtGp/uzPFSLa5vEJphHLxdTgK3nXN9QmA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YN/ZFP6dCdCVqfkL1wDBbB/8lrI14tgukiJNsgBnY+QPwnLE+mjuIgq77ozFvJ7Va NPD9kN14VDsOrnyZPQPMIUrFotkurVVHw2ZKWgXOU0dd73BkeRNRVvRZCyoBIdqjdp 7ALqRleQ03qpxj/pb+n5zmWNznZJYLBvftIzpHC0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, "Christian A. Ehrhardt" , Heikki Krogerus , Sasha Levin , Neil Armstrong Subject: [PATCH 6.6 133/252] usb: typec: ucsi: Check for notifications after init Date: Mon, 8 Apr 2024 14:57:12 +0200 Message-ID: <20240408125310.766403766@linuxfoundation.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240408125306.643546457@linuxfoundation.org> References: <20240408125306.643546457@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Christian A. Ehrhardt [ Upstream commit 808a8b9e0b87bbc72bcc1f7ddfe5d04746e7ce56 ] The completion notification for the final SET_NOTIFICATION_ENABLE command during initialization can include a connector change notification. However, at the time this completion notification is processed, the ucsi struct is not ready to handle this notification. As a result the notification is ignored and the controller never sends an interrupt again. Re-check CCI for a pending connector state change after initialization is complete. Adjust the corresponding debug message accordingly. Fixes: 71a1fa0df2a3 ("usb: typec: ucsi: Store the notification mask") Cc: stable@vger.kernel.org Signed-off-by: Christian A. Ehrhardt Reviewed-by: Heikki Krogerus Tested-by: Neil Armstrong # on SM8550-QRD Link: https://lore.kernel.org/r/20240320073927.1641788-3-lk@c--e.de Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/typec/ucsi/ucsi.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c index 70d9f4eebf1a7..15fbadaca55b1 100644 --- a/drivers/usb/typec/ucsi/ucsi.c +++ b/drivers/usb/typec/ucsi/ucsi.c @@ -959,7 +959,7 @@ void ucsi_connector_change(struct ucsi *ucsi, u8 num) struct ucsi_connector *con = &ucsi->connector[num - 1]; if (!(ucsi->ntfy & UCSI_ENABLE_NTFY_CONNECTOR_CHANGE)) { - dev_dbg(ucsi->dev, "Bogus connector change event\n"); + dev_dbg(ucsi->dev, "Early connector change event\n"); return; } @@ -1390,6 +1390,7 @@ static int ucsi_init(struct ucsi *ucsi) { struct ucsi_connector *con, *connector; u64 command, ntfy; + u32 cci; int ret; int i; @@ -1442,6 +1443,13 @@ static int ucsi_init(struct ucsi *ucsi) ucsi->connector = connector; ucsi->ntfy = ntfy; + + ret = ucsi->ops->read(ucsi, UCSI_CCI, &cci, sizeof(cci)); + if (ret) + return ret; + if (UCSI_CCI_CONNECTOR(READ_ONCE(cci))) + ucsi_connector_change(ucsi, cci); + return 0; err_unregister: -- 2.43.0