From: David Disseldorp <ddiss@suse.de>
To: Anand Jain <anand.jain@oracle.com>
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2] common/filter.btrfs: introduce _filter_snapshot
Date: Mon, 8 Apr 2024 16:12:51 +1000 [thread overview]
Message-ID: <20240408161251.258471ef@echidna> (raw)
In-Reply-To: <bedb9edc01e8938544fa5c73f716f823764c3fd9.1712549642.git.anand.jain@oracle.com>
On Mon, 8 Apr 2024 12:32:58 +0800, Anand Jain wrote:
> Btrfs-progs commit 5f87b467a9e7 ("subvolume: output the prompt line only
> when the ioctl succeeded") changed the output for snapshot command,
> updating the golden outputs.
>
> Create a helper filter to ensure the test cases pass on older btrfs-progs.
>
> Another option is to remove the 'btrfs subvolume snapshot' command output
> from the golden output and redirect it to /dev/null, but this strays from
> the bug-fix objective.
>
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
> ---
> v2: The missed testcases included now.
> Merged following two patches in v1:
> common/filter.btrfs: add a new _filter_snapshot
> btrfs: create snapshot fix golden output
Reviewed-by: David Disseldorp <ddiss@suse.de>
I think retaining the golden output makes sense for this.
next prev parent reply other threads:[~2024-04-08 6:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-05 8:45 [PATCH 0/2] fstests: btrfs: subvolume snapshot fix golden output Anand Jain
2024-04-05 8:45 ` [PATCH 1/2] common/filter.btrfs: add a new _filter_snapshot Anand Jain
2024-04-05 8:52 ` Qu Wenruo
2024-04-05 9:25 ` Anand Jain
2024-04-05 9:50 ` Qu Wenruo
2024-04-05 16:46 ` Darrick J. Wong
2024-04-05 21:44 ` Qu Wenruo
2024-04-05 8:45 ` [PATCH 2/2] btrfs: create snapshot fix golden output Anand Jain
2024-04-05 22:05 ` [PATCH 0/2] fstests: btrfs: subvolume " Qu Wenruo
2024-04-08 4:30 ` Anand Jain
2024-04-08 4:32 ` [PATCH v2] common/filter.btrfs: introduce _filter_snapshot Anand Jain
2024-04-08 6:12 ` David Disseldorp [this message]
2024-04-08 8:24 ` Qu Wenruo
2024-04-09 0:57 ` Anand Jain
2024-04-09 1:28 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240408161251.258471ef@echidna \
--to=ddiss@suse.de \
--cc=anand.jain@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.