All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <brgl@bgdev.pl>
To: "Linus Walleij" <linus.walleij@linaro.org>,
	"Kent Gibson" <warthog618@gmail.com>,
	"Gunnar Thörnqvist" <gunnar@igl.se>
Cc: linux-gpio@vger.kernel.org,
	Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: [libgpiod][PATCH 0/2] gpio-tools: allow specifying longer time periods
Date: Tue,  9 Apr 2024 11:33:31 +0200	[thread overview]
Message-ID: <20240409093333.138408-1-brgl@bgdev.pl> (raw)

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Hi Kent!

Gunnar Thörnqvist reported that he no longer can use a command like:

    $ gpioset -t 0 -p 3600s -c gpiochip0 17=0
    gpioset: invalid period: 3600s

Due to the above error. I realized we only allow ~35 minutes as we store
milliseconds in 32-bit signed integers. Here's a proposal to allow longer
time periods by using 64-bit variables.

Bartosz Golaszewski (2):
  build: fix configure error messages on missing functions
  tools: allow longer time periods

 configure.ac         |  8 +++++---
 tools/gpioget.c      |  4 ++--
 tools/gpiomon.c      | 19 ++++++++++++++-----
 tools/gpioset.c      | 16 ++++++++--------
 tools/tools-common.c | 22 ++++++++++++++++------
 tools/tools-common.h |  5 +++--
 6 files changed, 48 insertions(+), 26 deletions(-)

-- 
2.40.1


             reply	other threads:[~2024-04-09  9:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-09  9:33 Bartosz Golaszewski [this message]
2024-04-09  9:33 ` [libgpiod][PATCH 1/2] build: fix configure error messages on missing functions Bartosz Golaszewski
2024-04-10  7:47   ` Bartosz Golaszewski
2024-04-09  9:33 ` [libgpiod][PATCH 2/2] tools: allow longer time periods Bartosz Golaszewski
2024-04-09 12:55   ` Kent Gibson
2024-04-09 15:59     ` Bartosz Golaszewski
2024-04-09 23:32       ` Kent Gibson
     [not found]     ` <3f31c7bc-de8a-4552-ba48-4432b335f413@igl.se>
2024-04-09 16:05       ` Kent Gibson
2024-04-09 17:24         ` Bartosz Golaszewski
2024-04-09 23:37           ` Kent Gibson
2024-04-10  7:53             ` Bartosz Golaszewski
2024-04-10 10:19               ` Kent Gibson
2024-04-09 23:52       ` Kent Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240409093333.138408-1-brgl@bgdev.pl \
    --to=brgl@bgdev.pl \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=gunnar@igl.se \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=warthog618@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.