From: Jakub Kicinski <kuba@kernel.org>
To: Edward Adam Davis <eadavis@qq.com>
Cc: eric.dumazet@gmail.com, edumazet@google.com,
johan.hedberg@gmail.com, linux-bluetooth@vger.kernel.org,
linux-kernel@vger.kernel.org, luiz.dentz@gmail.com,
marcel@holtmann.org, netdev@vger.kernel.org,
pmenzel@molgen.mpg.de,
syzbot+d4ecae01a53fd9b42e7d@syzkaller.appspotmail.com,
syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH] net/socket: Ensure length of input socket option param >= sizeof(int)
Date: Tue, 9 Apr 2024 11:27:57 -0700 [thread overview]
Message-ID: <20240409112757.51ef8964@kernel.org> (raw)
In-Reply-To: <tencent_88401767377846C9736D0363C96C23BB4405@qq.com>
On Tue, 9 Apr 2024 22:01:45 +0800 Edward Adam Davis wrote:
> > I think I gave my feedback already.
> >
> > Please do not ignore maintainers feedback.
> >
> > This patch is absolutely wrong.
> >
> > Some setsockopt() deal with optlen == 1 just fine, thank you very much.
>
> It's better to use evidence to support your claim, rather than your "maintainer" title.
Run selftests.
next prev parent reply other threads:[~2024-04-09 18:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-05 6:55 [syzbot] [bluetooth?] KASAN: slab-out-of-bounds Read in rfcomm_sock_setsockopt syzbot
2024-04-05 9:30 ` Edward Adam Davis
2024-04-06 0:52 ` syzbot
2024-04-05 10:16 ` [PATCH] net/socket: the length value of the input socket option parameter is too small Edward Adam Davis
2024-04-05 10:56 ` bluez.test.bot
2024-04-05 11:08 ` [PATCH] " Paul Menzel
2024-04-09 12:15 ` [PATCH] net/socket: Ensure length of input socket option param >= sizeof(int) Edward Adam Davis
2024-04-09 13:07 ` Eric Dumazet
2024-04-09 13:25 ` Luiz Augusto von Dentz
2024-04-09 13:36 ` [PATCH] Bluetooth: fix oob in rfcomm_sock_setsockopt Edward Adam Davis
2024-04-09 14:11 ` Luiz Augusto von Dentz
2024-04-09 14:12 ` bluez.test.bot
2024-04-09 14:01 ` [PATCH] net/socket: Ensure length of input socket option param >= sizeof(int) Edward Adam Davis
2024-04-09 14:17 ` Eric Dumazet
2024-04-09 18:27 ` Jakub Kicinski [this message]
2024-04-09 13:08 ` bluez.test.bot
2024-04-05 11:39 ` [PATCH] net/socket: the length value of the input socket option parameter is too small Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240409112757.51ef8964@kernel.org \
--to=kuba@kernel.org \
--cc=eadavis@qq.com \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=pmenzel@molgen.mpg.de \
--cc=syzbot+d4ecae01a53fd9b42e7d@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.