From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1665CD1284 for ; Tue, 9 Apr 2024 13:47:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JSBGgv8m7pb8r+XkgoVoGpc+dUhh04tM1N1SHKqLrjs=; b=kHCuSLFcegzqY2 a1SqgkAbiZYF70yPXSK4dgvgbaPwP3OKAnX5rZPSCcgAMKpW8wc5p7H0sY64L3aENkEgr4bGUr6Yz GGe9pF36+f0WSg9wE9p06weXtk8LGPQ3gah0GdrQbtw56PBojbk65mCVIhBJ3FVY/mis6XZXaRq5x La9NAM98ASS+dStakTSEgi/ff+7GeQ0HFooXGvEQ5RoucFGySmu2mGSaMUgmDVDsGHpYOnKvYkWHJ H3isjgB5McFI1NLq3+ime8/TQpPj1DRuKU1mpvA3kF+CRRCZLJAg7mW486LdRhzU6knJOLLuw7EnX HmSORfTN/x2t6BQYRlvw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruBor-00000002F89-3DoA; Tue, 09 Apr 2024 13:47:25 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruBop-00000002F6E-0dyw; Tue, 09 Apr 2024 13:47:24 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 2F56ECE10ED; Tue, 9 Apr 2024 13:47:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E767C433F1; Tue, 9 Apr 2024 13:47:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712670440; bh=eMgGDvBhSwomIduc3Ww9nHxOHT2zRidPoz1kaAAG6Xc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OiFpcHrJrELfQ0w4lX0cktdooBbdqsoHCXatp67xvr4gT/dXvE4wa6RVsIydrq0Ce RsIqw93EknR0C4SLFv+idmJKR6ZutAE7ABCpYqG1WtfW4qdFdm07px4Sr6CvEb3wMV eNuBvEm0/6pqZY0bkHFkqKXe4mkepAUsvP3GB57ALkyiv35+N/B033wi1xMe+1mlHP 7PsPMY8c5DfwgLZ6Mgr7lrH6+ynkoJLzZOD+pdMYFQ9EwYi5qFUONZJozCwdX13aom 6VTB6jC2frvRFZAXY4S0Vf0k20CuzXzKcqgADfZDdMgG5afEEF2SIDBvU97l9C4S9M RWYC1iDthhkiA== Date: Tue, 9 Apr 2024 08:47:18 -0500 From: Rob Herring To: Arseniy Krasnov Cc: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, oxffffaa@gmail.com, kernel@sberdevices.ru Subject: Re: [PATCH v2 1/2] dt-bindings: mtd: amlogic,meson-nand: support fields for boot ROM code Message-ID: <20240409134718.GA1050037-robh@kernel.org> References: <20240408085931.456337-1-avkrasnov@salutedevices.com> <20240408085931.456337-2-avkrasnov@salutedevices.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240408085931.456337-2-avkrasnov@salutedevices.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240409_064723_451222_6DCB698F X-CRM114-Status: GOOD ( 16.80 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Mon, Apr 08, 2024 at 11:59:30AM +0300, Arseniy Krasnov wrote: > Boot ROM code on Meson requires that some pages on NAND must be written > in special mode: "short" ECC mode where each block is 384 bytes and > scrambling mode is on. Such pages located with the specified interval > within specified offset. Both interval and offset are located in the > device tree and used by driver if 'nand-is-boot-medium' is set for > NAND chip. > > Signed-off-by: Arseniy Krasnov > --- > .../bindings/mtd/amlogic,meson-nand.yaml | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml b/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml > index 57b6957c8415..80ba5003ca70 100644 > --- a/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml > +++ b/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml > @@ -64,11 +64,25 @@ patternProperties: > items: > maximum: 0 > > + amlogic,boot-page-last: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + The NFC driver needs this information to select ECC > + algorithms supported by the boot ROM. > + > + amlogic,boot-page-step: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + The NFC driver needs this information to select ECC > + algorithms supported by the boot ROM (in pages). > + > unevaluatedProperties: false > > dependencies: > nand-ecc-strength: [nand-ecc-step-size] > nand-ecc-step-size: [nand-ecc-strength] > + amlogic,boot-page-last: [nand-is-boot-medium, amlogic,boot-page-step] > + amlogic,boot-page-step: [nand-is-boot-medium, amlogic,boot-page-last] You need quotes if using the inline syntax. Rob _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C46BC67861 for ; Tue, 9 Apr 2024 13:47:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=820jKQwH/WWAlUvOjdFmI8j36IiDDdzPbhxwzkjrb9Y=; b=VCc7ox29KL8feE gmMePy2yoFCYcLvsxwg7/r0u+wvCgoULux0Zo/5joT+hArNRO6AKITkRstRhx7dE8MWa2xIGdwzgi J2CLyuBWIrgcQc0M8x+34H8hPxA9LozRE3XCrZarPk19uXPDSPLVLmCjq5uY6S0KA+bppt2aJJKg/ lvgh/pXVAHYbvkbYExM50eWsEICaWJ1j3vVFL48SYpf31ziDf7rBJnS3ZigQ4vNy+dn7nALRiv9N/ i3q3d8+fsjTICkXKfxGgvYVXQc55VNCCSrXKrA5pEZdVNH5QEeZMJTf7gvbn6DWQZEYlgbyd9phyE pQ7R7YYQx7XA43tLk/yw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruBou-00000002F8x-0iTV; Tue, 09 Apr 2024 13:47:28 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruBop-00000002F6E-0dyw; Tue, 09 Apr 2024 13:47:24 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 2F56ECE10ED; Tue, 9 Apr 2024 13:47:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E767C433F1; Tue, 9 Apr 2024 13:47:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712670440; bh=eMgGDvBhSwomIduc3Ww9nHxOHT2zRidPoz1kaAAG6Xc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OiFpcHrJrELfQ0w4lX0cktdooBbdqsoHCXatp67xvr4gT/dXvE4wa6RVsIydrq0Ce RsIqw93EknR0C4SLFv+idmJKR6ZutAE7ABCpYqG1WtfW4qdFdm07px4Sr6CvEb3wMV eNuBvEm0/6pqZY0bkHFkqKXe4mkepAUsvP3GB57ALkyiv35+N/B033wi1xMe+1mlHP 7PsPMY8c5DfwgLZ6Mgr7lrH6+ynkoJLzZOD+pdMYFQ9EwYi5qFUONZJozCwdX13aom 6VTB6jC2frvRFZAXY4S0Vf0k20CuzXzKcqgADfZDdMgG5afEEF2SIDBvU97l9C4S9M RWYC1iDthhkiA== Date: Tue, 9 Apr 2024 08:47:18 -0500 From: Rob Herring To: Arseniy Krasnov Cc: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, oxffffaa@gmail.com, kernel@sberdevices.ru Subject: Re: [PATCH v2 1/2] dt-bindings: mtd: amlogic,meson-nand: support fields for boot ROM code Message-ID: <20240409134718.GA1050037-robh@kernel.org> References: <20240408085931.456337-1-avkrasnov@salutedevices.com> <20240408085931.456337-2-avkrasnov@salutedevices.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240408085931.456337-2-avkrasnov@salutedevices.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240409_064723_451222_6DCB698F X-CRM114-Status: GOOD ( 16.80 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Mon, Apr 08, 2024 at 11:59:30AM +0300, Arseniy Krasnov wrote: > Boot ROM code on Meson requires that some pages on NAND must be written > in special mode: "short" ECC mode where each block is 384 bytes and > scrambling mode is on. Such pages located with the specified interval > within specified offset. Both interval and offset are located in the > device tree and used by driver if 'nand-is-boot-medium' is set for > NAND chip. > > Signed-off-by: Arseniy Krasnov > --- > .../bindings/mtd/amlogic,meson-nand.yaml | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml b/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml > index 57b6957c8415..80ba5003ca70 100644 > --- a/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml > +++ b/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml > @@ -64,11 +64,25 @@ patternProperties: > items: > maximum: 0 > > + amlogic,boot-page-last: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + The NFC driver needs this information to select ECC > + algorithms supported by the boot ROM. > + > + amlogic,boot-page-step: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + The NFC driver needs this information to select ECC > + algorithms supported by the boot ROM (in pages). > + > unevaluatedProperties: false > > dependencies: > nand-ecc-strength: [nand-ecc-step-size] > nand-ecc-step-size: [nand-ecc-strength] > + amlogic,boot-page-last: [nand-is-boot-medium, amlogic,boot-page-step] > + amlogic,boot-page-step: [nand-is-boot-medium, amlogic,boot-page-last] You need quotes if using the inline syntax. Rob ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F4BBC67861 for ; Tue, 9 Apr 2024 13:47:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zPaMfs2H2scgJMaC39YGbXOBQivCUD4yNbBodmPcYHA=; b=vOy25WAHTl4SVG MB4Pn3OZUdeC+DTMgu8aPT8W7H9FSp9W/YlDuYvu/B50ClBA3HQWV/KrKBo2d9GrLwdbVmrcJjT2r uPSeLTofGA4QS8t2U2Q2mriKixU22P1y+3c3V8TnRat+I33m0G2s9hN4Zu5nOmo5IJmm+sKECAlCd pt6Rn9NpLuptr9XBaR834t+50Fb2ZcX/S/AMrhpnwBgpfPzgrdgMg268z8b1FsDqDQm5rqEyJNEBD i63sYbc4hUW9S48LacTNvyFQgs3TZ3FqfbMPHGGLt7E6HBYV7+x1vhHZKPUg0r2NIWuzddGOnPHP2 TODUhtjLuyIZ92jR9hEw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruBos-00000002F8S-3PHi; Tue, 09 Apr 2024 13:47:27 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruBop-00000002F6E-0dyw; Tue, 09 Apr 2024 13:47:24 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 2F56ECE10ED; Tue, 9 Apr 2024 13:47:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E767C433F1; Tue, 9 Apr 2024 13:47:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712670440; bh=eMgGDvBhSwomIduc3Ww9nHxOHT2zRidPoz1kaAAG6Xc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OiFpcHrJrELfQ0w4lX0cktdooBbdqsoHCXatp67xvr4gT/dXvE4wa6RVsIydrq0Ce RsIqw93EknR0C4SLFv+idmJKR6ZutAE7ABCpYqG1WtfW4qdFdm07px4Sr6CvEb3wMV eNuBvEm0/6pqZY0bkHFkqKXe4mkepAUsvP3GB57ALkyiv35+N/B033wi1xMe+1mlHP 7PsPMY8c5DfwgLZ6Mgr7lrH6+ynkoJLzZOD+pdMYFQ9EwYi5qFUONZJozCwdX13aom 6VTB6jC2frvRFZAXY4S0Vf0k20CuzXzKcqgADfZDdMgG5afEEF2SIDBvU97l9C4S9M RWYC1iDthhkiA== Date: Tue, 9 Apr 2024 08:47:18 -0500 From: Rob Herring To: Arseniy Krasnov Cc: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, oxffffaa@gmail.com, kernel@sberdevices.ru Subject: Re: [PATCH v2 1/2] dt-bindings: mtd: amlogic,meson-nand: support fields for boot ROM code Message-ID: <20240409134718.GA1050037-robh@kernel.org> References: <20240408085931.456337-1-avkrasnov@salutedevices.com> <20240408085931.456337-2-avkrasnov@salutedevices.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240408085931.456337-2-avkrasnov@salutedevices.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240409_064723_451222_6DCB698F X-CRM114-Status: GOOD ( 16.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 08, 2024 at 11:59:30AM +0300, Arseniy Krasnov wrote: > Boot ROM code on Meson requires that some pages on NAND must be written > in special mode: "short" ECC mode where each block is 384 bytes and > scrambling mode is on. Such pages located with the specified interval > within specified offset. Both interval and offset are located in the > device tree and used by driver if 'nand-is-boot-medium' is set for > NAND chip. > > Signed-off-by: Arseniy Krasnov > --- > .../bindings/mtd/amlogic,meson-nand.yaml | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml b/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml > index 57b6957c8415..80ba5003ca70 100644 > --- a/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml > +++ b/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml > @@ -64,11 +64,25 @@ patternProperties: > items: > maximum: 0 > > + amlogic,boot-page-last: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + The NFC driver needs this information to select ECC > + algorithms supported by the boot ROM. > + > + amlogic,boot-page-step: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + The NFC driver needs this information to select ECC > + algorithms supported by the boot ROM (in pages). > + > unevaluatedProperties: false > > dependencies: > nand-ecc-strength: [nand-ecc-step-size] > nand-ecc-step-size: [nand-ecc-strength] > + amlogic,boot-page-last: [nand-is-boot-medium, amlogic,boot-page-step] > + amlogic,boot-page-step: [nand-is-boot-medium, amlogic,boot-page-last] You need quotes if using the inline syntax. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBA2412C531; Tue, 9 Apr 2024 13:47:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712670441; cv=none; b=iqlaIeDr207XDc5GlFyZx5O67cYOBWMOh4tG73vT4huTHztNU6TRcK89Xx+KvDprGIpDen5r0EjTNfY7fcPmF+Bnnj3ikZ/u+rVK/lujefQMGLY4l6dlEYfQchcWSdg7jta2YFA6PzeR5CMgLYPEWizCplEWVUhH/nYW1AV5FDU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712670441; c=relaxed/simple; bh=eMgGDvBhSwomIduc3Ww9nHxOHT2zRidPoz1kaAAG6Xc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qBmCxUUiBerS9LgFse8HdC/SY5Y9AeWDWryGucfPoPhfTKE6j07pMol4oecv88IooNGk7VdMdW+x96ZEKN2k1LWM8CUkcOAbqRlSKmmIjvYh/LihBbDR+oKbCk4IY9v/rodYskIJiU9lRqUBQQe+26ShwmQ4AkMaGFwr3c7RoTA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OiFpcHrJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OiFpcHrJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E767C433F1; Tue, 9 Apr 2024 13:47:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712670440; bh=eMgGDvBhSwomIduc3Ww9nHxOHT2zRidPoz1kaAAG6Xc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OiFpcHrJrELfQ0w4lX0cktdooBbdqsoHCXatp67xvr4gT/dXvE4wa6RVsIydrq0Ce RsIqw93EknR0C4SLFv+idmJKR6ZutAE7ABCpYqG1WtfW4qdFdm07px4Sr6CvEb3wMV eNuBvEm0/6pqZY0bkHFkqKXe4mkepAUsvP3GB57ALkyiv35+N/B033wi1xMe+1mlHP 7PsPMY8c5DfwgLZ6Mgr7lrH6+ynkoJLzZOD+pdMYFQ9EwYi5qFUONZJozCwdX13aom 6VTB6jC2frvRFZAXY4S0Vf0k20CuzXzKcqgADfZDdMgG5afEEF2SIDBvU97l9C4S9M RWYC1iDthhkiA== Date: Tue, 9 Apr 2024 08:47:18 -0500 From: Rob Herring To: Arseniy Krasnov Cc: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, oxffffaa@gmail.com, kernel@sberdevices.ru Subject: Re: [PATCH v2 1/2] dt-bindings: mtd: amlogic,meson-nand: support fields for boot ROM code Message-ID: <20240409134718.GA1050037-robh@kernel.org> References: <20240408085931.456337-1-avkrasnov@salutedevices.com> <20240408085931.456337-2-avkrasnov@salutedevices.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240408085931.456337-2-avkrasnov@salutedevices.com> On Mon, Apr 08, 2024 at 11:59:30AM +0300, Arseniy Krasnov wrote: > Boot ROM code on Meson requires that some pages on NAND must be written > in special mode: "short" ECC mode where each block is 384 bytes and > scrambling mode is on. Such pages located with the specified interval > within specified offset. Both interval and offset are located in the > device tree and used by driver if 'nand-is-boot-medium' is set for > NAND chip. > > Signed-off-by: Arseniy Krasnov > --- > .../bindings/mtd/amlogic,meson-nand.yaml | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml b/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml > index 57b6957c8415..80ba5003ca70 100644 > --- a/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml > +++ b/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml > @@ -64,11 +64,25 @@ patternProperties: > items: > maximum: 0 > > + amlogic,boot-page-last: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + The NFC driver needs this information to select ECC > + algorithms supported by the boot ROM. > + > + amlogic,boot-page-step: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + The NFC driver needs this information to select ECC > + algorithms supported by the boot ROM (in pages). > + > unevaluatedProperties: false > > dependencies: > nand-ecc-strength: [nand-ecc-step-size] > nand-ecc-step-size: [nand-ecc-strength] > + amlogic,boot-page-last: [nand-is-boot-medium, amlogic,boot-page-step] > + amlogic,boot-page-step: [nand-is-boot-medium, amlogic,boot-page-last] You need quotes if using the inline syntax. Rob