From: Jakub Kicinski <kuba@kernel.org>
To: Diogo Ivo <diogo.ivo@siemens.com>, aleksander.lobakin@intel.com
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
netdev@vger.kernel.org, jan.kiszka@siemens.com
Subject: Re: [PATCH net-next] net: ethernet: Move eth_*_addr_base to global symbols
Date: Tue, 9 Apr 2024 14:58:35 -0700 [thread overview]
Message-ID: <20240409145835.71c0ef8e@kernel.org> (raw)
In-Reply-To: <20240409160720.154470-2-diogo.ivo@siemens.com>
On Tue, 9 Apr 2024 17:07:18 +0100 Diogo Ivo wrote:
> Promote IPv4/6 and Ethernet reserved base addresses to global symbols
> to avoid local copies being created when these addresses are referenced.
Did someone bloat-o-meter this?
I agree it's odd but the values are tiny and I'd expect compiler
to eliminate the dead instances.
I mean, the instances are literally smaller than a pointer we'll
need to refer to them, if they can be inlined..
next prev parent reply other threads:[~2024-04-09 21:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 16:07 [PATCH net-next] net: ethernet: Move eth_*_addr_base to global symbols Diogo Ivo
2024-04-09 21:58 ` Jakub Kicinski [this message]
2024-04-10 11:48 ` Alexander Lobakin
2024-04-10 12:49 ` Alexander Lobakin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240409145835.71c0ef8e@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=davem@davemloft.net \
--cc=diogo.ivo@siemens.com \
--cc=edumazet@google.com \
--cc=jan.kiszka@siemens.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.