All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	linux-kernel@vger.kernel.org
Cc: Andy Shevchenko <andy@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>
Subject: [PATCH v1 2/2] auxdisplay: charlcd: Provide a forward declaration
Date: Tue,  9 Apr 2024 19:14:45 +0300	[thread overview]
Message-ID: <20240409161523.935384-3-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20240409161523.935384-1-andriy.shevchenko@linux.intel.com>

While there is no compilation error, strictly speaking compiler
should know about used types beforehand. Provide a forward decration
for struct charlcd_ops before using it in struct charlcd.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/auxdisplay/charlcd.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/auxdisplay/charlcd.h b/drivers/auxdisplay/charlcd.h
index eed80063a6d2..4d4287209d04 100644
--- a/drivers/auxdisplay/charlcd.h
+++ b/drivers/auxdisplay/charlcd.h
@@ -36,6 +36,8 @@ enum charlcd_lines {
 	CHARLCD_LINES_2,
 };
 
+struct charlcd_ops;
+
 struct charlcd {
 	const struct charlcd_ops *ops;
 	const unsigned char *char_conv;	/* Optional */
-- 
2.43.0.rc1.1.gbec44491f096


  parent reply	other threads:[~2024-04-09 16:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-09 16:14 [PATCH v1 0/2] auxdisplay: charlcd: Add missing macro and forward declaration Andy Shevchenko
2024-04-09 16:14 ` [PATCH v1 1/2] auxdisplay: charlcd: Add missing MODULE_DESCRIPTION() Andy Shevchenko
2024-04-11  7:31   ` Geert Uytterhoeven
2024-04-11 10:32     ` Andy Shevchenko
2024-04-09 16:14 ` Andy Shevchenko [this message]
2024-04-11  7:30   ` [PATCH v1 2/2] auxdisplay: charlcd: Provide a forward declaration Geert Uytterhoeven
2024-04-11 10:30     ` Andy Shevchenko
2024-04-23 16:35       ` Andy Shevchenko
2024-05-07 16:36         ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240409161523.935384-3-andriy.shevchenko@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=andy@kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.