From: Jakub Kicinski <kuba@kernel.org>
To: Kees Cook <keescook@chromium.org>
Cc: Sean Christopherson <seanjc@google.com>,
Shuah Khan <shuah@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
linux-kselftest@vger.kernel.org, llvm@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests: kselftest_harness: Print empty string, not empty fmt on PASS/FAIL
Date: Tue, 9 Apr 2024 16:53:22 -0700 [thread overview]
Message-ID: <20240409165322.60f1bcbc@kernel.org> (raw)
In-Reply-To: <202404091644.9CFF82A@keescook>
On Tue, 9 Apr 2024 16:46:40 -0700 Kees Cook wrote:
> ksft_test_result_code(t->exit_code, test_name, "%s",
> diagnostic ?: "");
Could work, but we need to change the callee to extract the first arg
after format from va_arg, which I wasn't sufficiently familiar with :(
next prev parent reply other threads:[~2024-04-09 23:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 22:42 [PATCH] selftests: kselftest_harness: Print empty string, not empty fmt on PASS/FAIL Sean Christopherson
2024-04-09 23:09 ` Jakub Kicinski
2024-04-09 23:46 ` Kees Cook
2024-04-09 23:53 ` Jakub Kicinski [this message]
2024-04-10 0:14 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240409165322.60f1bcbc@kernel.org \
--to=kuba@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=seanjc@google.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.