From: Jakub Kicinski <kuba@kernel.org>
To: Heng Qi <hengqi@linux.alibaba.com>
Cc: netdev@vger.kernel.org, virtualization@lists.linux.dev,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Jason Wang <jasowang@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Ratheesh Kannoth <rkannoth@marvell.com>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Subject: Re: [PATCH net-next v5 4/4] virtio-net: support dim profile fine-tuning
Date: Tue, 9 Apr 2024 18:40:20 -0700 [thread overview]
Message-ID: <20240409184020.648bc93c@kernel.org> (raw)
In-Reply-To: <1712664204-83147-5-git-send-email-hengqi@linux.alibaba.com>
On Tue, 9 Apr 2024 20:03:24 +0800 Heng Qi wrote:
> + /* DIM profile list */
> + struct dim_cq_moder rx_eqe_conf[NET_DIM_PARAMS_NUM_PROFILES];
Can you please wrap this into a structure with other necessary
information and add a pointer in struct net_device instead.
What's the point of every single driver implementing the same
boilerplate memcpy() in its get_coalesce / set_coalesce callbacks?
next prev parent reply other threads:[~2024-04-10 1:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 12:03 [PATCH net-next v5 0/4] ethtool: provide the dim profile fine-tuning channel Heng Qi
2024-04-09 12:03 ` [PATCH net-next v5 1/4] ethtool: provide customized dim profile management Heng Qi
2024-04-10 1:44 ` Jakub Kicinski
2024-04-10 3:13 ` Heng Qi
2024-04-11 13:58 ` Simon Horman
2024-04-09 12:03 ` [PATCH net-next v5 2/4] linux/dim: move profiles from .c to .h file Heng Qi
2024-04-09 12:03 ` [PATCH net-next v5 3/4] virtio-net: refactor dim initialization/destruction Heng Qi
2024-04-09 12:03 ` [PATCH net-next v5 4/4] virtio-net: support dim profile fine-tuning Heng Qi
2024-04-10 1:40 ` Jakub Kicinski [this message]
2024-04-10 3:09 ` Heng Qi
2024-04-11 1:54 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240409184020.648bc93c@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hengqi@linux.alibaba.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rkannoth@marvell.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.