From: Jakub Kicinski <kuba@kernel.org>
To: "Matthieu Baerts (NGI0)" <matttbe@kernel.org>
Cc: mptcp@lists.linux.dev, Mat Martineau <martineau@kernel.org>,
Geliang Tang <geliang@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org,
Geliang Tang <tanggeliang@kylinos.cn>
Subject: Re: [PATCH net-next v2 0/2] mptcp: add last time fields in mptcp_info
Date: Wed, 10 Apr 2024 11:34:52 -0700 [thread overview]
Message-ID: <20240410113452.56f156f4@kernel.org> (raw)
In-Reply-To: <20240410-upstream-net-next-20240405-mptcp-last-time-info-v2-0-f95bd6b33e51@kernel.org>
On Wed, 10 Apr 2024 11:48:23 +0200 Matthieu Baerts (NGI0) wrote:
> These patches from Geliang add support for the "last time" field in
> MPTCP Info, and verify that the counters look valid.
>
> Patch 1 adds these counters: last_data_sent, last_data_recv and
> last_ack_recv. They are available in the MPTCP Info, so exposed via
> getsockopt(MPTCP_INFO) and the Netlink Diag interface.
>
> Patch 2 adds a test in diag.sh MPTCP selftest, to check that the
> counters have moved by at least 250ms, after having waited twice that
> time.
Hi Mat, is this causing skips in selftests by any chance?
# 07 ....chk last_data_sent [SKIP] Feature probably not supported
# 08 ....chk last_data_recv [SKIP] Feature probably not supported
# 09 ....chk last_ack_recv [SKIP] Feature probably not supported
I'll "hide it" from patchwork for now..
--
pw-bot: defer
next prev parent reply other threads:[~2024-04-10 18:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 9:48 [PATCH net-next v2 0/2] mptcp: add last time fields in mptcp_info Matthieu Baerts (NGI0)
2024-04-10 9:48 ` [PATCH net-next v2 1/2] " Matthieu Baerts (NGI0)
2024-04-10 9:48 ` [PATCH net-next v2 2/2] selftests: mptcp: test last time mptcp_info Matthieu Baerts (NGI0)
2024-04-10 18:34 ` Jakub Kicinski [this message]
2024-04-10 19:31 ` [PATCH net-next v2 0/2] mptcp: add last time fields in mptcp_info Matthieu Baerts
2024-04-10 21:01 ` Jakub Kicinski
2024-04-11 9:17 ` Matthieu Baerts
2024-04-11 17:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240410113452.56f156f4@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geliang@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martineau@kernel.org \
--cc=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=tanggeliang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.